)]}'
{"zuul/ansible/base/callback/zuul_stream.py":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"cef6b84bab39cf6a763a5ca46322c38b9dc35294","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        self._process_result_for_localhost(result)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        def is_module_failure(msg):"},{"line_number":334,"context_line":"            if isinstance(msg, list):"},{"line_number":335,"context_line":"                msg \u003d \"\".join(msg)"},{"line_number":336,"context_line":"            return msg.startswith(\u0027MODULE FAILURE\u0027)"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f8bd9903","line":334,"range":{"start_line":334,"start_character":15,"end_line":334,"end_character":37},"updated":"2019-11-26 13:13:23.000000000","message":"I think that is not pythonic as it would fail to work with other iterables. Isn\u0027t isinstance(msg, basestring) better?","commit_id":"42d292694cc75a5c620380cb41cd260a2db08362"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"bee3efd7a5648fdbb691ff94370d34eb91d358d3","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        self._process_result_for_localhost(result)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        def is_module_failure(msg):"},{"line_number":334,"context_line":"            if isinstance(msg, list):"},{"line_number":335,"context_line":"                msg \u003d \"\".join(msg)"},{"line_number":336,"context_line":"            return msg.startswith(\u0027MODULE FAILURE\u0027)"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_589ced6f","line":334,"range":{"start_line":334,"start_character":15,"end_line":334,"end_character":37},"in_reply_to":"3fa7e38b_d8f3fde7","updated":"2019-11-26 13:28:41.000000000","message":"Actually the alternative is better, PS2 does that instead. Thanks!","commit_id":"42d292694cc75a5c620380cb41cd260a2db08362"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"f6df708d9b0760877f83af160fded3914d1718c8","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        self._process_result_for_localhost(result)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        def is_module_failure(msg):"},{"line_number":334,"context_line":"            if isinstance(msg, list):"},{"line_number":335,"context_line":"                msg \u003d \"\".join(msg)"},{"line_number":336,"context_line":"            return msg.startswith(\u0027MODULE FAILURE\u0027)"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d8f3fde7","line":334,"range":{"start_line":334,"start_character":15,"end_line":334,"end_character":37},"in_reply_to":"3fa7e38b_f8bd9903","updated":"2019-11-26 13:18:18.000000000","message":"Isn\u0027t ansible results always serialized in json? If that\u0027s the case, then list should be enough. Alternatively we could skip non str msg for that check.","commit_id":"42d292694cc75a5c620380cb41cd260a2db08362"}]}