)]}'
{"tests/test_scheduler.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"12acc0e66e534499a8dcdd17b3292653debf3a0e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    cmd \u003d [\u0027git\u0027, \u0027--git-dir\u003d%s/.git\u0027 % path, \u0027repack\u0027, \u0027-afd\u0027]"},{"line_number":70,"context_line":"    output \u003d subprocess.Popen(cmd,"},{"line_number":71,"context_line":"                              stdout\u003dsubprocess.PIPE,"},{"line_number":72,"context_line":"                              stderr\u003dsubprocess.PIPE)"},{"line_number":73,"context_line":"    out \u003d output.communicate()"},{"line_number":74,"context_line":"    if output.returncode:"},{"line_number":75,"context_line":"        print cmd"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9dWc%3D","line":72,"updated":"2014-02-06 20:01:26.000000000","message":"Lesson from logstash crm interactions, we probably want to set close_fds\u003dTrue for most of our Popen()s.","commit_id":"169219ed4899761fdc991709381d102848e67f48"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"ed4ce9529973843bd0ea144c6c1c03434e2102eb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                              stderr\u003dsubprocess.PIPE)"},{"line_number":73,"context_line":"    out \u003d output.communicate()"},{"line_number":74,"context_line":"    if output.returncode:"},{"line_number":75,"context_line":"        print cmd"},{"line_number":76,"context_line":"        print out"},{"line_number":77,"context_line":"        raise Exception(\"git repack returned %d\" % output.returncode)"},{"line_number":78,"context_line":"    return out"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9db8%3D","line":75,"updated":"2014-02-06 19:24:52.000000000","message":"Why print instead of log here? Probably it\u0027s a print debug?","commit_id":"169219ed4899761fdc991709381d102848e67f48"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"68b74d81dc3cb7f465fa9aa08307c2eea960d7f1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                              stderr\u003dsubprocess.PIPE)"},{"line_number":73,"context_line":"    out \u003d output.communicate()"},{"line_number":74,"context_line":"    if output.returncode:"},{"line_number":75,"context_line":"        print cmd"},{"line_number":76,"context_line":"        print out"},{"line_number":77,"context_line":"        raise Exception(\"git repack returned %d\" % output.returncode)"},{"line_number":78,"context_line":"    return out"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9cKU%3D","line":75,"in_reply_to":"AAAAUH%2F9db8%3D","updated":"2014-02-06 22:04:34.000000000","message":"Left over from debugging; let\u0027s just remove.","commit_id":"169219ed4899761fdc991709381d102848e67f48"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"12acc0e66e534499a8dcdd17b3292653debf3a0e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    out \u003d output.communicate()"},{"line_number":74,"context_line":"    if output.returncode:"},{"line_number":75,"context_line":"        print cmd"},{"line_number":76,"context_line":"        print out"},{"line_number":77,"context_line":"        raise Exception(\"git repack returned %d\" % output.returncode)"},{"line_number":78,"context_line":"    return out"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9dV4%3D","line":76,"updated":"2014-02-06 20:01:26.000000000","message":"Should these be log messages instead of prints? Not sure if that matters much in the test suite.","commit_id":"169219ed4899761fdc991709381d102848e67f48"}],"zuul/merger.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"12acc0e66e534499a8dcdd17b3292653debf3a0e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            self.log.debug(\"Cloning from %s to %s\" % (self.remote_url,"},{"line_number":48,"context_line":"                                                      self.local_path))"},{"line_number":49,"context_line":"            p \u003d git.RemoteProgress()"},{"line_number":50,"context_line":"            git.Repo.clone_from(self.remote_url, self.local_path, p)"},{"line_number":51,"context_line":"        repo \u003d git.Repo(self.local_path)"},{"line_number":52,"context_line":"        if self.email:"},{"line_number":53,"context_line":"            repo.config_writer().set_value(\u0027user\u0027, \u0027email\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9dRs%3D","line":50,"updated":"2014-02-06 20:01:26.000000000","message":"It isn\u0027t clear to me what the RemoteProgress argument does here. And my attempts at deciphering it from the pygit source have failed me. It appears that RemoteProgress can be used to execute callbacks at certain points during the clone operation but none appear to be in use here.","commit_id":"169219ed4899761fdc991709381d102848e67f48"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"68b74d81dc3cb7f465fa9aa08307c2eea960d7f1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            self.log.debug(\"Cloning from %s to %s\" % (self.remote_url,"},{"line_number":48,"context_line":"                                                      self.local_path))"},{"line_number":49,"context_line":"            p \u003d git.RemoteProgress()"},{"line_number":50,"context_line":"            git.Repo.clone_from(self.remote_url, self.local_path, p)"},{"line_number":51,"context_line":"        repo \u003d git.Repo(self.local_path)"},{"line_number":52,"context_line":"        if self.email:"},{"line_number":53,"context_line":"            repo.config_writer().set_value(\u0027user\u0027, \u0027email\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9cLs%3D","line":50,"in_reply_to":"AAAAUH%2F9dRs%3D","updated":"2014-02-06 22:04:34.000000000","message":"Indeed, this looks like cruft from an abortive change.","commit_id":"169219ed4899761fdc991709381d102848e67f48"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"12acc0e66e534499a8dcdd17b3292653debf3a0e","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        return commit"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _mergeItem(self, item, recent):"},{"line_number":228,"context_line":"        self.log.debug(\"Processing refspec %s for project %s / %s ref %s\" %"},{"line_number":229,"context_line":"                       (item[\u0027refspec\u0027], item[\u0027project\u0027], item[\u0027branch\u0027],"},{"line_number":230,"context_line":"                        item[\u0027ref\u0027]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9dGU%3D","line":227,"updated":"2014-02-06 20:01:26.000000000","message":"Why is recent an argument here? empty dict is the value always passed in and the ref to recent in the caller is not used.","commit_id":"169219ed4899761fdc991709381d102848e67f48"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7bc66cb49e853e28f9c4e85469d0e768918aedec","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        return commit"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _mergeItem(self, item, recent):"},{"line_number":228,"context_line":"        self.log.debug(\"Processing refspec %s for project %s / %s ref %s\" %"},{"line_number":229,"context_line":"                       (item[\u0027refspec\u0027], item[\u0027project\u0027], item[\u0027branch\u0027],"},{"line_number":230,"context_line":"                        item[\u0027ref\u0027]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9cHE%3D","line":227,"in_reply_to":"AAAAUH%2F9cLI%3D","updated":"2014-02-06 22:10:37.000000000","message":"Gotcha I see it now. The calls to _mergeItem happen in the loop so we are carrying state across calls. Missed that in the first review.","commit_id":"169219ed4899761fdc991709381d102848e67f48"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"68b74d81dc3cb7f465fa9aa08307c2eea960d7f1","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        return commit"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _mergeItem(self, item, recent):"},{"line_number":228,"context_line":"        self.log.debug(\"Processing refspec %s for project %s / %s ref %s\" %"},{"line_number":229,"context_line":"                       (item[\u0027refspec\u0027], item[\u0027project\u0027], item[\u0027branch\u0027],"},{"line_number":230,"context_line":"                        item[\u0027ref\u0027]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9cLI%3D","line":227,"in_reply_to":"AAAAUH%2F9dGU%3D","updated":"2014-02-06 22:04:34.000000000","message":"It\u0027s modified in place in this method (after all, python objects are pass-by-reference).  I guess it\u0027s a bit more of a procedural paradigm than object oriented.  For that, we\u0027d need a transient object to represent this merge operation.\n\nAt any rate, it\u0027s basically a scratch pad where the merger keeps track of the most recent commits for each project-branch as it walks down the stack.","commit_id":"169219ed4899761fdc991709381d102848e67f48"}]}
