)]}'
{"zuul/lib/ansible.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"74ad2a251b3011ce8455518b8082835fc778475c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self._getAnsible(default_version)"},{"line_number":191,"context_line":"        self.default_version \u003d default_version"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def install(self, upgrade\u003dFalse):"},{"line_number":194,"context_line":"        with concurrent.futures.ThreadPoolExecutor(max_workers\u003d2) as executor:"},{"line_number":195,"context_line":"            futures \u003d {executor.submit(a.ensure_ansible, upgrade): a"},{"line_number":196,"context_line":"                       for a in self._supported_versions.values()}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7045e443","line":193,"updated":"2020-01-17 17:15:55.000000000","message":"Let\u0027s add a comment here why we\u0027re setting it to 2.","commit_id":"1a74a09458b089f0c832dfb3b452954d2177f3f6"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"22a4dde28d34a623d54b5ef71832f81e10662a51","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        # leading to occasional failures during setup of all ansible"},{"line_number":196,"context_line":"        # environments. Thus we limit the number of workers to reduce the risk"},{"line_number":197,"context_line":"        # of hitting this race."},{"line_number":198,"context_line":"        with concurrent.futures.ThreadPoolExecutor(max_workers\u003d2) as executor:"},{"line_number":199,"context_line":"            futures \u003d {executor.submit(a.ensure_ansible, upgrade): a"},{"line_number":200,"context_line":"                       for a in self._supported_versions.values()}"},{"line_number":201,"context_line":"            for future in concurrent.futures.as_completed(futures):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7f684f87","line":198,"range":{"start_line":198,"start_character":50,"end_line":198,"end_character":65},"updated":"2020-01-18 00:39:31.000000000","message":"Why not stick to only one worker and remove the risk entirely?","commit_id":"1941770f95e435863e1e8409eb5a1235a9ef37dd"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"13badd95e292209d3f4babd90a18d227cec2959d","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        # leading to occasional failures during setup of all ansible"},{"line_number":196,"context_line":"        # environments. Thus we limit the number of workers to reduce the risk"},{"line_number":197,"context_line":"        # of hitting this race."},{"line_number":198,"context_line":"        with concurrent.futures.ThreadPoolExecutor(max_workers\u003d2) as executor:"},{"line_number":199,"context_line":"            futures \u003d {executor.submit(a.ensure_ansible, upgrade): a"},{"line_number":200,"context_line":"                       for a in self._supported_versions.values()}"},{"line_number":201,"context_line":"            for future in concurrent.futures.as_completed(futures):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_eac6bf41","line":198,"in_reply_to":"3fa7e38b_7f684f87","updated":"2020-01-18 07:43:47.000000000","message":"Serially installing quite some ansible versiones takes significantly longer each time the tox venv is recreated. Using two workers is an attempt to minimize both those races and the time to setup the venvs. If we then still face the race I\u0027d suggest to separate the caches of pip so they cannot interfere with each other.","commit_id":"1941770f95e435863e1e8409eb5a1235a9ef37dd"}]}