)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"4665e4782002b5985515e58366bb4483d622ac64","unresolved":false,"context_lines":[{"line_number":18,"context_line":"is specified for a Gerrit connection, we will only use anonymous"},{"line_number":19,"context_line":"HTTP access for the git repositories."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This restriction is not ideal, and may be able to be removed later"},{"line_number":22,"context_line":"if we find an out-of-band method of communicating a service account"},{"line_number":23,"context_line":"token to the executor in a manner that would not make it available"},{"line_number":24,"context_line":"to jobs running on it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_a41622a1","line":21,"updated":"2020-01-29 23:11:26.000000000","message":"Good point; it\u0027s basically implemented as a hidden option now, but we could expose it in the config file later if we want.","commit_id":"e249c9ab49fb7bf01014f9835ed5db63671e13da"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"b8e0f0db058891bbe5780ef95cabdf2e43ffa779","unresolved":false,"context_lines":[{"line_number":18,"context_line":"is specified for a Gerrit connection, we will only use anonymous"},{"line_number":19,"context_line":"HTTP access for the git repositories."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This restriction is not ideal, and may be able to be removed later"},{"line_number":22,"context_line":"if we find an out-of-band method of communicating a service account"},{"line_number":23,"context_line":"token to the executor in a manner that would not make it available"},{"line_number":24,"context_line":"to jobs running on it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_844c4641","line":21,"range":{"start_line":21,"start_character":31,"end_line":21,"end_character":66},"updated":"2020-01-29 22:33:44.000000000","message":"That may be something interesting to keep, being able to use executor without ssh key could be useful. Also we could use such option for the zuul-runner client.","commit_id":"e249c9ab49fb7bf01014f9835ed5db63671e13da"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b2d44d81408a94416f35536abe147edb7f0fb2ac","unresolved":false,"context_lines":[{"line_number":14,"context_line":"It is also very likely that a user may not want to expose a"},{"line_number":15,"context_line":"service account with Gerrit credentials to the executors."},{"line_number":16,"context_line":"Therefore, we can not assume that they will have access to the"},{"line_number":17,"context_line":"same service account.  Therefore if the gloud_service auth type"},{"line_number":18,"context_line":"is specified for a Gerrit connection, we will only use anonymous"},{"line_number":19,"context_line":"HTTP access for the git repositories."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_49fdd305","line":17,"range":{"start_line":17,"start_character":40,"end_line":17,"end_character":45},"updated":"2020-02-03 17:22:39.000000000","message":"gcloud - but only if you have to respin for some other reason.","commit_id":"b5a4d44645d36648836a244dd07d99c39a8f88c7"}],"zuul/driver/gerrit/gcloudauth.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"4665e4782002b5985515e58366bb4483d622ac64","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"TOKEN_URL \u003d \u0027http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/token\u0027"},{"line_number":23,"context_line":"REFRESH \u003d 25"},{"line_number":24,"context_line":"RETRY_INTERVAL \u003d 5"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_44716e13","line":22,"updated":"2020-01-29 23:11:26.000000000","message":"Nope; weird special secret internal networking makes it irrelevent I think.","commit_id":"e249c9ab49fb7bf01014f9835ed5db63671e13da"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"f871a49945ac88b2d7025bc82e6c00c09d8aba75","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"TOKEN_URL \u003d \u0027http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/token\u0027"},{"line_number":23,"context_line":"REFRESH \u003d 25"},{"line_number":24,"context_line":"RETRY_INTERVAL \u003d 5"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a4938259","line":22,"updated":"2020-01-29 22:51:18.000000000","message":"option for https?","commit_id":"e249c9ab49fb7bf01014f9835ed5db63671e13da"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"4665e4782002b5985515e58366bb4483d622ac64","unresolved":false,"context_lines":[{"line_number":22,"context_line":"TOKEN_URL \u003d \u0027http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/token\u0027"},{"line_number":23,"context_line":"REFRESH \u003d 25"},{"line_number":24,"context_line":"RETRY_INTERVAL \u003d 5"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class GCloudAuth(requests.auth.AuthBase):"},{"line_number":27,"context_line":"    log \u003d logging.getLogger(\u0027zuul.GerritConnection\u0027)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6476ea0e","line":25,"updated":"2020-01-29 23:11:26.000000000","message":"Oh drat.","commit_id":"e249c9ab49fb7bf01014f9835ed5db63671e13da"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"b8e0f0db058891bbe5780ef95cabdf2e43ffa779","unresolved":false,"context_lines":[{"line_number":22,"context_line":"TOKEN_URL \u003d \u0027http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/token\u0027"},{"line_number":23,"context_line":"REFRESH \u003d 25"},{"line_number":24,"context_line":"RETRY_INTERVAL \u003d 5"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class GCloudAuth(requests.auth.AuthBase):"},{"line_number":27,"context_line":"    log \u003d logging.getLogger(\u0027zuul.GerritConnection\u0027)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a4494230","line":25,"updated":"2020-01-29 22:33:44.000000000","message":"nit: missing new line","commit_id":"e249c9ab49fb7bf01014f9835ed5db63671e13da"}],"zuul/driver/gerrit/gerritconnection.py":[{"author":{"_account_id":30637,"name":"Jan Kubovy","email":"jan.kubovy@bmw.de","username":"kubovy"},"change_message_id":"598e3d5ce775cfc1dc74bf7ba8441dd615ceb1ab","unresolved":false,"context_lines":[{"line_number":478,"context_line":"        self.auth_type \u003d self.connection_config.get(\u0027auth_type\u0027, None)"},{"line_number":479,"context_line":"        self.anonymous_git \u003d False"},{"line_number":480,"context_line":"        if self.password or self.auth_type \u003d\u003d \u0027gcloud_service\u0027:"},{"line_number":481,"context_line":"            self.auth_type \u003d self.connection_config.get(\u0027auth_type\u0027, None)"},{"line_number":482,"context_line":"            self.verify_ssl \u003d self.connection_config.get(\u0027verify_ssl\u0027, True)"},{"line_number":483,"context_line":"            if self.verify_ssl not in [\u0027true\u0027, \u0027True\u0027, \u00271\u0027, 1, \u0027TRUE\u0027]:"},{"line_number":484,"context_line":"                self.verify_ssl \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ed3f1d82","line":481,"range":{"start_line":481,"start_character":12,"end_line":481,"end_character":74},"updated":"2020-01-30 05:16:48.000000000","message":"This got already set 3 lines above right?","commit_id":"efe520c118ecda091b06786451852a29c60dd6d7"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7fafcf8ffc8541e4005e59f9e4ce45b993527d78","unresolved":false,"context_lines":[{"line_number":478,"context_line":"        self.auth_type \u003d self.connection_config.get(\u0027auth_type\u0027, None)"},{"line_number":479,"context_line":"        self.anonymous_git \u003d False"},{"line_number":480,"context_line":"        if self.password or self.auth_type \u003d\u003d \u0027gcloud_service\u0027:"},{"line_number":481,"context_line":"            self.auth_type \u003d self.connection_config.get(\u0027auth_type\u0027, None)"},{"line_number":482,"context_line":"            self.verify_ssl \u003d self.connection_config.get(\u0027verify_ssl\u0027, True)"},{"line_number":483,"context_line":"            if self.verify_ssl not in [\u0027true\u0027, \u0027True\u0027, \u00271\u0027, 1, \u0027TRUE\u0027]:"},{"line_number":484,"context_line":"                self.verify_ssl \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5f804cbf","line":481,"updated":"2020-01-30 16:08:29.000000000","message":"Yep, thanks!","commit_id":"efe520c118ecda091b06786451852a29c60dd6d7"}]}