)]}'
{"requirements.txt":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"8c82a6dd3177bf8d997d899e515cd02bd0a8d9b8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# https://github.com/cherrypy/cheroot/issues/263"},{"line_number":36,"context_line":"cheroot\u003c8.1.0"},{"line_number":37,"context_line":"-e git+https://github.com/open-telemetry/opentelemetry-python.git#egg\u003dopentelemetry-api\u0026subdirectory\u003dopentelemetry-api"},{"line_number":38,"context_line":"-e git+https://github.com/open-telemetry/opentelemetry-python.git#egg\u003dopentelemetry-sdk\u0026subdirectory\u003dopentelemetry-sdk"}],"source_content_type":"text/plain","patch_set":2,"id":"3fa7e38b_1c311ebc","line":38,"updated":"2020-02-06 15:54:49.000000000","message":"Eek - they don\u0027t publish libraries to pypi? Ah - they do:\n\nhttps://github.com/open-telemetry/opentelemetry-python\n\nsays pip install of both should work.\n\nThat said - that also says the library is alpha. I\u0027m guessing this patch is about being proactive ... perhaps we should make this optional? So - don\u0027t depend on the libraries, put the imports behind a try/except and make the tracing class you made properly no-op if the libraries aren\u0027t installed? That way we can potentially support people who are interested in trying this before upstream thinks it\u0027s totally ready without making all the zuul deployers be impacted if open-telemetry changes their api in a way that breaks things?","commit_id":"9512286a006cd8a73c672161c9848d32e8a837a4"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"f31808b8ddff742660ad38a49042217b2cebd0b3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# https://github.com/cherrypy/cheroot/issues/263"},{"line_number":36,"context_line":"cheroot\u003c8.1.0"},{"line_number":37,"context_line":"-e git+https://github.com/open-telemetry/opentelemetry-python.git#egg\u003dopentelemetry-api\u0026subdirectory\u003dopentelemetry-api"},{"line_number":38,"context_line":"-e git+https://github.com/open-telemetry/opentelemetry-python.git#egg\u003dopentelemetry-sdk\u0026subdirectory\u003dopentelemetry-sdk"}],"source_content_type":"text/plain","patch_set":2,"id":"3fa7e38b_c2ae357f","line":38,"in_reply_to":"3fa7e38b_1c311ebc","updated":"2020-02-07 07:22:33.000000000","message":"Yes, the whole opentelemetry project is still in alpha. There were quite some API changes since the last 0.3.0 release and I figured that it would make sense to already use the 0.4.0 API.\n\nThis is anyways still WIP and just for getting a feel for how that could be integrate into Zuul.\n\nWe might also be able to influence the implementation of the opentelemetry Python lib, in case we see a use-case that can\u0027t be covered with the current set of APIs. Their main use-case is tracing of web services and Zuul is a little different :)","commit_id":"9512286a006cd8a73c672161c9848d32e8a837a4"}]}