)]}'
{"tests/base.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1dd142223679406acfa9d7f46bff1718ba14cb4f","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        r \u003d super(FakeGerritRefWatcher, self)._run(*args, **kw)"},{"line_number":884,"context_line":"        # Set the event so tests can confirm that the watcher has run"},{"line_number":885,"context_line":"        # after they changed something."},{"line_number":886,"context_line":"        self.connection._ref_watcher_event.set()"},{"line_number":887,"context_line":"        return r"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1749f08b","line":886,"updated":"2020-02-06 23:27:57.000000000","message":"Despite calling super() on the _run() method I\u0027m not sure this will exercise the inputs to _run or the outputs (the callbacks) because there are no projects configured on this connection to poll.\n\nThe new test cases must be triggered off of gerrit stream events type events instead?","commit_id":"9be39dc67dc2c2be3cf517664779e306105f888b"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"3871290aaa620903d816ccd7cafad8d555acb618","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        r \u003d super(FakeGerritRefWatcher, self)._run(*args, **kw)"},{"line_number":884,"context_line":"        # Set the event so tests can confirm that the watcher has run"},{"line_number":885,"context_line":"        # after they changed something."},{"line_number":886,"context_line":"        self.connection._ref_watcher_event.set()"},{"line_number":887,"context_line":"        return r"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c96c20d1","line":886,"updated":"2020-02-06 23:35:19.000000000","message":"See below comments; also, in tests, we don\u0027t automatically submit stream events, they have to be manually injected (so we have better control).  Since the new test doesn\u0027t call any \"addEvent\" methods, we can assume that shouldn\u0027t be happening here.","commit_id":"9be39dc67dc2c2be3cf517664779e306105f888b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"63455ba1a26c7292531e1a7ad7b02cbb4652b349","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        r \u003d super(FakeGerritRefWatcher, self)._run(*args, **kw)"},{"line_number":884,"context_line":"        # Set the event so tests can confirm that the watcher has run"},{"line_number":885,"context_line":"        # after they changed something."},{"line_number":886,"context_line":"        self.connection._ref_watcher_event.set()"},{"line_number":887,"context_line":"        return r"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_69a88cd9","line":886,"in_reply_to":"3fa7e38b_c96c20d1","updated":"2020-02-06 23:37:15.000000000","message":"For any followup reviewers. The bit of info I was missing is that self.connection.projects in the GitWatcher class is populated from the zuul tenant config projects list. We don\u0027t need to add any new config.","commit_id":"9be39dc67dc2c2be3cf517664779e306105f888b"}],"tests/unit/test_gerrit.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"dd7e755259f69f1b4081a5a7986149fd9e656a97","unresolved":false,"context_lines":[{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"class TestPolling(ZuulTestCase):"},{"line_number":382,"context_line":"    config_file \u003d \u0027zuul-gerrit-no-stream.conf\u0027"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    @simple_layout(\u0027layouts/gerrit-checks.yaml\u0027)"},{"line_number":385,"context_line":"    def test_config_update(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c953c014","line":382,"updated":"2020-02-06 23:33:31.000000000","message":"This points us to here:\n\nhttps://opendev.org/zuul/zuul/src/branch/master/tests/fixtures/zuul-gerrit-no-stream.conf#L26\n\nWhich says this gerrit doesn\u0027t have stream-events.","commit_id":"9be39dc67dc2c2be3cf517664779e306105f888b"}],"zuul/driver/gerrit/gerritconnection.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"dd7e755259f69f1b4081a5a7986149fd9e656a97","unresolved":false,"context_lines":[{"line_number":479,"context_line":"    replication_retry_interval \u003d 5"},{"line_number":480,"context_line":"    _poller_class \u003d GerritPoller"},{"line_number":481,"context_line":"    _ref_watcher_class \u003d GitWatcher"},{"line_number":482,"context_line":"    ref_watcher_poll_interval \u003d 60"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def __init__(self, driver, connection_name, connection_config):"},{"line_number":485,"context_line":"        super(GerritConnection, self).__init__(driver, connection_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_693accc5","line":482,"updated":"2020-02-06 23:33:31.000000000","message":"Probably eventually.","commit_id":"9be39dc67dc2c2be3cf517664779e306105f888b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1dd142223679406acfa9d7f46bff1718ba14cb4f","unresolved":false,"context_lines":[{"line_number":479,"context_line":"    replication_retry_interval \u003d 5"},{"line_number":480,"context_line":"    _poller_class \u003d GerritPoller"},{"line_number":481,"context_line":"    _ref_watcher_class \u003d GitWatcher"},{"line_number":482,"context_line":"    ref_watcher_poll_interval \u003d 60"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def __init__(self, driver, connection_name, connection_config):"},{"line_number":485,"context_line":"        super(GerritConnection, self).__init__(driver, connection_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_771e2476","line":482,"range":{"start_line":482,"start_character":32,"end_line":482,"end_character":34},"updated":"2020-02-06 23:27:57.000000000","message":"Should this be user configurable?","commit_id":"9be39dc67dc2c2be3cf517664779e306105f888b"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"dd7e755259f69f1b4081a5a7986149fd9e656a97","unresolved":false,"context_lines":[{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"        if self.enable_stream_events:"},{"line_number":1416,"context_line":"            self._start_watcher_thread()"},{"line_number":1417,"context_line":"        else:"},{"line_number":1418,"context_line":"            self._start_ref_watcher_thread()"},{"line_number":1419,"context_line":"        self._start_poller_thread()"},{"line_number":1420,"context_line":"        self._start_event_connector()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8935c8d5","line":1417,"updated":"2020-02-06 23:33:31.000000000","message":"If it doesn\u0027t have stream events, it starts a ref watcher, which watches every project on the connection.  In the test setup, every project in a simple_layout() is added to the tenant config, and therefore to the connection.","commit_id":"9be39dc67dc2c2be3cf517664779e306105f888b"}]}