)]}'
{"zuul/executor/server.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"89bdef867bacdc8be25fd5df18c084b8394459c2","unresolved":false,"context_lines":[{"line_number":2750,"context_line":"            try:"},{"line_number":2751,"context_line":"                self.process_worker.shutdown()"},{"line_number":2752,"context_line":"            except Exception:"},{"line_number":2753,"context_line":"                self.log.exception(\u0027Failed to shutdown broken process worker\u0027)"},{"line_number":2754,"context_line":"            self.process_worker \u003d ProcessPoolExecutor()"},{"line_number":2755,"context_line":""},{"line_number":2756,"context_line":"    def _innerUpdateLoop(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_c311d655","line":2753,"updated":"2020-02-22 17:56:37.000000000","message":"perhaps adding `del self.process_worker` could help?","commit_id":"9d184174f72f665e97836f13fc25577c65d7fbec"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"a5d335094619289fee9c92cfc321cdac4ab39639","unresolved":false,"context_lines":[{"line_number":2750,"context_line":"            try:"},{"line_number":2751,"context_line":"                self.process_worker.shutdown()"},{"line_number":2752,"context_line":"            except Exception:"},{"line_number":2753,"context_line":"                self.log.exception(\u0027Failed to shutdown broken process worker\u0027)"},{"line_number":2754,"context_line":"            self.process_worker \u003d ProcessPoolExecutor()"},{"line_number":2755,"context_line":""},{"line_number":2756,"context_line":"    def _innerUpdateLoop(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_4cc67319","line":2753,"in_reply_to":"1fa4df85_a31dbabe","updated":"2020-02-23 18:19:44.000000000","message":"The new worker is independent from the old one and there might be in-flight tasks that are in progress too by the old one. So in fact we don\u0027t want to kill it immediately. And if shutdown doesn\u0027t work (no idea if this ever can happen) then we just shouldn\u0027t care about it and go on.","commit_id":"9d184174f72f665e97836f13fc25577c65d7fbec"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"b02e41e0543f00b4a813e920131258ed594dd875","unresolved":false,"context_lines":[{"line_number":2750,"context_line":"            try:"},{"line_number":2751,"context_line":"                self.process_worker.shutdown()"},{"line_number":2752,"context_line":"            except Exception:"},{"line_number":2753,"context_line":"                self.log.exception(\u0027Failed to shutdown broken process worker\u0027)"},{"line_number":2754,"context_line":"            self.process_worker \u003d ProcessPoolExecutor()"},{"line_number":2755,"context_line":""},{"line_number":2756,"context_line":"    def _innerUpdateLoop(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_a31dbabe","line":2753,"in_reply_to":"1fa4df85_a3fe1aac","updated":"2020-02-22 21:40:33.000000000","message":"I thought deleting would force the garbage collector, which perhaps can be beneficial before setting up a new worker.","commit_id":"9d184174f72f665e97836f13fc25577c65d7fbec"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"a6953e2d2e12d0ed28fd5f17a5ce16f5dcf8576e","unresolved":false,"context_lines":[{"line_number":2750,"context_line":"            try:"},{"line_number":2751,"context_line":"                self.process_worker.shutdown()"},{"line_number":2752,"context_line":"            except Exception:"},{"line_number":2753,"context_line":"                self.log.exception(\u0027Failed to shutdown broken process worker\u0027)"},{"line_number":2754,"context_line":"            self.process_worker \u003d ProcessPoolExecutor()"},{"line_number":2755,"context_line":""},{"line_number":2756,"context_line":"    def _innerUpdateLoop(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_a3fe1aac","line":2753,"in_reply_to":"1fa4df85_c311d655","updated":"2020-02-22 19:57:30.000000000","message":"We\u0027re setting a new one anyway so this will be collected by the garbage collector.","commit_id":"9d184174f72f665e97836f13fc25577c65d7fbec"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"89bdef867bacdc8be25fd5df18c084b8394459c2","unresolved":false,"context_lines":[{"line_number":2786,"context_line":"            # The process pool got broken. Reset it to unbreak it for further"},{"line_number":2787,"context_line":"            # requests."},{"line_number":2788,"context_line":"            log.exception(\u0027Process pool got broken\u0027)"},{"line_number":2789,"context_line":"            self.resetProcessPool()"},{"line_number":2790,"context_line":"        except Exception:"},{"line_number":2791,"context_line":"            log.exception(\u0027Got exception while updating repo %s/%s\u0027,"},{"line_number":2792,"context_line":"                          task.connection_name, task.project_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_e30e5231","line":2789,"updated":"2020-02-22 17:56:37.000000000","message":"is this being auto-retried without sending `ABORTED` ?","commit_id":"9d184174f72f665e97836f13fc25577c65d7fbec"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"a6953e2d2e12d0ed28fd5f17a5ce16f5dcf8576e","unresolved":false,"context_lines":[{"line_number":2786,"context_line":"            # The process pool got broken. Reset it to unbreak it for further"},{"line_number":2787,"context_line":"            # requests."},{"line_number":2788,"context_line":"            log.exception(\u0027Process pool got broken\u0027)"},{"line_number":2789,"context_line":"            self.resetProcessPool()"},{"line_number":2790,"context_line":"        except Exception:"},{"line_number":2791,"context_line":"            log.exception(\u0027Got exception while updating repo %s/%s\u0027,"},{"line_number":2792,"context_line":"                          task.connection_name, task.project_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_633262aa","line":2789,"in_reply_to":"1fa4df85_e30e5231","updated":"2020-02-22 19:57:30.000000000","message":"we cannot send aborted here so we\u0027d need to take more effort reporting this back. However this only happens on something like oom so we want to at least ensure that we recover from this. I think we could improve this in general in a followup.","commit_id":"9d184174f72f665e97836f13fc25577c65d7fbec"}]}