)]}'
{"tests/base.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8ff503cce2a8dbbb274a949cb2776a6cfce3c876","unresolved":false,"context_lines":[{"line_number":2124,"context_line":"        repo.heads[self.branch].commit \u003d repo.commit(self.head_sha)"},{"line_number":2125,"context_line":""},{"line_number":2126,"context_line":""},{"line_number":2127,"context_line":"class FakeGithubClientManager(GithubClientManager):"},{"line_number":2128,"context_line":""},{"line_number":2129,"context_line":"    def __init__(self, connection_config):"},{"line_number":2130,"context_line":"        super().__init__(connection_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_b7fdcdb2","line":2127,"updated":"2020-06-22 23:11:17.000000000","message":"Should this class override _authenticateGithubAPI()? The old code didn\u0027t but that may be a good hygiene things for our tests.","commit_id":"fc4297ce96257556c7c75ed1606e7e886c451f71"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"efffc5123aacd5cabeb561723cd481ec6e37ae64","unresolved":false,"context_lines":[{"line_number":2124,"context_line":"        repo.heads[self.branch].commit \u003d repo.commit(self.head_sha)"},{"line_number":2125,"context_line":""},{"line_number":2126,"context_line":""},{"line_number":2127,"context_line":"class FakeGithubClientManager(GithubClientManager):"},{"line_number":2128,"context_line":""},{"line_number":2129,"context_line":"    def __init__(self, connection_config):"},{"line_number":2130,"context_line":"        super().__init__(connection_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_e210b752","line":2127,"in_reply_to":"bf51134e_b7fdcdb2","updated":"2020-06-30 13:23:08.000000000","message":"I think I don\u0027t understand the question. Can you elaborate why this should be overridden? I don\u0027t see a need to do this at first glance and generally we should try to override as few functions as possible in the tests.","commit_id":"fc4297ce96257556c7c75ed1606e7e886c451f71"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1d09947f8ade8937ab169503b1f06d2ed29efa81","unresolved":false,"context_lines":[{"line_number":2124,"context_line":"        repo.heads[self.branch].commit \u003d repo.commit(self.head_sha)"},{"line_number":2125,"context_line":""},{"line_number":2126,"context_line":""},{"line_number":2127,"context_line":"class FakeGithubClientManager(GithubClientManager):"},{"line_number":2128,"context_line":""},{"line_number":2129,"context_line":"    def __init__(self, connection_config):"},{"line_number":2130,"context_line":"        super().__init__(connection_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_38793e93","line":2127,"in_reply_to":"bf51134e_e210b752","updated":"2020-06-30 14:59:20.000000000","message":"Mostly I was thinking that the test will fail if it calls _authenticateGithubAPI(). That failure message may be confusing in the context of testing because why would we try to authenticate to github.com there. Instead we could override and raise with an exception that has a message that describes this should never be called. But maybe its good enough that it will fail already and we can debug from there if it happens.","commit_id":"fc4297ce96257556c7c75ed1606e7e886c451f71"}],"zuul/driver/github/githubconnection.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"bf695e45856ef935dbc0f39d35f9f72fc51d31a1","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"    driver_name \u003d \u0027github\u0027"},{"line_number":1103,"context_line":"    log \u003d logging.getLogger(\"zuul.GithubConnection\")"},{"line_number":1104,"context_line":"    payload_path \u003d \u0027payload\u0027"},{"line_number":1105,"context_line":"    client_manager_class \u003d GithubClientManager"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def __init__(self, driver, connection_name, connection_config):"},{"line_number":1108,"context_line":"        super(GithubConnection, self).__init__("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_d9ef3de7","line":1105,"updated":"2020-05-26 13:54:17.000000000","message":"Is this something we expect might be different? Seems like we could just use GithubClientManager on 1127","commit_id":"fc4297ce96257556c7c75ed1606e7e886c451f71"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"8c204e68b415edd486cb62b837d2095896c7a432","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"    driver_name \u003d \u0027github\u0027"},{"line_number":1103,"context_line":"    log \u003d logging.getLogger(\"zuul.GithubConnection\")"},{"line_number":1104,"context_line":"    payload_path \u003d \u0027payload\u0027"},{"line_number":1105,"context_line":"    client_manager_class \u003d GithubClientManager"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def __init__(self, driver, connection_name, connection_config):"},{"line_number":1108,"context_line":"        super(GithubConnection, self).__init__("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_79239106","line":1105,"in_reply_to":"ff570b3c_d9ef3de7","updated":"2020-05-26 13:57:11.000000000","message":"The tests override it in FakeGithubConnection in order to do some accounting.","commit_id":"fc4297ce96257556c7c75ed1606e7e886c451f71"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8ff503cce2a8dbbb274a949cb2776a6cfce3c876","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"            # common case for this is likely to be just one"},{"line_number":1302,"context_line":"            # installation -- change queues aren\u0027t likely to span more"},{"line_number":1303,"context_line":"            # than one installation."},{"line_number":1304,"context_line":"            pass"},{"line_number":1305,"context_line":"        else:"},{"line_number":1306,"context_line":"            # We aren\u0027t in the context of a change queue and we just"},{"line_number":1307,"context_line":"            # need to query all installations of this tenant. This currently"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_37b9bde8","line":1304,"updated":"2020-06-22 23:11:17.000000000","message":"This block reads oddly now. We\u0027ve put the logic into getGithubClientsForProjects() on line 1313, and so want to noop here. But maybe it would be better to express this as:\n\n  if not projects:\n      # We aren\u0027t in the context of a change queue....\n  # Otherwise we use the input projects list and look for changes in the supplied projects.\n\n  clients \u003d self._github_client_manager.getGithubClientsForProjects(projects)","commit_id":"fc4297ce96257556c7c75ed1606e7e886c451f71"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"efffc5123aacd5cabeb561723cd481ec6e37ae64","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"            # common case for this is likely to be just one"},{"line_number":1302,"context_line":"            # installation -- change queues aren\u0027t likely to span more"},{"line_number":1303,"context_line":"            # than one installation."},{"line_number":1304,"context_line":"            pass"},{"line_number":1305,"context_line":"        else:"},{"line_number":1306,"context_line":"            # We aren\u0027t in the context of a change queue and we just"},{"line_number":1307,"context_line":"            # need to query all installations of this tenant. This currently"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_22490f60","line":1304,"in_reply_to":"bf51134e_37b9bde8","updated":"2020-06-30 13:23:08.000000000","message":"Done","commit_id":"fc4297ce96257556c7c75ed1606e7e886c451f71"}]}