)]}'
{"doc/source/reference/pipeline_def.rst":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"034ab262de3d6655769141332d344bcde59240a5","unresolved":false,"context_lines":[{"line_number":331,"context_line":"      These reporters describe what Zuul should do when a pipeline is"},{"line_number":332,"context_line":"      disabled.  See ``disable-after-consecutive-failures``."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"   .. attr:: abort"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"      These reporters describe what Zuul should do if an item is"},{"line_number":337,"context_line":"      aborted. \"Aborted\" means any item that is dequeued but wasn\u0027t a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1fa4df85_327f1b16","line":334,"updated":"2020-03-05 17:44:22.000000000","message":"Zuul has traditionally used the words \"cancel/canceled\" to describe this state for builds (Zuul \"cancels\" a build which then reports a result of \"ABORTED\" -- that\u0027s actually just leftover from zuulv2 since that\u0027s what Jenkins reported; I\u0027d be happy to change it).  Github also uses the word cancel (though, despite being American, they use the British spelling of \"cancelled\").\n\nWe might also consider calling this \"dequeue\" since that\u0027s the action that\u0027s actually being performed, and it mirrors the \"enqueue\" reporter.  However, that might be confusing since a successful item is also dequeued, but we would not fire this reporter.\n\nAll things being equal, I think I would prefer this to be \"cancel\".","commit_id":"6825079ceb431932d320ba1c6c4bc28c6cf72557"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9b1cd9d10511751d216174f52f818988919fde0e","unresolved":false,"context_lines":[{"line_number":331,"context_line":"      These reporters describe what Zuul should do when a pipeline is"},{"line_number":332,"context_line":"      disabled.  See ``disable-after-consecutive-failures``."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"   .. attr:: abort"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"      These reporters describe what Zuul should do if an item is"},{"line_number":337,"context_line":"      aborted. \"Aborted\" means any item that is dequeued but wasn\u0027t a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1fa4df85_f2c2e333","line":334,"in_reply_to":"1fa4df85_327f1b16","updated":"2020-03-05 17:47:15.000000000","message":"I like that - and I think now that you mention it we should change the reporting of ABORTED too - since we stopped doing Jenkins a long time ago.","commit_id":"6825079ceb431932d320ba1c6c4bc28c6cf72557"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"934a7b623bab8258f9fe76ec3f40df771a86af3f","unresolved":false,"context_lines":[{"line_number":331,"context_line":"      These reporters describe what Zuul should do when a pipeline is"},{"line_number":332,"context_line":"      disabled.  See ``disable-after-consecutive-failures``."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"   .. attr:: abort"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"      These reporters describe what Zuul should do if an item is"},{"line_number":337,"context_line":"      aborted. \"Aborted\" means any item that is dequeued but wasn\u0027t a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1fa4df85_5ebe59ff","line":334,"in_reply_to":"1fa4df85_327f1b16","updated":"2020-03-06 08:07:42.000000000","message":"Thanks for the response. It was named \"dequeue\" in the beginning (that\u0027s also why the branch name/topic is still \"dequeue-reporting\"), but I had the same feeling that this might be confusing as every item is dequeued in the end. I got the point about Zuul and Jenkins, so I will change this to \"cancel\" ;-)","commit_id":"6825079ceb431932d320ba1c6c4bc28c6cf72557"}],"tests/unit/test_reporting.py":[{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"77b623753b0ceed14822ad1a66f334da5001cf1e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import zuul.rpcclient"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tests.base import ZuulTestCase, simple_layout"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_72faa1bd","line":14,"updated":"2020-03-03 14:27:03.000000000","message":"As I couldn\u0027t find any appropriate place for \"general\" reporter tests (not specific to e.g. gerrit/github/pagure/...)  I created this file. I only found a few that are mixed up in the TestScheduler() class, but I didn\u0027t want to add any more to this. If you don\u0027t like that, I could also put them somewhere else, but I think that there might be more use cases coming which could also be put in here.","commit_id":"a704b06938c3d52a6b65f4ecd559ce1f1deecbe2"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"d62d20c70bab8b551155e1feda64bcceb792b4a2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tests.base import ZuulTestCase, simple_layout"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class TestReporting(ZuulTestCase):"},{"line_number":21,"context_line":"    tenant_config_file \u003d \"config/single-tenant/main.yaml\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @simple_layout(\"layouts/abort-reporting.yaml\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_11e55ddc","line":20,"updated":"2020-03-04 08:38:34.000000000","message":"nit: I think in some of the tests you could do\n\n    self.executor_server.hold_jobs_in_build \u003d False\n    self.executor_server.release()\n    self.waitUntilSettled()\n\nearlier, instead of releasing one-by-one. It looks like you are mainly interested/asserting on the end state.","commit_id":"a704b06938c3d52a6b65f4ecd559ce1f1deecbe2"}]}