)]}'
{"zuul/executor/client.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"50b05634918cc370fda2b675ef1b112d9c7b941b","unresolved":false,"context_lines":[{"line_number":501,"context_line":"                else:"},{"line_number":502,"context_line":"                    # Unsetting the pause flag outside of event processing is"},{"line_number":503,"context_line":"                    # safe."},{"line_number":504,"context_line":"                    build.paused \u003d False"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"            if not started:"},{"line_number":507,"context_line":"                self.log.info(\"Build %s started\" % job)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_b6cb9e48","line":504,"updated":"2020-04-03 16:58:11.000000000","message":"If, somehow, the build is unpaused on the executor before this event is processed (for example, the executor is being shut down), it may be possible to clear the paused flag here immediately, and then later have the event processor set it.  I don\u0027t know if that would be a problem in practice, but...\n\nI think we can make this simpler by just doing less.  Can we drop the paused_scheduled attribute and simply change this to:\n\nif data.get(\u0027paused\u0027):\n  result_data \u003d ...\n  self.sched.onBuildPaused(...)\n\nAnd set paused\u003dTrue in onBuildPaused?\n\nThe executor sends \"paused:true\" only once, when the build pauses.  It isn\u0027t going to send a second \"paused:true\" while still paused, so I don\u0027t think we need to perform the de-duplication that having pause_scheduled provides.  I think this approach would best approximate what I think is the goal: just letting the result processor handle this work.","commit_id":"f7432469bf74c6843547a320c2afd249614226f3"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"0f45584729b1e54d1c331eca5c7bed932504515c","unresolved":false,"context_lines":[{"line_number":501,"context_line":"                else:"},{"line_number":502,"context_line":"                    # Unsetting the pause flag outside of event processing is"},{"line_number":503,"context_line":"                    # safe."},{"line_number":504,"context_line":"                    build.paused \u003d False"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"            if not started:"},{"line_number":507,"context_line":"                self.log.info(\"Build %s started\" % job)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_342abce6","line":504,"in_reply_to":"df33271e_b6cb9e48","updated":"2020-04-06 16:57:54.000000000","message":"Done","commit_id":"f7432469bf74c6843547a320c2afd249614226f3"}]}
