)]}'
{"zuul/merger/merger.py":[{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"1cbce3e9985a579d346018a93e0811d43ed16435","unresolved":false,"context_lines":[{"line_number":727,"context_line":"                 speed_limit: str, speed_time: str,"},{"line_number":728,"context_line":"                 cache_root: Optional[str]\u003dNone, logger: Optional[Logger]\u003dNone,"},{"line_number":729,"context_line":"                 execution_context: bool\u003dFalse, git_timeout: int\u003d300):"},{"line_number":730,"context_line":"        # one optional logger and one with default?"},{"line_number":731,"context_line":"        self.explicit_logger: Optional[Logger] \u003d logger"},{"line_number":732,"context_line":"        self.log: Logger \u003d logger or logging.getLogger(\"zuul.Merger\")"},{"line_number":733,"context_line":"        self.repos: Dict[str, Repo] \u003d {}"}],"source_content_type":"text/x-python","patch_set":46,"id":"9f560f44_6d71c145","line":730,"updated":"2020-10-07 09:17:53.000000000","message":"maybe parent logger?","commit_id":"4cb639d4844e733d3fe08a2df36195fcf4c2e298"},{"author":{"_account_id":30637,"name":"Jan Kubovy","email":"jan.kubovy@bmw.de","username":"kubovy"},"change_message_id":"0ee4f4706539758321fe4bc0d8a7d5bd9ff12a9a","unresolved":false,"context_lines":[{"line_number":727,"context_line":"                 speed_limit: str, speed_time: str,"},{"line_number":728,"context_line":"                 cache_root: Optional[str]\u003dNone, logger: Optional[Logger]\u003dNone,"},{"line_number":729,"context_line":"                 execution_context: bool\u003dFalse, git_timeout: int\u003d300):"},{"line_number":730,"context_line":"        # one optional logger and one with default?"},{"line_number":731,"context_line":"        self.explicit_logger: Optional[Logger] \u003d logger"},{"line_number":732,"context_line":"        self.log: Logger \u003d logger or logging.getLogger(\"zuul.Merger\")"},{"line_number":733,"context_line":"        self.repos: Dict[str, Repo] \u003d {}"}],"source_content_type":"text/x-python","patch_set":46,"id":"9f560f44_bb494f8f","line":730,"in_reply_to":"9f560f44_6d71c145","updated":"2020-10-07 11:55:36.000000000","message":"I can rename it explicit_logger -\u003e parent_logger.\n\nMy comment above was more about if this is needed or if the one logger with the default would be enough?\n\nI guess this is for the case if in the upstream some annotations were set. In that case I guess it would be good to use only `logging.getLogger(\"zuul.Merger\")` and pass the annotations. The same in the `Repo`, etc. But that would be imho an unrelated change.","commit_id":"4cb639d4844e733d3fe08a2df36195fcf4c2e298"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"86d856aa095375551aa7a80c6a8c17a4d7c19c41","unresolved":false,"context_lines":[{"line_number":727,"context_line":"                 speed_limit: str, speed_time: str,"},{"line_number":728,"context_line":"                 cache_root: Optional[str]\u003dNone, logger: Optional[Logger]\u003dNone,"},{"line_number":729,"context_line":"                 execution_context: bool\u003dFalse, git_timeout: int\u003d300):"},{"line_number":730,"context_line":"        # one optional logger and one with default?"},{"line_number":731,"context_line":"        self.explicit_logger: Optional[Logger] \u003d logger"},{"line_number":732,"context_line":"        self.log: Logger \u003d logger or logging.getLogger(\"zuul.Merger\")"},{"line_number":733,"context_line":"        self.repos: Dict[str, Repo] \u003d {}"}],"source_content_type":"text/x-python","patch_set":46,"id":"9f560f44_b60206b9","line":730,"in_reply_to":"9f560f44_bb494f8f","updated":"2020-10-07 12:26:57.000000000","message":"Sorry, thought you were not sure about the name :)\nI think this used for the merger that is started with the executor, but I might be wrong.","commit_id":"4cb639d4844e733d3fe08a2df36195fcf4c2e298"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"e03b217547d34af6f4ed1b21db367fb462de1587","unresolved":false,"context_lines":[{"line_number":730,"context_line":"                 execution_context: bool \u003d False, git_timeout: int \u003d 300):"},{"line_number":731,"context_line":"        # one optional logger and one with default?"},{"line_number":732,"context_line":"        self.parent_logger: Optional[Logger] \u003d logger"},{"line_number":733,"context_line":"        self.log: Logger \u003d logger or logging.getLogger(\"zuul.Merger\")"},{"line_number":734,"context_line":"        self.repos: Dict[str, Repo] \u003d {}"},{"line_number":735,"context_line":"        self.working_root: str \u003d working_root"},{"line_number":736,"context_line":"        os.makedirs(working_root, exist_ok\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":53,"id":"3f65232a_b1aa87cf","line":733,"updated":"2020-10-21 14:16:29.000000000","message":"Not related to this change, but I\u0027m also wondering about why we need two different loggers here.","commit_id":"0e226f096df89f9597e0a11faaeae452149ce407"},{"author":{"_account_id":30637,"name":"Jan Kubovy","email":"jan.kubovy@bmw.de","username":"kubovy"},"change_message_id":"1f401fdc2d67f5365176c8de7199274cb10e1069","unresolved":false,"context_lines":[{"line_number":730,"context_line":"                 execution_context: bool \u003d False, git_timeout: int \u003d 300):"},{"line_number":731,"context_line":"        # one optional logger and one with default?"},{"line_number":732,"context_line":"        self.parent_logger: Optional[Logger] \u003d logger"},{"line_number":733,"context_line":"        self.log: Logger \u003d logger or logging.getLogger(\"zuul.Merger\")"},{"line_number":734,"context_line":"        self.repos: Dict[str, Repo] \u003d {}"},{"line_number":735,"context_line":"        self.working_root: str \u003d working_root"},{"line_number":736,"context_line":"        os.makedirs(working_root, exist_ok\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":53,"id":"3f65232a_b418871d","line":733,"in_reply_to":"3f65232a_b1aa87cf","updated":"2020-10-25 19:58:03.000000000","message":"The parent_logger is passed to \"Repo\" couple lines before. This is probably if one wants to use an explicitely annotated logger. The Repo also creates a default logger but it may be probably confusing if the logs from \"Repo\" would look like they are from \"Merger\". On the other hand it this is completely wrapped in an explicitly defined logger both will share it.","commit_id":"0e226f096df89f9597e0a11faaeae452149ce407"}],"zuul/zk.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"68e0d6ae5cb1bfa35d734fd2c861db768b7a556e","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import logging"},{"line_number":15,"context_line":"import time"},{"line_number":16,"context_line":"from typing import Dict"},{"line_number":17,"context_line":"from typing import Optional"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_d58026c2","line":15,"updated":"2020-08-05 11:49:51.000000000","message":"nit: The changes in this file look unrelated and might fit better into the zk preparation change?","commit_id":"d7a32470b377c176be9dfd415d620fd75a6303aa"},{"author":{"_account_id":30637,"name":"Jan Kubovy","email":"jan.kubovy@bmw.de","username":"kubovy"},"change_message_id":"25cc4898c5c36a6535be5649d79df413f4234553","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import logging"},{"line_number":15,"context_line":"import time"},{"line_number":16,"context_line":"from typing import Dict"},{"line_number":17,"context_line":"from typing import Optional"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_b8fc753e","line":15,"in_reply_to":"9f560f44_d58026c2","updated":"2020-08-06 09:47:33.000000000","message":"Done","commit_id":"d7a32470b377c176be9dfd415d620fd75a6303aa"}]}