)]}'
{"releasenotes/notes/zookeeper-connections-e19eb2dfd2804087.yaml":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"7de18e7f0e634b4321ba351a80202cba3a8c629d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    As further integration with the scale-out scheduler is planned, the"},{"line_number":5,"context_line":"    :attr:`zookeeper` section ``zuul.conf`` is marked required and"},{"line_number":6,"context_line":"    future releases may error if it is missing.  Please add it to your"},{"line_number":7,"context_line":"    configuration now."}],"source_content_type":"text/x-yaml","patch_set":58,"id":"1f621f24_dec7c263","line":7,"updated":"2020-11-09 18:12:22.000000000","message":"It seems like this has already been mentioned and perhaps we should skip that release note.","commit_id":"ae1dbde85709db881b575dc1010dbb0b6f88f4cc"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"4165b6af12126f1c903044d8610d7b944340c58c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    As further integration with the scale-out scheduler is planned, the"},{"line_number":5,"context_line":"    :attr:`zookeeper` section ``zuul.conf`` is marked required and"},{"line_number":6,"context_line":"    future releases may error if it is missing.  Please add it to your"},{"line_number":7,"context_line":"    configuration now."}],"source_content_type":"text/x-yaml","patch_set":67,"id":"aeb75a79_f51fce12","line":7,"updated":"2021-02-12 22:26:29.000000000","message":"We already told people we would error in 4.0 in this release note:\n\nhttps://zuul-ci.org/docs/zuul/reference/releasenotes.html#relnotes-3-19-0\n\nSo it\u0027s *this* release that\u0027s going to error, not a future release.","commit_id":"69b7f29bf45c5da3b1358530f3e87a4ae53b0354"}],"tests/base.py":[{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"a53267f087fd3f173febbbd68226f6e92c22081b","unresolved":true,"context_lines":[{"line_number":4179,"context_line":"            self.zk_chroot_fixture.zookeeper_chroot)"},{"line_number":4180,"context_line":""},{"line_number":4181,"context_line":"        self.zk_client \u003d ZooKeeperClient()"},{"line_number":4182,"context_line":"        self.zk_client.connect(hosts\u003dself.zk_config)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        if not KEEP_TEMPDIRS:"},{"line_number":4185,"context_line":"            tmp_root \u003d self.useFixture(fixtures.TempDir("}],"source_content_type":"text/x-python","patch_set":69,"id":"ebe534db_2f953854","line":4182,"updated":"2021-02-15 10:25:41.000000000","message":"I\u0027ve created the ZooKeeper client directly in the test case and shared it with the different components (executor, merger). This is necessary to make later patches (which actually use the zk_client) work as otherwise the cleanup might be called before the components stop resulting in \"Missing Kazoo client\" exceptions. I think, we also decided to share the client in the tests last week.","commit_id":"2ec698fbbe2b9454acb2d1f2c4015729b34ee19b"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"a336f71bd2cab0512a0be1d41024d6ba1b2b7d48","unresolved":false,"context_lines":[{"line_number":4179,"context_line":"            self.zk_chroot_fixture.zookeeper_chroot)"},{"line_number":4180,"context_line":""},{"line_number":4181,"context_line":"        self.zk_client \u003d ZooKeeperClient()"},{"line_number":4182,"context_line":"        self.zk_client.connect(hosts\u003dself.zk_config)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        if not KEEP_TEMPDIRS:"},{"line_number":4185,"context_line":"            tmp_root \u003d self.useFixture(fixtures.TempDir("}],"source_content_type":"text/x-python","patch_set":69,"id":"360e4ab3_d8a20d23","line":4182,"updated":"2021-02-15 15:16:41.000000000","message":"Makes sense; let\u0027s keep this in mind when we refactor the connection class.  I think if we can find a way to have separate connections that would make more realistic tests.  There are only about 4 tests that use a separate merger, so efficiency isn\u0027t a big concern.","commit_id":"2ec698fbbe2b9454acb2d1f2c4015729b34ee19b"}]}
