)]}'
{"web/src/containers/build/BuildOutput.jsx":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5f932e8611937032fd3a0463333e4cd46f13415f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            \u003cpre key\u003d\"stdout\" className\u003d\"zuul-log-sev-3\" title\u003d\"stdout\"\u003e"},{"line_number":85,"context_line":"              {task.stdout_lines.slice(-max_lines).join(\u0027\\n\u0027)}"},{"line_number":86,"context_line":"              \u003c/pre\u003e"},{"line_number":87,"context_line":"              \u003c/Fragment\u003e"},{"line_number":88,"context_line":"          )}"},{"line_number":89,"context_line":"          {task.stderr_lines \u0026\u0026 task.stderr_lines.length \u003e 0 \u0026\u0026 ("},{"line_number":90,"context_line":"            \u003cFragment\u003e"}],"source_content_type":"text/jsx","patch_set":6,"id":"1f493fa4_e59ac511","line":87,"updated":"2020-04-29 15:55:28.000000000","message":"Setting the severity here makes all of the text a sort of rust color which has two problems: not all of the text is necessarily an error, and it reduces the contrast, making it harder to read.  I could see applying a line-by-line highlighter here, but I don\u0027t think we should apply a color to all of the text.","commit_id":"adec988ed940da864a04eb88215985d279dbd4da"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5f932e8611937032fd3a0463333e4cd46f13415f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            \u003cpre key\u003d\"stderr\" className\u003d\"zuul-log-sev-7\" title\u003d\"stderr\"\u003e"},{"line_number":99,"context_line":"              {task.stderr_lines.slice(-max_lines).join(\u0027\\n\u0027)}"},{"line_number":100,"context_line":"            \u003c/pre\u003e"},{"line_number":101,"context_line":"            \u003c/Fragment\u003e"},{"line_number":102,"context_line":"          )}"},{"line_number":103,"context_line":"        \u003c/Panel.Body\u003e"},{"line_number":104,"context_line":"      \u003c/Panel\u003e"}],"source_content_type":"text/jsx","patch_set":6,"id":"1f493fa4_459e1907","line":101,"updated":"2020-04-29 15:55:28.000000000","message":"Ditto.","commit_id":"adec988ed940da864a04eb88215985d279dbd4da"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"4711ca1065cb66fa3dedcdbe82c26d32f5f51fb2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          {task.stdout_lines \u0026\u0026 task.stdout_lines.length \u003e 0 \u0026\u0026 ("},{"line_number":76,"context_line":"            \u003cFragment\u003e"},{"line_number":77,"context_line":"              {task.stdout_lines.length \u003e max_lines \u0026\u0026 ("},{"line_number":78,"context_line":"                \u003cdetails className\u003d\"stdout\"\u003e\u003csummary className\u003d\"more\"\u003emore\u003c/summary\u003e"},{"line_number":79,"context_line":"                  \u003cpre key\u003d\"stdout\" title\u003d\"stdout\"\u003e"},{"line_number":80,"context_line":"                    {task.stdout_lines.slice(0, -max_lines).join(\u0027\\n\u0027)}"},{"line_number":81,"context_line":"                  \u003c/pre\u003e"}],"source_content_type":"text/jsx","patch_set":12,"id":"ff570b3c_81b3fc97","line":78,"range":{"start_line":78,"start_character":70,"end_line":78,"end_character":74},"updated":"2020-06-03 16:22:40.000000000","message":"is there a way to toggle `more` into `less` when expanded?","commit_id":"f7043649d37b609276cff7b8371e70b4398fb275"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"56b1c4cac638861e15e6bae6efbd37f1e0ffe5b1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          {task.stdout_lines \u0026\u0026 task.stdout_lines.length \u003e 0 \u0026\u0026 ("},{"line_number":76,"context_line":"            \u003cFragment\u003e"},{"line_number":77,"context_line":"              {task.stdout_lines.length \u003e max_lines \u0026\u0026 ("},{"line_number":78,"context_line":"                \u003cdetails className\u003d\"stdout\"\u003e\u003csummary className\u003d\"more\"\u003emore\u003c/summary\u003e"},{"line_number":79,"context_line":"                  \u003cpre key\u003d\"stdout\" title\u003d\"stdout\"\u003e"},{"line_number":80,"context_line":"                    {task.stdout_lines.slice(0, -max_lines).join(\u0027\\n\u0027)}"},{"line_number":81,"context_line":"                  \u003c/pre\u003e"}],"source_content_type":"text/jsx","patch_set":12,"id":"ff570b3c_8c7fb313","line":78,"range":{"start_line":78,"start_character":70,"end_line":78,"end_character":74},"in_reply_to":"ff570b3c_2c0ae71e","updated":"2020-06-03 16:47:53.000000000","message":"Well it is confusing that clicking `more` seems to display the whole task output, and clicking `more` again shrink it back to the last lines.\n\nSo it seems like the this is a CSS trick, why not using a state variable to set the max_lines? Then we could have better control, and perhaps a `more` / `less` buttons to adjust it.","commit_id":"f7043649d37b609276cff7b8371e70b4398fb275"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"1a7d9e67df0af50abcee006530095399ce721659","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          {task.stdout_lines \u0026\u0026 task.stdout_lines.length \u003e 0 \u0026\u0026 ("},{"line_number":76,"context_line":"            \u003cFragment\u003e"},{"line_number":77,"context_line":"              {task.stdout_lines.length \u003e max_lines \u0026\u0026 ("},{"line_number":78,"context_line":"                \u003cdetails className\u003d\"stdout\"\u003e\u003csummary className\u003d\"more\"\u003emore\u003c/summary\u003e"},{"line_number":79,"context_line":"                  \u003cpre key\u003d\"stdout\" title\u003d\"stdout\"\u003e"},{"line_number":80,"context_line":"                    {task.stdout_lines.slice(0, -max_lines).join(\u0027\\n\u0027)}"},{"line_number":81,"context_line":"                  \u003c/pre\u003e"}],"source_content_type":"text/jsx","patch_set":12,"id":"ff570b3c_21fbcd47","line":78,"range":{"start_line":78,"start_character":70,"end_line":78,"end_character":74},"in_reply_to":"ff570b3c_78b91aca","updated":"2020-06-08 14:07:04.000000000","message":"FWIW- if that\u0027s a problem I believe webpack is already transpiling stuff with some support for older browsers - but we already also don\u0027t support like like IE, so I think it\u0027s fine. :)","commit_id":"f7043649d37b609276cff7b8371e70b4398fb275"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"0cddcd4f14bedb3c9e9ae89e4451d6fce9a5f81e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          {task.stdout_lines \u0026\u0026 task.stdout_lines.length \u003e 0 \u0026\u0026 ("},{"line_number":76,"context_line":"            \u003cFragment\u003e"},{"line_number":77,"context_line":"              {task.stdout_lines.length \u003e max_lines \u0026\u0026 ("},{"line_number":78,"context_line":"                \u003cdetails className\u003d\"stdout\"\u003e\u003csummary className\u003d\"more\"\u003emore\u003c/summary\u003e"},{"line_number":79,"context_line":"                  \u003cpre key\u003d\"stdout\" title\u003d\"stdout\"\u003e"},{"line_number":80,"context_line":"                    {task.stdout_lines.slice(0, -max_lines).join(\u0027\\n\u0027)}"},{"line_number":81,"context_line":"                  \u003c/pre\u003e"}],"source_content_type":"text/jsx","patch_set":12,"id":"ff570b3c_2c0ae71e","line":78,"range":{"start_line":78,"start_character":70,"end_line":78,"end_character":74},"in_reply_to":"ff570b3c_81b3fc97","updated":"2020-06-03 16:28:44.000000000","message":"I think it may be possible but I am afraid that such advanced CSS would delay this from being shipped for... a very long time. \n\nMy concerns are around browser support. See https://stackoverflow.com/a/56926015/99834","commit_id":"f7043649d37b609276cff7b8371e70b4398fb275"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"4ffec6119800b39976f091beead5d2e3af62f5b6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          {task.stdout_lines \u0026\u0026 task.stdout_lines.length \u003e 0 \u0026\u0026 ("},{"line_number":76,"context_line":"            \u003cFragment\u003e"},{"line_number":77,"context_line":"              {task.stdout_lines.length \u003e max_lines \u0026\u0026 ("},{"line_number":78,"context_line":"                \u003cdetails className\u003d\"stdout\"\u003e\u003csummary className\u003d\"more\"\u003emore\u003c/summary\u003e"},{"line_number":79,"context_line":"                  \u003cpre key\u003d\"stdout\" title\u003d\"stdout\"\u003e"},{"line_number":80,"context_line":"                    {task.stdout_lines.slice(0, -max_lines).join(\u0027\\n\u0027)}"},{"line_number":81,"context_line":"                  \u003c/pre\u003e"}],"source_content_type":"text/jsx","patch_set":12,"id":"ff570b3c_78b91aca","line":78,"range":{"start_line":78,"start_character":70,"end_line":78,"end_character":74},"in_reply_to":"ff570b3c_8c7fb313","updated":"2020-06-05 08:05:36.000000000","message":"Huh... Doing it. Now I am clearly more sympathetic to what the web devs. I hope it will not break someone\u0027s custom build niche browser.","commit_id":"f7043649d37b609276cff7b8371e70b4398fb275"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"1a7d9e67df0af50abcee006530095399ce721659","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    {task.stdout_lines.slice(0, -max_lines).join(\u0027\\n\u0027)}"},{"line_number":81,"context_line":"                  \u003c/pre\u003e"},{"line_number":82,"context_line":"                \u003c/details\u003e)}"},{"line_number":83,"context_line":"            \u003cpre key\u003d\"stdout\" title\u003d\"stdout\"\u003e"},{"line_number":84,"context_line":"              {task.stdout_lines.slice(-max_lines).join(\u0027\\n\u0027)}"},{"line_number":85,"context_line":"              \u003c/pre\u003e"},{"line_number":86,"context_line":"              \u003c/Fragment\u003e"}],"source_content_type":"text/jsx","patch_set":14,"id":"ff570b3c_81d3b9d5","line":83,"updated":"2020-06-08 14:07:04.000000000","message":"If you respin this for some other reason, this indentation is bong. #notaminusone","commit_id":"fe030227871110f802698946a89502a725a091a5"}],"web/src/index.css":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5f932e8611937032fd3a0463333e4cd46f13415f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"long console/log lines. */"},{"line_number":13,"context_line":"pre {"},{"line_number":14,"context_line":"    white-space: pre-wrap;"},{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".time {"},{"line_number":18,"context_line":"  white-space: nowrap;"}],"source_content_type":"text/css","patch_set":6,"id":"1f493fa4_25a14d47","line":15,"updated":"2020-04-29 15:55:28.000000000","message":"This may be an improvement in some circumstances, but I\u0027m not sure it\u0027s universally better.  Some log files with long lines are much easier to read if the lines are not wrapped.  Here is an example: https://zuul.opendev.org/t/zuul/build/8fd0081a6384416e86b489d639728a76/console\n\nI think this should be considered in its own change.","commit_id":"adec988ed940da864a04eb88215985d279dbd4da"},{"author":{"_account_id":30637,"name":"Jan Kubovy","email":"jan.kubovy@bmw.de","username":"kubovy"},"change_message_id":"d1b67cd3f0d86b479e24c64cb37e67c25991e2b8","unresolved":false,"context_lines":[{"line_number":273,"context_line":"  background: rgb(255, 255, 204);"},{"line_number":274,"context_line":"}"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"/* User to make the more expand/collapse look like a normal link */"},{"line_number":277,"context_line":"details.stderr {"},{"line_number":278,"context_line":"    color: #9b0000;"},{"line_number":279,"context_line":"}"}],"source_content_type":"text/css","patch_set":7,"id":"1f493fa4_0a8087f4","line":276,"range":{"start_line":276,"start_character":1,"end_line":276,"end_character":8},"updated":"2020-04-30 12:53:36.000000000","message":"nit: comment for `summary.more` not `details.stderr`","commit_id":"19a62dc076446951dc6fa2b70026cc53f852555f"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"4fecb116fa76b262a12669eabc282cf7cde47119","unresolved":false,"context_lines":[{"line_number":273,"context_line":"  background: rgb(255, 255, 204);"},{"line_number":274,"context_line":"}"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"/* User to make the more expand/collapse look like a normal link */"},{"line_number":277,"context_line":"details.stderr {"},{"line_number":278,"context_line":"    color: #9b0000;"},{"line_number":279,"context_line":"}"}],"source_content_type":"text/css","patch_set":7,"id":"1f493fa4_b6473a77","line":276,"range":{"start_line":276,"start_character":1,"end_line":276,"end_character":8},"in_reply_to":"1f493fa4_0a8087f4","updated":"2020-04-30 14:52:58.000000000","message":"Not really. Details is the big container that had the pre and summary inside it.\n\nWe want to apply the color to the entire container, so it will color both abridged and unabridged versions.","commit_id":"19a62dc076446951dc6fa2b70026cc53f852555f"}]}