)]}'
{"Dockerfile":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"05a850f88b33f91a89eb633365d11e06be305084","unresolved":false,"context_lines":[{"line_number":63,"context_line":"COPY --from\u003dbuilder /tmp/openshift-install/oc /usr/local/bin/oc"},{"line_number":64,"context_line":"COPY --from\u003dbuilder /etc/apt/trusted.gpg.d/kubic.gpg /etc/apt/trusted.gpg.d/kubic.gpg"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# https://podman.io/getting-started/installation.html"},{"line_number":67,"context_line":"RUN echo \u0027deb https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_10/ /\u0027 \u003e /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list \\"},{"line_number":68,"context_line":"  \u0026\u0026 apt-get update \\"},{"line_number":69,"context_line":"  \u0026\u0026 apt-get install -y \\"},{"line_number":70,"context_line":"      skopeo \\"},{"line_number":71,"context_line":"  \u0026\u0026 apt-get clean \\"},{"line_number":72,"context_line":"  \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"CMD [\"/usr/local/bin/zuul-executor\", \"-f\"]"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"1f493fa4_3b27a5cc","line":72,"range":{"start_line":66,"start_character":0,"end_line":72,"end_character":32},"updated":"2020-04-29 20:54:19.000000000","message":"Couldn\u0027t it be installed like the other golang tool using `copy --from\u003dbuilder`?","commit_id":"220b92310976cf7cd54784f1216abef535b128bc"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d8200f605484a78401771519b746cb1c05be8b4d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"COPY --from\u003dbuilder /tmp/openshift-install/oc /usr/local/bin/oc"},{"line_number":64,"context_line":"COPY --from\u003dbuilder /etc/apt/trusted.gpg.d/kubic.gpg /etc/apt/trusted.gpg.d/kubic.gpg"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# https://podman.io/getting-started/installation.html"},{"line_number":67,"context_line":"RUN echo \u0027deb https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_10/ /\u0027 \u003e /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list \\"},{"line_number":68,"context_line":"  \u0026\u0026 apt-get update \\"},{"line_number":69,"context_line":"  \u0026\u0026 apt-get install -y \\"},{"line_number":70,"context_line":"      skopeo \\"},{"line_number":71,"context_line":"  \u0026\u0026 apt-get clean \\"},{"line_number":72,"context_line":"  \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"CMD [\"/usr/local/bin/zuul-executor\", \"-f\"]"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"1f493fa4_aa84f3d3","line":72,"range":{"start_line":66,"start_character":0,"end_line":72,"end_character":32},"in_reply_to":"1f493fa4_3b27a5cc","updated":"2020-04-30 13:03:46.000000000","message":"Oh - that\u0027s an interesting point. Since we install it from packages I didn\u0027t think of that - but you\u0027re TOTALLY right.","commit_id":"220b92310976cf7cd54784f1216abef535b128bc"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ea6cb04a669cce5abd56dc7ff84bdcbff3bdb2c1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"COPY tools/2472D6D0.gpg /tmp/2472D6D0.gpg"},{"line_number":44,"context_line":"RUN apt-get update \\"},{"line_number":45,"context_line":"  \u0026\u0026 apt-get install -y gnupg \\"},{"line_number":46,"context_line":"  \u0026\u0026 cat /tmp/2472D6D0.gpg | apt-key --keyring /etc/apt/trusted.gpg.d/kubic.gpg add - \\"},{"line_number":47,"context_line":"  \u0026\u0026 echo \u0027deb https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_10/ /\u0027 \u003e /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list \\"},{"line_number":48,"context_line":"  \u0026\u0026 apt-get update \\"},{"line_number":49,"context_line":"  \u0026\u0026 apt-get install -y \\"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"1f493fa4_10def1d8","line":46,"range":{"start_line":46,"start_character":37,"end_line":46,"end_character":79},"updated":"2020-04-30 16:50:38.000000000","message":"The manpage for apt-key indicates that --keyring is optional and the default keyring should work fine. Can we drop this so we aren\u0027t stuck to a specific release (which will change over time)?","commit_id":"fbfc75dc6d62b790ab306760d147cf98006bc8c8"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ea6cb04a669cce5abd56dc7ff84bdcbff3bdb2c1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"RUN apt-get update \\"},{"line_number":45,"context_line":"  \u0026\u0026 apt-get install -y gnupg \\"},{"line_number":46,"context_line":"  \u0026\u0026 cat /tmp/2472D6D0.gpg | apt-key --keyring /etc/apt/trusted.gpg.d/kubic.gpg add - \\"},{"line_number":47,"context_line":"  \u0026\u0026 echo \u0027deb https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_10/ /\u0027 \u003e /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list \\"},{"line_number":48,"context_line":"  \u0026\u0026 apt-get update \\"},{"line_number":49,"context_line":"  \u0026\u0026 apt-get install -y \\"},{"line_number":50,"context_line":"      skopeo"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"1f493fa4_b0e8dd7b","line":47,"range":{"start_line":47,"start_character":65,"end_line":47,"end_character":70},"updated":"2020-04-30 16:50:38.000000000","message":"Apparently its version specific here too so my concern above is not critical.","commit_id":"fbfc75dc6d62b790ab306760d147cf98006bc8c8"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3b1d7e640a272074b094f8915f578a5dd543d097","unresolved":false,"context_lines":[{"line_number":44,"context_line":"COPY tools/2472D6D0.gpg /tmp/2472D6D0.gpg"},{"line_number":45,"context_line":"RUN apt-get update \\"},{"line_number":46,"context_line":"  \u0026\u0026 apt-get install -y gnupg \\"},{"line_number":47,"context_line":"  \u0026\u0026 cat /tmp/2472D6D0.gpg | apt-key --keyring /etc/apt/trusted.gpg.d/kubic.gpg add -"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"FROM docker.io/opendevorg/python-base as zuul"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":6,"id":"1f493fa4_79b759f6","line":47,"updated":"2020-04-30 23:23:52.000000000","message":"I just went through this with https://review.opendev.org/#/c/724462/\n\nbecause it\u0027s not a keyring but an ascii armoured key you want to name it \".asc\"\n\nThen you can just drop it in /etc/apt/trusted.gpg.d and you don\u0027t need gnupg installed or to run apt-key.  it suggests this in the man page :) [1]\n\n[1] http://manpages.ubuntu.com/manpages/bionic/man8/apt-key.8.html","commit_id":"ba00f18f58e34c3da0c55cef4b401bd5a0bd18f7"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"db98b8f13cafb70e4fba609d4ca72844f2d6026e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"COPY --from\u003dbuilder /etc/apt/trusted.gpg.d/kubic.gpg /etc/apt/trusted.gpg.d/kubic.gpg"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# https://podman.io/getting-started/installation.html"},{"line_number":67,"context_line":"RUN echo \u0027deb https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_10/ /\u0027 \u003e /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list \\"},{"line_number":68,"context_line":"  \u0026\u0026 apt-get update \\"},{"line_number":69,"context_line":"  \u0026\u0026 apt-get install -y \\"},{"line_number":70,"context_line":"      skopeo \\"}],"source_content_type":"text/x-dockerfile","patch_set":6,"id":"1f493fa4_d33db3bb","line":67,"range":{"start_line":67,"start_character":85,"end_line":67,"end_character":103},"updated":"2020-04-30 17:01:25.000000000","message":"Out of curiosity, how is this going to work when the base image become Debian_11 ?","commit_id":"ba00f18f58e34c3da0c55cef4b401bd5a0bd18f7"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c81e73bf0f3b7b4a49c4ebe1dd4274728c60e068","unresolved":false,"context_lines":[{"line_number":64,"context_line":"COPY --from\u003dbuilder /etc/apt/trusted.gpg.d/kubic.gpg /etc/apt/trusted.gpg.d/kubic.gpg"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# https://podman.io/getting-started/installation.html"},{"line_number":67,"context_line":"RUN echo \u0027deb https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_10/ /\u0027 \u003e /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list \\"},{"line_number":68,"context_line":"  \u0026\u0026 apt-get update \\"},{"line_number":69,"context_line":"  \u0026\u0026 apt-get install -y \\"},{"line_number":70,"context_line":"      skopeo \\"}],"source_content_type":"text/x-dockerfile","patch_set":6,"id":"1f493fa4_d3701375","line":67,"range":{"start_line":67,"start_character":85,"end_line":67,"end_character":103},"in_reply_to":"1f493fa4_d33db3bb","updated":"2020-04-30 17:09:42.000000000","message":"It\u0027s a good question. It might Just Work - frequently external repos like this will still work across base distro boundaries - like we\u0027ll install things from a bionic repo on a debian-10 image. BUT - it\u0027s possible the soname of libgpgme might be significant in which case the install command will stop working and we\u0027ll have to fix it.\n\nThis almost makes me want to try building the go binaries ourselves in a go builder image to see if we can get ACTUALLY statically linked binaries. :)","commit_id":"ba00f18f58e34c3da0c55cef4b401bd5a0bd18f7"}]}