)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"3b42ea298afeeb1eabbf194ffc2bcef522e993aa","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Now, the error is catched and a warning is printed instead. This comes"},{"line_number":16,"context_line":"with the drawback that cpu_time measuring does not work anymore (it will"},{"line_number":17,"context_line":"always print 0s)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Another possible solution for this would be to read the cpu_times of"},{"line_number":20,"context_line":"/proc/self before and after the execution of the ansible subprocess."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_2192adf7","line":17,"updated":"2020-05-09 17:41:28.000000000","message":"Since it\u0027s just logging I think that\u0027s a compromise we can do.","commit_id":"bd176ddb245c34b94399fdcdab591c7a1b18ffbf"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"3b42ea298afeeb1eabbf194ffc2bcef522e993aa","unresolved":false,"context_lines":[{"line_number":17,"context_line":"always print 0s)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Another possible solution for this would be to read the cpu_times of"},{"line_number":20,"context_line":"/proc/self before and after the execution of the ansible subprocess."},{"line_number":21,"context_line":"This is the behaviour that is present in GNU time for example. For the"},{"line_number":22,"context_line":"described edge-case with an old kernel, this is considered overkill."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_c18491b4","line":20,"updated":"2020-05-09 17:41:28.000000000","message":"This won\u0027t work since we\u0027re running many ansible sub processes in parallel.","commit_id":"bd176ddb245c34b94399fdcdab591c7a1b18ffbf"},{"author":{"_account_id":31944,"name":"Justus","email":"veecue@ventos.tk","username":"veecue"},"change_message_id":"8ae1338c18a5b75d8e9893974ec88237089aae36","unresolved":false,"context_lines":[{"line_number":17,"context_line":"always print 0s)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Another possible solution for this would be to read the cpu_times of"},{"line_number":20,"context_line":"/proc/self before and after the execution of the ansible subprocess."},{"line_number":21,"context_line":"This is the behaviour that is present in GNU time for example. For the"},{"line_number":22,"context_line":"described edge-case with an old kernel, this is considered overkill."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_81bc596a","line":20,"in_reply_to":"ff570b3c_c18491b4","updated":"2020-05-09 17:51:40.000000000","message":"But from different python threads aka subprocesses? However, you\u0027re way deeper into this than I am :D","commit_id":"bd176ddb245c34b94399fdcdab591c7a1b18ffbf"}],"zuul/executor/server.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"34ef9477b2e4de5163a755b1acf6891f354eaa2e","unresolved":false,"context_lines":[{"line_number":2235,"context_line":"            try:"},{"line_number":2236,"context_line":"                cpu_times \u003d self.proc.cpu_times()"},{"line_number":2237,"context_line":"                self.log.debug(\"Ansible cpu times: user\u003d%.2f, system\u003d%.2f, \""},{"line_number":2238,"context_line":"                            \"children_user\u003d%.2f, \""},{"line_number":2239,"context_line":"                            \"children_system\u003d%.2f\" %"},{"line_number":2240,"context_line":"                            (cpu_times.user, cpu_times.system,"},{"line_number":2241,"context_line":"                                cpu_times.children_user,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_81ee1986","line":2238,"updated":"2020-05-09 17:33:29.000000000","message":"linters: E128 continuation line under-indented for visual indent","commit_id":"bd176ddb245c34b94399fdcdab591c7a1b18ffbf"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"34ef9477b2e4de5163a755b1acf6891f354eaa2e","unresolved":false,"context_lines":[{"line_number":2236,"context_line":"                cpu_times \u003d self.proc.cpu_times()"},{"line_number":2237,"context_line":"                self.log.debug(\"Ansible cpu times: user\u003d%.2f, system\u003d%.2f, \""},{"line_number":2238,"context_line":"                            \"children_user\u003d%.2f, \""},{"line_number":2239,"context_line":"                            \"children_system\u003d%.2f\" %"},{"line_number":2240,"context_line":"                            (cpu_times.user, cpu_times.system,"},{"line_number":2241,"context_line":"                                cpu_times.children_user,"},{"line_number":2242,"context_line":"                                cpu_times.children_system))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e102753e","line":2239,"updated":"2020-05-09 17:33:29.000000000","message":"linters: E128 continuation line under-indented for visual indent","commit_id":"bd176ddb245c34b94399fdcdab591c7a1b18ffbf"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"34ef9477b2e4de5163a755b1acf6891f354eaa2e","unresolved":false,"context_lines":[{"line_number":2237,"context_line":"                self.log.debug(\"Ansible cpu times: user\u003d%.2f, system\u003d%.2f, \""},{"line_number":2238,"context_line":"                            \"children_user\u003d%.2f, \""},{"line_number":2239,"context_line":"                            \"children_system\u003d%.2f\" %"},{"line_number":2240,"context_line":"                            (cpu_times.user, cpu_times.system,"},{"line_number":2241,"context_line":"                                cpu_times.children_user,"},{"line_number":2242,"context_line":"                                cpu_times.children_system))"},{"line_number":2243,"context_line":"                self.cpu_times[\u0027user\u0027] +\u003d cpu_times.user"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_c1ff7132","line":2240,"updated":"2020-05-09 17:33:29.000000000","message":"linters: E128 continuation line under-indented for visual indent","commit_id":"bd176ddb245c34b94399fdcdab591c7a1b18ffbf"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"34ef9477b2e4de5163a755b1acf6891f354eaa2e","unresolved":false,"context_lines":[{"line_number":2245,"context_line":"                self.cpu_times[\u0027children_user\u0027] +\u003d cpu_times.children_user"},{"line_number":2246,"context_line":"                self.cpu_times[\u0027children_system\u0027] +\u003d cpu_times.children_system"},{"line_number":2247,"context_line":"            except psutil.NoSuchProcess:"},{"line_number":2248,"context_line":"                self.log.warn(\"Cannot get cpu_times for proc %d. Is your /proc mounted with hidepid\u003d2\""},{"line_number":2249,"context_line":"                              \" on an old linux kernel?\", self.proc.pid)"},{"line_number":2250,"context_line":"            ret \u003d self.proc.wait()"},{"line_number":2251,"context_line":"            self.log.debug(\"Ansible exit code: %s\" % (ret,))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_21fd8d3a","line":2248,"updated":"2020-05-09 17:33:29.000000000","message":"linters: E501 line too long (102 \u003e 79 characters)","commit_id":"bd176ddb245c34b94399fdcdab591c7a1b18ffbf"}]}