)]}'
{"releasenotes/notes/builds_held_attribute-711abd33402ce036.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2651d82262dcf3980fbdbeb01491fb71212303bd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    If using a SQL reporter, the zuul_builds table will be updated with a new"},{"line_number":9,"context_line":"    \u0027held\u0027 column."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_86fee268","line":9,"updated":"2020-09-02 21:51:20.000000000","message":"One think that isn\u0027t super clear to me reading the code in this change is if the zuul-web and zuul-scheduler services need to be restarted together in order to have the build.held attribute in all expected locations. It seems that we don\u0027t handle the build.held isn\u0027t there case in zuul-web which can possibly happen if zuul-scheduler isn\u0027t updated when zuul-web is updated?\n\nIf that is the case we should update these upgrade notes to clarify you need to update both together or perhaps update zuul-web to handle either scenario?","commit_id":"d27011f98e886e4f6d153c815520ee6b8e74aa37"}],"tests/unit/test_connection.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"8292b17fcc5e369ac8a5ba688d6ce1ce528a7ca0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        build_table \u003d table_prefix + \u0027zuul_build\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.assertEqual(16, len(insp.get_columns(buildset_table)))"},{"line_number":78,"context_line":"        self.assertEqual(12, len(insp.get_columns(build_table)))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_sql_tables_created(self):"},{"line_number":81,"context_line":"        \"Test the tables for storing results are created properly\""}],"source_content_type":"text/x-python","patch_set":14,"id":"bf51134e_bbe8bae1","line":78,"range":{"start_line":78,"start_character":25,"end_line":78,"end_character":27},"updated":"2020-06-29 15:18:33.000000000","message":"Probably needs to be 13 now.","commit_id":"0910e3db7f9930ce2847ee5f7b3b332a592fd91a"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"cb2a1a36af89f82e41956e26a41648a675ff36fd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        build_table \u003d table_prefix + \u0027zuul_build\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.assertEqual(16, len(insp.get_columns(buildset_table)))"},{"line_number":78,"context_line":"        self.assertEqual(12, len(insp.get_columns(build_table)))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_sql_tables_created(self):"},{"line_number":81,"context_line":"        \"Test the tables for storing results are created properly\""}],"source_content_type":"text/x-python","patch_set":14,"id":"bf51134e_5ecd0cb5","line":78,"range":{"start_line":78,"start_character":25,"end_line":78,"end_character":27},"in_reply_to":"bf51134e_bbe8bae1","updated":"2020-06-29 16:04:59.000000000","message":"Done","commit_id":"0910e3db7f9930ce2847ee5f7b3b332a592fd91a"}],"tests/unit/test_scheduler.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b725581d8500204385cabb70e8eeac4967503694","unresolved":false,"context_lines":[{"line_number":1829,"context_line":"        self.assertEqual(1, len(request2.nodes[0][\"nodes\"]))"},{"line_number":1830,"context_line":""},{"line_number":1831,"context_line":"        # The build should also have the \"held\" flag set to True"},{"line_number":1832,"context_line":"        build_id \u003d request2.nodes[0][\u0027build\u0027]"},{"line_number":1833,"context_line":"        # TODO get the build info from the build id, check the held attribute"},{"line_number":1834,"context_line":""},{"line_number":1835,"context_line":"        # Another failed change should not hold any more nodes"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_7259718c","line":1832,"updated":"2020-05-18 19:54:36.000000000","message":"linters: F841 local variable \u0027build_id\u0027 is assigned to but never used","commit_id":"cd85a4a612079797f36337e4416964646f882390"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"87e1ad72e733f1f9b97ce979c99b20cea6105a28","unresolved":false,"context_lines":[{"line_number":1830,"context_line":""},{"line_number":1831,"context_line":"        # The build should also have the \"held\" flag set to True"},{"line_number":1832,"context_line":"        build_id \u003d request2.nodes[0][\u0027build\u0027]"},{"line_number":1833,"context_line":"        # TODO get the build info from the build id, check the held attribute"},{"line_number":1834,"context_line":""},{"line_number":1835,"context_line":"        # Another failed change should not hold any more nodes"},{"line_number":1836,"context_line":"        C \u003d self.fake_gerrit.addFakeChange(\u0027org/project\u0027, \u0027master\u0027, \u0027C\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_97f6b7d6","line":1833,"range":{"start_line":1833,"start_character":8,"end_line":1833,"end_character":77},"updated":"2020-05-18 18:53:57.000000000","message":"some guidance/advice on how to do this would be appreciated!","commit_id":"cd85a4a612079797f36337e4416964646f882390"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dadeaa3877538fb2d1f065b1b16fe108be1e7f57","unresolved":false,"context_lines":[{"line_number":1829,"context_line":"        self.assertEqual(1, len(request2.nodes[0][\"nodes\"]))"},{"line_number":1830,"context_line":""},{"line_number":1831,"context_line":"        # The build should also have the \"held\" flag set to True"},{"line_number":1832,"context_line":"        build_id \u003d request2.nodes[0][\u0027build\u0027]"},{"line_number":1833,"context_line":"        # TODO get the build info from the build id, check the held attribute"},{"line_number":1834,"context_line":""},{"line_number":1835,"context_line":"        # Another failed change should not hold any more nodes"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_d174b1d1","line":1832,"updated":"2020-05-19 10:21:10.000000000","message":"linters: F841 local variable \u0027build_id\u0027 is assigned to but never used","commit_id":"a6bcf3af548fec2cdf6c0814d486d08697828dc9"}],"zuul/driver/sql/alembic/versions/32e28a297c3e_add_held_attribute_to_builds.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"8292b17fcc5e369ac8a5ba688d6ce1ce528a7ca0","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# revision identifiers, used by Alembic."},{"line_number":22,"context_line":"revision \u003d \u002732e28a297c3e\u0027"},{"line_number":23,"context_line":"down_revision \u003d \u002716c1dc9054d0\u0027"},{"line_number":24,"context_line":"branch_labels \u003d None"},{"line_number":25,"context_line":"depends_on \u003d None"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"bf51134e_1bd7264d","line":23,"updated":"2020-06-29 15:18:33.000000000","message":"This conflicts with https://review.opendev.org/633501\n\nI think the down_revision needs to be 269691d2220e now.","commit_id":"0910e3db7f9930ce2847ee5f7b3b332a592fd91a"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"cb2a1a36af89f82e41956e26a41648a675ff36fd","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# revision identifiers, used by Alembic."},{"line_number":22,"context_line":"revision \u003d \u002732e28a297c3e\u0027"},{"line_number":23,"context_line":"down_revision \u003d \u002716c1dc9054d0\u0027"},{"line_number":24,"context_line":"branch_labels \u003d None"},{"line_number":25,"context_line":"depends_on \u003d None"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"bf51134e_9ec20484","line":23,"in_reply_to":"bf51134e_1bd7264d","updated":"2020-06-29 16:04:59.000000000","message":"Done","commit_id":"0910e3db7f9930ce2847ee5f7b3b332a592fd91a"}]}