)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"68614c536a15701e3188a053f9a89fce2643148d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the same parameters as the buildset."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Redux: turned the error notifications into a more generic"},{"line_number":15,"context_line":"notification system, that can now include success notifications."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I05b6b3deb912b121df8de207944d9ec26e7c92d1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"5da1aaea_9f79bb79","line":15,"updated":"2021-11-14 16:18:32.000000000","message":"Reviewer note: this refers to the popup network error notifications, not the config errors.  :)","commit_id":"ef98926ae7626b5726a9c694087d0c1f1eb02e16"}],"web/src/api.js":[{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"9fea00cd85ab66f05b8f1a449d084c4ee9503a4c","unresolved":true,"context_lines":[{"line_number":215,"context_line":"    {"},{"line_number":216,"context_line":"      pipeline: pipeline,"},{"line_number":217,"context_line":"      change: change,"},{"line_number":218,"context_line":"      trigger: null,"},{"line_number":219,"context_line":"    }"},{"line_number":220,"context_line":"  )"},{"line_number":221,"context_line":"  return res"}],"source_content_type":"text/javascript","patch_set":17,"id":"09be5a27_47f1c88e","line":218,"updated":"2021-07-30 13:49:32.000000000","message":"Do we have to provide the null parameter or can this also be handled by the backend?","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"acda3ff3b478993a0d74a1f448da11def7a98538","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    {"},{"line_number":216,"context_line":"      pipeline: pipeline,"},{"line_number":217,"context_line":"      change: change,"},{"line_number":218,"context_line":"      trigger: null,"},{"line_number":219,"context_line":"    }"},{"line_number":220,"context_line":"  )"},{"line_number":221,"context_line":"  return res"}],"source_content_type":"text/javascript","patch_set":17,"id":"4d437607_2e26817f","line":218,"in_reply_to":"09be5a27_47f1c88e","updated":"2021-08-06 15:41:09.000000000","message":"Done","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"9fea00cd85ab66f05b8f1a449d084c4ee9503a4c","unresolved":true,"context_lines":[{"line_number":232,"context_line":"      ref: ref,"},{"line_number":233,"context_line":"      oldrev: oldrev,"},{"line_number":234,"context_line":"      newrev: newrev,"},{"line_number":235,"context_line":"      trigger: null,"},{"line_number":236,"context_line":"    }"},{"line_number":237,"context_line":"  )"},{"line_number":238,"context_line":"  return res"}],"source_content_type":"text/javascript","patch_set":17,"id":"5d4cc97d_b30d19ff","line":235,"updated":"2021-07-30 13:49:32.000000000","message":"Same like above?","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"acda3ff3b478993a0d74a1f448da11def7a98538","unresolved":false,"context_lines":[{"line_number":232,"context_line":"      ref: ref,"},{"line_number":233,"context_line":"      oldrev: oldrev,"},{"line_number":234,"context_line":"      newrev: newrev,"},{"line_number":235,"context_line":"      trigger: null,"},{"line_number":236,"context_line":"    }"},{"line_number":237,"context_line":"  )"},{"line_number":238,"context_line":"  return res"}],"source_content_type":"text/javascript","patch_set":17,"id":"958e2e36_c7c0aab6","line":235,"in_reply_to":"5d4cc97d_b30d19ff","updated":"2021-08-06 15:41:09.000000000","message":"Done","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"}],"web/src/containers/build/Buildset.jsx":[{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"9fea00cd85ab66f05b8f1a449d084c4ee9503a4c","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  const [showEnqueueModal, setShowEnqueueModal] \u003d useState(false)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  function renderEnqueueButton () {"},{"line_number":49,"context_line":"    return ("},{"line_number":50,"context_line":"        \u003cButton"},{"line_number":51,"context_line":"          variant\u003d{ButtonVariant.primary}"},{"line_number":52,"context_line":"          onClick\u003d{(event) \u003d\u003e {"}],"source_content_type":"text/jsx","patch_set":17,"id":"5f5998cc_7ebb8c46","line":49,"updated":"2021-07-30 13:49:32.000000000","message":"I think we should make this button less prominent.\n\nI have two proposals in mind (depending on how prominent we want to make this action):\n\n1. We could add a third column to the buildset page (like the link column on the build page) just with a slightly different styling so that one could differentiate between a link and an action. This might work a little better in case we also add links to the build page as on the buildset page this action button might get a little lost.\n\n2. Keep it where it is, but change the styling to look less like a button and more like an action icon. (I\u0027m just writing down what comes to my mind here, but hopefully it\u0027s somewhat understandable). E.g. something like the REBASE/ABANDON/EDIT section when viewing a change in Gerrit (top right corner). This could also work if we put the actions between the title and the content  with the different actions next to each other in a single row.\n\n3. Like 2, but with a tooltip instead of the text next to the icon. Depending on the kind of \"actions\" we are planning to add in the future we could also add some colors to the icons (as long as it doesn\u0027t look like a rainbow in the end 😄)\n\nMaybe there is also a combination of 2 and 3 that allows us to show both, icon and text without providing too much visual noise.\n\nThe 3. solution might also work as an additional action column in the buildsets table and it would fit the \"button/action bar\" for the dequeue/promote actions in the change panel.\n\nI\u0027d prefer the 3. solution. For what I have in my mind this feels nice and clean and allows to add additional actions without breaking the style.","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"ce5a895a170d80c47ea027a18ea363faff4ec089","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  const [showEnqueueModal, setShowEnqueueModal] \u003d useState(false)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  function renderEnqueueButton () {"},{"line_number":49,"context_line":"    return ("},{"line_number":50,"context_line":"        \u003cButton"},{"line_number":51,"context_line":"          variant\u003d{ButtonVariant.primary}"},{"line_number":52,"context_line":"          onClick\u003d{(event) \u003d\u003e {"}],"source_content_type":"text/jsx","patch_set":17,"id":"de79a012_f42fb915","line":49,"in_reply_to":"0498cb39_98ca1ee5","updated":"2021-08-09 14:02:43.000000000","message":"I could also just add an \"admin\" PageSection on top of the summary if the user is an admin. What do you think?","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"acda3ff3b478993a0d74a1f448da11def7a98538","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  const [showEnqueueModal, setShowEnqueueModal] \u003d useState(false)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  function renderEnqueueButton () {"},{"line_number":49,"context_line":"    return ("},{"line_number":50,"context_line":"        \u003cButton"},{"line_number":51,"context_line":"          variant\u003d{ButtonVariant.primary}"},{"line_number":52,"context_line":"          onClick\u003d{(event) \u003d\u003e {"}],"source_content_type":"text/jsx","patch_set":17,"id":"abdae82d_f4cdd559","line":49,"in_reply_to":"5f5998cc_7ebb8c46","updated":"2021-08-06 15:41:09.000000000","message":"I removed the button, and moved the action icon to the right side of the buildset summary. This can become an \"action column\" in the future.","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"176987573f5c65d77c5fe3a3eb673d0d5ad185af","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  const [showEnqueueModal, setShowEnqueueModal] \u003d useState(false)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  function renderEnqueueButton () {"},{"line_number":49,"context_line":"    return ("},{"line_number":50,"context_line":"        \u003cButton"},{"line_number":51,"context_line":"          variant\u003d{ButtonVariant.primary}"},{"line_number":52,"context_line":"          onClick\u003d{(event) \u003d\u003e {"}],"source_content_type":"text/jsx","patch_set":17,"id":"bb4d5f49_ea6120cb","line":49,"in_reply_to":"abdae82d_f4cdd559","updated":"2021-08-09 06:57:14.000000000","message":"Hmm, seeing this now in action I think I\u0027d prefer one of the other solutions. As long as we have only a single \"action link\" in the right column on the buildset result page this link looks lost. Are we planning to add more actions in the new future?","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"223878163ba396e6e6b2196811c92534d345e7bc","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  const [showEnqueueModal, setShowEnqueueModal] \u003d useState(false)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  function renderEnqueueButton () {"},{"line_number":49,"context_line":"    return ("},{"line_number":50,"context_line":"        \u003cButton"},{"line_number":51,"context_line":"          variant\u003d{ButtonVariant.primary}"},{"line_number":52,"context_line":"          onClick\u003d{(event) \u003d\u003e {"}],"source_content_type":"text/jsx","patch_set":17,"id":"d4c05910_398025b2","line":49,"in_reply_to":"bb4d5f49_ea6120cb","updated":"2021-08-09 07:05:08.000000000","message":"Another idea: It could also work if we move this action to the second column (below the buildset message) for now. The same could be done for the equivalent action on the build that could be placed below the links in the third column). If we add more actions later on, we could still create a new column.","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"980fd521baf495eface98d50f01242be1cc7bbbc","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  const [showEnqueueModal, setShowEnqueueModal] \u003d useState(false)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  function renderEnqueueButton () {"},{"line_number":49,"context_line":"    return ("},{"line_number":50,"context_line":"        \u003cButton"},{"line_number":51,"context_line":"          variant\u003d{ButtonVariant.primary}"},{"line_number":52,"context_line":"          onClick\u003d{(event) \u003d\u003e {"}],"source_content_type":"text/jsx","patch_set":17,"id":"0498cb39_98ca1ee5","line":49,"in_reply_to":"d4c05910_398025b2","updated":"2021-08-09 07:09:31.000000000","message":"Hopefully the final update: We should place the icon in front of the action (like for the other links/actions we have so far).","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"9fea00cd85ab66f05b8f1a449d084c4ee9503a4c","unresolved":true,"context_lines":[{"line_number":65,"context_line":"          const oldrev \u003d \u00270000000000000000000000000000000000000000\u0027"},{"line_number":66,"context_line":"          enqueue_ref(tenant.apiPrefix, buildset.project, buildset.pipeline, buildset.ref, oldrev, changeId, user.token)"},{"line_number":67,"context_line":"            .then(() \u003d\u003e {"},{"line_number":68,"context_line":"              alert(\u0027Change queued successfully.\u0027)"},{"line_number":69,"context_line":"            })"},{"line_number":70,"context_line":"            .catch(error \u003d\u003e {"},{"line_number":71,"context_line":"              alert(\u0027An error occured: \u0027 + error)"}],"source_content_type":"text/jsx","patch_set":17,"id":"8de490cd_a6376e82","line":68,"updated":"2021-07-30 13:49:32.000000000","message":"Would it make sense to provide a custom modal/popup instead that looks similar to the confirmation modal? Using an alert here breaks the flow a little.\n\nMaybe it would be even better to provide the success message in form of a toast (I think that is what most modern websites do by now). Green if success, read if failure.","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"8e85f048de365d1d8ebed5010974baeb380ff702","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          const oldrev \u003d \u00270000000000000000000000000000000000000000\u0027"},{"line_number":66,"context_line":"          enqueue_ref(tenant.apiPrefix, buildset.project, buildset.pipeline, buildset.ref, oldrev, changeId, user.token)"},{"line_number":67,"context_line":"            .then(() \u003d\u003e {"},{"line_number":68,"context_line":"              alert(\u0027Change queued successfully.\u0027)"},{"line_number":69,"context_line":"            })"},{"line_number":70,"context_line":"            .catch(error \u003d\u003e {"},{"line_number":71,"context_line":"              alert(\u0027An error occured: \u0027 + error)"}],"source_content_type":"text/jsx","patch_set":17,"id":"723c7116_438c63f2","line":68,"in_reply_to":"449fef5c_d0986a2b","updated":"2021-08-09 11:49:07.000000000","message":"I like the toast. Does it also close by itself? So far I always had to close the toast manually. I think it would be sufficient if it\u0027s shown for ~5 seconds and then closes automatically.","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"ce5a895a170d80c47ea027a18ea363faff4ec089","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          const oldrev \u003d \u00270000000000000000000000000000000000000000\u0027"},{"line_number":66,"context_line":"          enqueue_ref(tenant.apiPrefix, buildset.project, buildset.pipeline, buildset.ref, oldrev, changeId, user.token)"},{"line_number":67,"context_line":"            .then(() \u003d\u003e {"},{"line_number":68,"context_line":"              alert(\u0027Change queued successfully.\u0027)"},{"line_number":69,"context_line":"            })"},{"line_number":70,"context_line":"            .catch(error \u003d\u003e {"},{"line_number":71,"context_line":"              alert(\u0027An error occured: \u0027 + error)"}],"source_content_type":"text/jsx","patch_set":17,"id":"d8e68d58_ca03b215","line":68,"in_reply_to":"723c7116_438c63f2","updated":"2021-08-09 14:02:43.000000000","message":"It should close automatically, it used the TimedToastNotification[*] component from patternfly-react, see App.jsx\n\n[*] This is not documented in patternfly v4 but is in v3; the default delay is 8 seconds but can be modified with the timedelay property.","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"acda3ff3b478993a0d74a1f448da11def7a98538","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          const oldrev \u003d \u00270000000000000000000000000000000000000000\u0027"},{"line_number":66,"context_line":"          enqueue_ref(tenant.apiPrefix, buildset.project, buildset.pipeline, buildset.ref, oldrev, changeId, user.token)"},{"line_number":67,"context_line":"            .then(() \u003d\u003e {"},{"line_number":68,"context_line":"              alert(\u0027Change queued successfully.\u0027)"},{"line_number":69,"context_line":"            })"},{"line_number":70,"context_line":"            .catch(error \u003d\u003e {"},{"line_number":71,"context_line":"              alert(\u0027An error occured: \u0027 + error)"}],"source_content_type":"text/jsx","patch_set":17,"id":"449fef5c_d0986a2b","line":68,"in_reply_to":"8de490cd_a6376e82","updated":"2021-08-06 15:41:09.000000000","message":"I turned this into a notification toast.","commit_id":"1b1d113d2ef8ff537cbb3d9aa1de05143e704f43"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"223878163ba396e6e6b2196811c92534d345e7bc","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  CubeIcon,"},{"line_number":33,"context_line":"  FingerprintIcon,"},{"line_number":34,"context_line":"  StreamIcon,"},{"line_number":35,"context_line":"  UndoAltIcon,"},{"line_number":36,"context_line":"  // BullhornIcon"},{"line_number":37,"context_line":"} from \u0027@patternfly/react-icons\u0027"},{"line_number":38,"context_line":""}],"source_content_type":"text/jsx","patch_set":18,"id":"a22679c2_719141ce","line":35,"updated":"2021-08-09 07:05:08.000000000","message":"I think we should use a redo icon here instead (https://fontawesome.com/v5.15/icons/redo?style\u003dsolid)","commit_id":"a8ec4e0199eff8b4d6122d140bcb5a0f7d1f9329"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"ce5a895a170d80c47ea027a18ea363faff4ec089","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  CubeIcon,"},{"line_number":33,"context_line":"  FingerprintIcon,"},{"line_number":34,"context_line":"  StreamIcon,"},{"line_number":35,"context_line":"  UndoAltIcon,"},{"line_number":36,"context_line":"  // BullhornIcon"},{"line_number":37,"context_line":"} from \u0027@patternfly/react-icons\u0027"},{"line_number":38,"context_line":""}],"source_content_type":"text/jsx","patch_set":18,"id":"07368491_6d442129","line":35,"in_reply_to":"a22679c2_719141ce","updated":"2021-08-09 14:02:43.000000000","message":"Done","commit_id":"a8ec4e0199eff8b4d6122d140bcb5a0f7d1f9329"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"68614c536a15701e3188a053f9a89fce2643148d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  OutlinedCalendarAltIcon,"},{"line_number":37,"context_line":"  OutlinedClockIcon,"},{"line_number":38,"context_line":"  RedoAltIcon,"},{"line_number":39,"context_line":"  // BullhornIcon"},{"line_number":40,"context_line":"} from \u0027@patternfly/react-icons\u0027"},{"line_number":41,"context_line":"import * as moment from \u0027moment\u0027"},{"line_number":42,"context_line":"import \u0027moment-duration-format\u0027"}],"source_content_type":"text/jsx","patch_set":37,"id":"b553d696_69fa50c8","line":39,"updated":"2021-11-14 16:18:32.000000000","message":"leftover","commit_id":"ef98926ae7626b5726a9c694087d0c1f1eb02e16"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"a537bf3cd6f36f59d96b8d34844b7f1579fa5b79","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  OutlinedCalendarAltIcon,"},{"line_number":37,"context_line":"  OutlinedClockIcon,"},{"line_number":38,"context_line":"  RedoAltIcon,"},{"line_number":39,"context_line":"  // BullhornIcon"},{"line_number":40,"context_line":"} from \u0027@patternfly/react-icons\u0027"},{"line_number":41,"context_line":"import * as moment from \u0027moment\u0027"},{"line_number":42,"context_line":"import \u0027moment-duration-format\u0027"}],"source_content_type":"text/jsx","patch_set":37,"id":"288a2d89_85e16bf3","line":39,"in_reply_to":"b553d696_69fa50c8","updated":"2021-11-17 14:20:59.000000000","message":"Done","commit_id":"ef98926ae7626b5726a9c694087d0c1f1eb02e16"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"68614c536a15701e3188a053f9a89fce2643148d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"          \u003cFlex flex\u003d{{ default: \u0027flex_1\u0027 }}\u003e"},{"line_number":309,"context_line":"            \u003cFlexItem\u003e"},{"line_number":310,"context_line":"              \u003cList style\u003d{{ listStyle: \u0027none\u0027 }}\u003e"},{"line_number":311,"context_line":"                {renderEnqueueButton()}"},{"line_number":312,"context_line":"              \u003c/List\u003e"},{"line_number":313,"context_line":"            \u003c/FlexItem\u003e"},{"line_number":314,"context_line":"          \u003c/Flex\u003e}"}],"source_content_type":"text/jsx","patch_set":37,"id":"57448a94_1c75cafe","line":311,"updated":"2021-11-14 16:18:32.000000000","message":"I don\u0027t think we should have 4 columns; that starts to look very crowded on a non-ultrawide monitor.  Why don\u0027t we put it below the message above?","commit_id":"ef98926ae7626b5726a9c694087d0c1f1eb02e16"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e8088f30154d86f302327062d5ec9855dc729996","unresolved":false,"context_lines":[{"line_number":308,"context_line":"          \u003cFlex flex\u003d{{ default: \u0027flex_1\u0027 }}\u003e"},{"line_number":309,"context_line":"            \u003cFlexItem\u003e"},{"line_number":310,"context_line":"              \u003cList style\u003d{{ listStyle: \u0027none\u0027 }}\u003e"},{"line_number":311,"context_line":"                {renderEnqueueButton()}"},{"line_number":312,"context_line":"              \u003c/List\u003e"},{"line_number":313,"context_line":"            \u003c/FlexItem\u003e"},{"line_number":314,"context_line":"          \u003c/Flex\u003e}"}],"source_content_type":"text/jsx","patch_set":37,"id":"52d2d8ea_5c9ccf91","line":311,"updated":"2021-11-18 00:42:16.000000000","message":"I\u0027m on board with actions being distinct from properties, but I think location isn\u0027t the only way to do that.  The most important thing is that they are easy to find and identify as actions, and that they don\u0027t get lost in the properties.  The styling we have around the button helps a lot with that.  We may be able to improve it some more, and perhaps we think about putting the actions underneath the props.  Anyway, I think this is quite good for now; the benefits outweigh the drawbacks.  Thanks.  :)","commit_id":"ef98926ae7626b5726a9c694087d0c1f1eb02e16"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"a537bf3cd6f36f59d96b8d34844b7f1579fa5b79","unresolved":false,"context_lines":[{"line_number":308,"context_line":"          \u003cFlex flex\u003d{{ default: \u0027flex_1\u0027 }}\u003e"},{"line_number":309,"context_line":"            \u003cFlexItem\u003e"},{"line_number":310,"context_line":"              \u003cList style\u003d{{ listStyle: \u0027none\u0027 }}\u003e"},{"line_number":311,"context_line":"                {renderEnqueueButton()}"},{"line_number":312,"context_line":"              \u003c/List\u003e"},{"line_number":313,"context_line":"            \u003c/FlexItem\u003e"},{"line_number":314,"context_line":"          \u003c/Flex\u003e}"}],"source_content_type":"text/jsx","patch_set":37,"id":"fc122a9b_49c84ac1","line":311,"in_reply_to":"57448a94_1c75cafe","updated":"2021-11-17 14:20:59.000000000","message":"UX-wise actions should be distinct from properties; I was also afraid the action would be hard to notice under the message.\nI\u0027m not satisfied either with this layout anyway, so let\u0027s squeeze this back to 3 columns and if a UX wizard wants to revisit this later, by all means!","commit_id":"ef98926ae7626b5726a9c694087d0c1f1eb02e16"}]}