)]}'
{"zuul/executor/server.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"772ef5a9210ebbdd1d8008e726cb2fe20ecf6557","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"                    playbook, ansible_timeout, self.ansible_version,"},{"line_number":1398,"context_line":"                    phase\u003d\u0027run\u0027, index\u003dindex)"},{"line_number":1399,"context_line":"                if job_status \u003d\u003d self.RESULT_ABORTED:"},{"line_number":1400,"context_line":"                    return \u0027ABORTED\u0027"},{"line_number":1401,"context_line":"                elif job_status \u003d\u003d self.RESULT_TIMED_OUT:"},{"line_number":1402,"context_line":"                    # Set the pre-failure flag so this doesn\u0027t get"},{"line_number":1403,"context_line":"                    # overridden by a post-failure."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_899c7e5e","line":1400,"updated":"2020-06-30 17:34:00.000000000","message":"We also return early here (see comment below).","commit_id":"5480fbfb4cc012283a1472727bc760d37db85892"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"772ef5a9210ebbdd1d8008e726cb2fe20ecf6557","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"        if pause:"},{"line_number":1424,"context_line":"            self.pause()"},{"line_number":1425,"context_line":"        if self.aborted:"},{"line_number":1426,"context_line":"            return \u0027ABORTED\u0027"},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"        post_timeout \u003d args[\u0027post_timeout\u0027]"},{"line_number":1429,"context_line":"        for index, playbook in enumerate(self.jobdir.post_playbooks):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e9a09a94","line":1426,"updated":"2020-06-30 17:34:00.000000000","message":"Yes it could, but I think we should leave this as-is.  If a job is aborted, it was done so at Zuul\u0027s request, so we want to end it as quickly as possible.  In other words, that is a case where we do not want to run the post playbooks.","commit_id":"5480fbfb4cc012283a1472727bc760d37db85892"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"d7dcbff01c630d1d3d19fdcbb9c8c1bfc4534558","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"                    indeterminate \u003d True"},{"line_number":1418,"context_line":"                    break"},{"line_number":1419,"context_line":""},{"line_number":1420,"context_line":"        # check if we need to pause here"},{"line_number":1421,"context_line":"        result_data \u003d self.getResultData()"},{"line_number":1422,"context_line":"        pause \u003d result_data.get(\u0027zuul\u0027, {}).get(\u0027pause\u0027)"},{"line_number":1423,"context_line":"        if pause:"},{"line_number":1424,"context_line":"            self.pause()"},{"line_number":1425,"context_line":"        if self.aborted:"},{"line_number":1426,"context_line":"            return \u0027ABORTED\u0027"},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"        post_timeout \u003d args[\u0027post_timeout\u0027]"},{"line_number":1429,"context_line":"        for index, playbook in enumerate(self.jobdir.post_playbooks):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2ee3b8a6","line":1426,"range":{"start_line":1420,"start_character":0,"end_line":1426,"end_character":28},"updated":"2020-06-30 16:47:47.000000000","message":"could this be evaluated after an indeterminate state? perhaps that should be wrapped in a `if not indeterminate` block","commit_id":"5480fbfb4cc012283a1472727bc760d37db85892"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"7b02ac84118d1da13ecf0bdee7eb164461051c13","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"        if pause:"},{"line_number":1424,"context_line":"            self.pause()"},{"line_number":1425,"context_line":"        if self.aborted:"},{"line_number":1426,"context_line":"            return \u0027ABORTED\u0027"},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":"        post_timeout \u003d args[\u0027post_timeout\u0027]"},{"line_number":1429,"context_line":"        for index, playbook in enumerate(self.jobdir.post_playbooks):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_297f32ac","line":1426,"in_reply_to":"bf51134e_e9a09a94","updated":"2020-06-30 17:59:25.000000000","message":"My comment was for the whole block, in particular the self.pause() call, which used to be avoided on indeterminate state because of the return.","commit_id":"5480fbfb4cc012283a1472727bc760d37db85892"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"772ef5a9210ebbdd1d8008e726cb2fe20ecf6557","unresolved":false,"context_lines":[{"line_number":1436,"context_line":"                playbook, post_timeout, self.ansible_version, success,"},{"line_number":1437,"context_line":"                phase\u003d\u0027post\u0027, index\u003dindex)"},{"line_number":1438,"context_line":"            if post_status \u003d\u003d self.RESULT_ABORTED:"},{"line_number":1439,"context_line":"                return \u0027ABORTED\u0027"},{"line_number":1440,"context_line":"            if post_status !\u003d self.RESULT_NORMAL:"},{"line_number":1441,"context_line":"                # In case we encounter unreachable nodes we need to return None"},{"line_number":1442,"context_line":"                # so the job can be retried. However in the case of post"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c99dd658","line":1439,"updated":"2020-06-30 17:34:00.000000000","message":"See here we stop running post as well.","commit_id":"5480fbfb4cc012283a1472727bc760d37db85892"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"290141d5ae4b80145c99c996357a9c6ec9ad7ff5","unresolved":false,"context_lines":[{"line_number":1437,"context_line":"                phase\u003d\u0027post\u0027, index\u003dindex)"},{"line_number":1438,"context_line":"            if post_status \u003d\u003d self.RESULT_ABORTED:"},{"line_number":1439,"context_line":"                return \u0027ABORTED\u0027"},{"line_number":1440,"context_line":"            if post_status !\u003d self.RESULT_NORMAL:"},{"line_number":1441,"context_line":"                # In case we encounter unreachable nodes we need to return None"},{"line_number":1442,"context_line":"                # so the job can be retried. However in the case of post"},{"line_number":1443,"context_line":"                # playbooks we should still try to run all playbooks to get a"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_000e5fe4","line":1440,"range":{"start_line":1440,"start_character":15,"end_line":1440,"end_character":49},"updated":"2020-07-02 14:30:38.000000000","message":"this actually prevent POST_FAILURE to be set, is there a reason to change that test?","commit_id":"5480fbfb4cc012283a1472727bc760d37db85892"}]}