)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5fa783088744a43df3fa55c50e34aed8a838b5ee","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and also gives line numbering for free, even being able to colorize"},{"line_number":11,"context_line":"output from some other commands."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Easy to test using build b4655eb004d143379d424fd968c2e196"},{"line_number":14,"context_line":"https://sbarnea.com/ss/Screen-Shot-2020-08-25-16-23-03.45.png"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If65641216e43865735cee6e8fb932c41c0cb5f21"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_792f563e","line":13,"updated":"2020-08-27 01:42:47.000000000","message":"If people start turning ANSI on then the raw logs end up looking like\n\nhttps://zuul.opendev.org/t/openstack/build/b4655eb004d143379d424fd968c2e196/log/job-output.txt#637\n\nsince the raw logs are the things sent through things like logstash for parsing, it doesn\u0027t seem like this is an improvement","commit_id":"199ab56e157af413974d135bfbe34b731113b654"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"9c8facc73b58a8ebc986de2f1809801a0cecfdde","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and also gives line numbering for free, even being able to colorize"},{"line_number":11,"context_line":"output from some other commands."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Easy to test using build b4655eb004d143379d424fd968c2e196"},{"line_number":14,"context_line":"https://sbarnea.com/ss/Screen-Shot-2020-08-25-16-23-03.45.png"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If65641216e43865735cee6e8fb932c41c0cb5f21"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_8083ceca","line":13,"in_reply_to":"9f560f44_792f563e","updated":"2020-08-27 07:27:02.000000000","message":"This change doe NOT change the log format in any way.\n\nHow logs are processed is unrelated to this change and stripping ANSI out when uploading is one of the easiest logstash filters possible.\n\nmutate {\n  gsub \u003d\u003e [\"message\", \"\\x1B\\[([0-9]{1,2}(;[0-9]{1,2})?)?[m|K]\", \"\"]\n}\n\nAFAIK, At this moment Zuul is the *only* CI/CD system that does not correctly display ANSI correctly.\n\nIn fact it does display ANSI in live/streaming console, that being the only place where it already works but most users do not even known about it.\n\nI really hope we are not going down a path that does prefer to cripple the UX -\u003e so less people use the service -\u003e we avoid scalability issues.","commit_id":"199ab56e157af413974d135bfbe34b731113b654"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b460acd3ff8b8e0a917f94870141965d0a98680a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and also gives line numbering for free, even being able to colorize"},{"line_number":11,"context_line":"output from some other commands."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Easy to test using build b4655eb004d143379d424fd968c2e196"},{"line_number":14,"context_line":"https://sbarnea.com/ss/Screen-Shot-2020-08-25-16-23-03.45.png"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If65641216e43865735cee6e8fb932c41c0cb5f21"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_b18462b2","line":13,"in_reply_to":"9f560f44_8083ceca","updated":"2020-08-27 10:26:43.000000000","message":"I do understand this doesn\u0027t change the logs.  but it does encourage everyone to add \"--color\" or whatever to everything.\n\nfwiw i don\u0027t think github/travis ci gets this all that right either ... when I look at\n\nhttps://github.com/pyca/cryptography/pull/5404/checks?check_run_id\u003d1029159745\n\ngoing through the pull down boxes it sends my cpu fans spinning and takes well into double digit seconds to render ... to view a log extract.  The raw contents are basically useless because of interactive spinners i guess; e.g.\n\nhttps://pipelines.actions.githubusercontent.com/hvVe09l57RGA3Cm7JL4sgPbWx7zV70eaczPXXeApNFapxvX30z/_apis/pipelines/1/runs/989/signedlogcontent/4?urlExpires\u003d2020-08-27T10%3A07%3A06.0264012Z\u0026urlSigningMethod\u003dHMACV1\u0026urlSignature\u003d78LvvSsc6uUWnRm%2F87Sw1oJfofNA6pqsNPQ1N7QmZkw%3D\n\ni\u0027m not -1 but it\u0027s not a compelling experience all round","commit_id":"199ab56e157af413974d135bfbe34b731113b654"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eaa5280167fd9bb38bc471f4ed01dc6e7a012a39","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and also gives line numbering for free, even being able to colorize"},{"line_number":11,"context_line":"output from some other commands."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Easy to test using build b4655eb004d143379d424fd968c2e196"},{"line_number":14,"context_line":"https://sbarnea.com/ss/Screen-Shot-2020-08-25-16-23-03.45.png"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If65641216e43865735cee6e8fb932c41c0cb5f21"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_9125de5e","line":13,"in_reply_to":"9f560f44_8083ceca","updated":"2020-08-27 09:52:20.000000000","message":"I like the idea and it would be nice to have it, but the raw logs having ANSI codes does suck a bit.\n\nIs there a way to filter the ANSI from the raw logs before they get written to disk?\n\nAlternatively perhaps this should be an opt-in feature.","commit_id":"199ab56e157af413974d135bfbe34b731113b654"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"651e2d271942984fc41774330ca08076a0caf5dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and also gives line numbering for free, even being able to colorize"},{"line_number":11,"context_line":"output from some other commands."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Easy to test using build b4655eb004d143379d424fd968c2e196"},{"line_number":14,"context_line":"https://sbarnea.com/ss/Screen-Shot-2020-08-25-16-23-03.45.png"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If65641216e43865735cee6e8fb932c41c0cb5f21"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_f7bd2ab1","line":13,"in_reply_to":"9f560f44_9125de5e","updated":"2020-08-27 12:04:07.000000000","message":"In fact this option has nothing to do with the \"logs\" (aka zuul artifacts).\n\nThis is about displaying/rendering stdout/stdeerr output of ansible tasks, like shell/command.\n\nHow we display archived logs and if is good or not to drop ANSI from them, is another subject, outside this change (and likely something configurable).","commit_id":"199ab56e157af413974d135bfbe34b731113b654"}],"web/src/containers/build/BuildOutput.jsx":[{"author":{"_account_id":22720,"name":"Sviatoslav Sydorenko","display_name":"@webknjaz","email":"webknjaz@redhat.com","username":"webknjaz"},"change_message_id":"f72189c5a7f112e8876f6bec2a1c985bf76330d9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            \u003cFragment\u003e"},{"line_number":107,"context_line":"              {task.stdout_lines.length \u003e max_lines \u0026\u0026 ("},{"line_number":108,"context_line":"                \u003cdetails className\u003d{`${\u0027foldable\u0027} ${\u0027stdout\u0027}`}\u003e\u003csummary\u003e\u003c/summary\u003e"},{"line_number":109,"context_line":"                  \u003cpre key\u003d\u0027stdout\u0027 title\u003d\u0027stdout\u0027\u003e"},{"line_number":110,"context_line":"                    \u003cReactAnsi log\u003d{task.stdout_lines.slice(0, -max_lines).join(\u0027\\n\u0027)}/\u003e"},{"line_number":111,"context_line":"                  \u003c/pre\u003e"},{"line_number":112,"context_line":"                \u003c/details\u003e)}"}],"source_content_type":"text/jsx","patch_set":6,"id":"1f621f24_014be458","line":109,"updated":"2020-11-03 15:05:05.000000000","message":"Are the single quotes necessary? I used to think that HTML has a double-quote-for-attrs convention.","commit_id":"9f758f3869d810d3ba2dc3394b16d51d8cab3361"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"ca206c0cd3d357588432515e446721a41939d3f8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            \u003cFragment\u003e"},{"line_number":107,"context_line":"              {task.stdout_lines.length \u003e max_lines \u0026\u0026 ("},{"line_number":108,"context_line":"                \u003cdetails className\u003d{`${\u0027foldable\u0027} ${\u0027stdout\u0027}`}\u003e\u003csummary\u003e\u003c/summary\u003e"},{"line_number":109,"context_line":"                  \u003cpre key\u003d\u0027stdout\u0027 title\u003d\u0027stdout\u0027\u003e"},{"line_number":110,"context_line":"                    \u003cReactAnsi log\u003d{task.stdout_lines.slice(0, -max_lines).join(\u0027\\n\u0027)}/\u003e"},{"line_number":111,"context_line":"                  \u003c/pre\u003e"},{"line_number":112,"context_line":"                \u003c/details\u003e)}"}],"source_content_type":"text/jsx","patch_set":6,"id":"1f621f24_41b83cc7","line":109,"in_reply_to":"1f621f24_014be458","updated":"2020-11-03 15:18:53.000000000","message":"Nope. In fact ts is quite strict about what it expects and I see no reason for me change them. probably there from multiple rebases but i will drop them.","commit_id":"9f758f3869d810d3ba2dc3394b16d51d8cab3361"}]}