)]}'
{"web/src/actions/projects.js":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"89a84c1a50256dbd43188419053605fb6c94a4a9","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"export const fetchProjectsIfNeeded \u003d (tenant, force) \u003d\u003e ("},{"line_number":56,"context_line":"  dispatch, getState) \u003d\u003e {"},{"line_number":57,"context_line":"    if (force || shouldFetchProjects(tenant, getState())) {"},{"line_number":58,"context_line":"      return dispatch(fetchProjects(tenant))"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    return Promise.resolve()"}],"source_content_type":"text/javascript","patch_set":1,"id":"9f560f44_afadadeb","side":"PARENT","line":57,"range":{"start_line":57,"start_character":2,"end_line":57,"end_character":4},"updated":"2020-09-03 12:59:44.000000000","message":"why is the indentation removed here?","commit_id":"ddb31f735177c98f7d33faba0afb0707dba1d805"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"14da625a1d9c593eff7aad86f7fafdcfe2dc005c","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"export const fetchProjectsIfNeeded \u003d (tenant, force) \u003d\u003e ("},{"line_number":56,"context_line":"  dispatch, getState) \u003d\u003e {"},{"line_number":57,"context_line":"    if (force || shouldFetchProjects(tenant, getState())) {"},{"line_number":58,"context_line":"      return dispatch(fetchProjects(tenant))"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    return Promise.resolve()"}],"source_content_type":"text/javascript","patch_set":1,"id":"9f560f44_500bce22","side":"PARENT","line":57,"range":{"start_line":57,"start_character":2,"end_line":57,"end_character":4},"in_reply_to":"9f560f44_afadadeb","updated":"2020-09-03 14:45:51.000000000","message":"I have to confess it looks bit weird but is correct.\n\nMainly line 56 is not a statement, is continuation of the function 55, the first statement starts on line 57. I know that python does require extra indent when you do this, but apparently eslint doesn\u0027t. \n\nTake a look at https://review.opendev.org/#/c/747377/ -- and passed and is build on top of this and enforcing indentation using eslint.","commit_id":"ddb31f735177c98f7d33faba0afb0707dba1d805"}],"web/src/reducers/build.js":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"89a84c1a50256dbd43188419053605fb6c94a4a9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  buildsets: {},"},{"line_number":42,"context_line":"}, action) \u003d\u003e {"},{"line_number":43,"context_line":"  switch (action.type) {"},{"line_number":44,"context_line":"    case BUILD_FETCH_REQUEST:"},{"line_number":45,"context_line":"    case BUILDSET_FETCH_REQUEST:"},{"line_number":46,"context_line":"      return update(state, {$merge: {isFetching: true}})"},{"line_number":47,"context_line":"    case BUILD_FETCH_SUCCESS:"}],"source_content_type":"text/javascript","patch_set":1,"id":"9f560f44_efb7a539","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":4},"updated":"2020-09-03 12:59:44.000000000","message":"while it is added there?","commit_id":"8828174c5b1307fc8c9c5b7a95226cd6a5a6bc37"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"14da625a1d9c593eff7aad86f7fafdcfe2dc005c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  buildsets: {},"},{"line_number":42,"context_line":"}, action) \u003d\u003e {"},{"line_number":43,"context_line":"  switch (action.type) {"},{"line_number":44,"context_line":"    case BUILD_FETCH_REQUEST:"},{"line_number":45,"context_line":"    case BUILDSET_FETCH_REQUEST:"},{"line_number":46,"context_line":"      return update(state, {$merge: {isFetching: true}})"},{"line_number":47,"context_line":"    case BUILD_FETCH_SUCCESS:"}],"source_content_type":"text/javascript","patch_set":1,"id":"9f560f44_5072aeae","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":4},"in_reply_to":"9f560f44_efb7a539","updated":"2020-09-03 14:45:51.000000000","message":"Look at https://review.opendev.org/#/c/747377/7/web/.eslintrc\n\nThis was requested to me during a review on one of my patches and I have to agree that case statements inside look much better indented.\n\nIn fact it is logical: {} is still a block, even if is a case clock, so it needs to follow same rules as any block, 2 chars indent.","commit_id":"8828174c5b1307fc8c9c5b7a95226cd6a5a6bc37"}]}
