)]}'
{"tests/base.py":[{"author":{"_account_id":6889,"name":"Fabien Boucher","email":"fboucher@redhat.com","username":"fabien-boucher"},"change_message_id":"f97808ac07fff8dc7bef8d7268feadab6f08db66","unresolved":false,"context_lines":[{"line_number":1844,"context_line":"        }"},{"line_number":1845,"context_line":"        data[\u0027labels\u0027] \u003d [{\u0027title\u0027: label} for label in self.labels]"},{"line_number":1846,"context_line":"        data[\u0027changes\u0027] \u003d {"},{"line_number":1847,"context_line":"            \u0027updated_at\u0027: {"},{"line_number":1848,"context_line":"                \u0027previous\u0027: self.updated_at.strftime(\u0027%Y-%m-%d %H:%M:%S UTC\u0027),"},{"line_number":1849,"context_line":"                \u0027current\u0027: self.updated_at.strftime(\u0027%Y-%m-%d %H:%M:%S UTC\u0027)"},{"line_number":1850,"context_line":"            }"},{"line_number":1851,"context_line":"        }"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"        if include_labels:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6a849e5e","line":1850,"range":{"start_line":1847,"start_character":0,"end_line":1850,"end_character":13},"updated":"2020-09-11 14:52:53.000000000","message":"Do we really need this ? It seems we do not rely on that field in gitlabconnection.py","commit_id":"1b836aaaea9d2beae8bba910b877bd310edd177a"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"73ca7c1857d6ad9bff6df36dc7dfce7662b8f861","unresolved":false,"context_lines":[{"line_number":1844,"context_line":"        }"},{"line_number":1845,"context_line":"        data[\u0027labels\u0027] \u003d [{\u0027title\u0027: label} for label in self.labels]"},{"line_number":1846,"context_line":"        data[\u0027changes\u0027] \u003d {"},{"line_number":1847,"context_line":"            \u0027updated_at\u0027: {"},{"line_number":1848,"context_line":"                \u0027previous\u0027: self.updated_at.strftime(\u0027%Y-%m-%d %H:%M:%S UTC\u0027),"},{"line_number":1849,"context_line":"                \u0027current\u0027: self.updated_at.strftime(\u0027%Y-%m-%d %H:%M:%S UTC\u0027)"},{"line_number":1850,"context_line":"            }"},{"line_number":1851,"context_line":"        }"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"        if include_labels:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_68878662","line":1850,"range":{"start_line":1847,"start_character":0,"end_line":1850,"end_character":13},"in_reply_to":"9f560f44_6a849e5e","updated":"2020-09-11 16:00:13.000000000","message":"Done","commit_id":"1b836aaaea9d2beae8bba910b877bd310edd177a"}],"tests/unit/test_gitlab_driver.py":[{"author":{"_account_id":6889,"name":"Fabien Boucher","email":"fboucher@redhat.com","username":"fabien-boucher"},"change_message_id":"f97808ac07fff8dc7bef8d7268feadab6f08db66","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        zuulvars \u003d job.parameters[\u0027zuul\u0027]"},{"line_number":163,"context_line":"        self.assertEqual(\u0027check-approval\u0027, zuulvars[\u0027pipeline\u0027])"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @simple_layout(\u0027layouts/basic-gitlab.yaml\u0027, driver\u003d\u0027gitlab\u0027)"},{"line_number":166,"context_line":"    def test_merge_request_event(self):"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        A \u003d self.fake_gitlab.openFakeMergeRequest(\u0027org/project\u0027, \u0027master\u0027, \u0027A\u0027)"},{"line_number":169,"context_line":"        connector \u003d GitlabEventConnector(self.fake_gitlab)"},{"line_number":170,"context_line":"        name, payload \u003d A.getMergeRequestUpdatedEvent()"},{"line_number":171,"context_line":"        self.assertEqual(\u0027update\u0027, payload[\u0027object_attributes\u0027][\u0027action\u0027])"},{"line_number":172,"context_line":"        event \u003d connector._event_merge_request(payload)"},{"line_number":173,"context_line":"        self.assertEqual(\u0027changed\u0027, event.action)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @simple_layout(\u0027layouts/basic-gitlab.yaml\u0027, driver\u003d\u0027gitlab\u0027)"},{"line_number":176,"context_line":"    def test_merge_request_labeled(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ca6e8a94","line":173,"range":{"start_line":165,"start_character":0,"end_line":173,"end_character":49},"updated":"2020-09-11 14:52:53.000000000","message":"I don\u0027t think we need this new test. test_merge_request_labeled and test_merge_request_updated already validate that feature.","commit_id":"1b836aaaea9d2beae8bba910b877bd310edd177a"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"73ca7c1857d6ad9bff6df36dc7dfce7662b8f861","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        zuulvars \u003d job.parameters[\u0027zuul\u0027]"},{"line_number":163,"context_line":"        self.assertEqual(\u0027check-approval\u0027, zuulvars[\u0027pipeline\u0027])"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @simple_layout(\u0027layouts/basic-gitlab.yaml\u0027, driver\u003d\u0027gitlab\u0027)"},{"line_number":166,"context_line":"    def test_merge_request_event(self):"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        A \u003d self.fake_gitlab.openFakeMergeRequest(\u0027org/project\u0027, \u0027master\u0027, \u0027A\u0027)"},{"line_number":169,"context_line":"        connector \u003d GitlabEventConnector(self.fake_gitlab)"},{"line_number":170,"context_line":"        name, payload \u003d A.getMergeRequestUpdatedEvent()"},{"line_number":171,"context_line":"        self.assertEqual(\u0027update\u0027, payload[\u0027object_attributes\u0027][\u0027action\u0027])"},{"line_number":172,"context_line":"        event \u003d connector._event_merge_request(payload)"},{"line_number":173,"context_line":"        self.assertEqual(\u0027changed\u0027, event.action)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @simple_layout(\u0027layouts/basic-gitlab.yaml\u0027, driver\u003d\u0027gitlab\u0027)"},{"line_number":176,"context_line":"    def test_merge_request_labeled(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e86436e7","line":173,"range":{"start_line":165,"start_character":0,"end_line":173,"end_character":49},"in_reply_to":"9f560f44_ca6e8a94","updated":"2020-09-11 16:00:13.000000000","message":"Indeed, test_merge_request_updated already validate that feature. test_merge_request_labeled doesn\u0027t (this test succeed when the changes to tests/base.py are kept and the changes to\nzuul/driver/gitlab/gitlabconnection.py are discarded).","commit_id":"1b836aaaea9d2beae8bba910b877bd310edd177a"},{"author":{"_account_id":6889,"name":"Fabien Boucher","email":"fboucher@redhat.com","username":"fabien-boucher"},"change_message_id":"ed8f6f132a39a2c043440d509b83d5800ce9477b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        zuulvars \u003d job.parameters[\u0027zuul\u0027]"},{"line_number":163,"context_line":"        self.assertEqual(\u0027check-approval\u0027, zuulvars[\u0027pipeline\u0027])"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @simple_layout(\u0027layouts/basic-gitlab.yaml\u0027, driver\u003d\u0027gitlab\u0027)"},{"line_number":166,"context_line":"    def test_merge_request_event(self):"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        A \u003d self.fake_gitlab.openFakeMergeRequest(\u0027org/project\u0027, \u0027master\u0027, \u0027A\u0027)"},{"line_number":169,"context_line":"        connector \u003d GitlabEventConnector(self.fake_gitlab)"},{"line_number":170,"context_line":"        name, payload \u003d A.getMergeRequestUpdatedEvent()"},{"line_number":171,"context_line":"        self.assertEqual(\u0027update\u0027, payload[\u0027object_attributes\u0027][\u0027action\u0027])"},{"line_number":172,"context_line":"        event \u003d connector._event_merge_request(payload)"},{"line_number":173,"context_line":"        self.assertEqual(\u0027changed\u0027, event.action)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @simple_layout(\u0027layouts/basic-gitlab.yaml\u0027, driver\u003d\u0027gitlab\u0027)"},{"line_number":176,"context_line":"    def test_merge_request_labeled(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_57b96c77","line":173,"range":{"start_line":165,"start_character":0,"end_line":173,"end_character":49},"in_reply_to":"9f560f44_e86436e7","updated":"2020-09-14 08:06:27.000000000","message":"When the \"mocked event\" is updated (in base.py) and w/o your change in gitlabconnection.py test_merge_request_updated fail with the exact same issue you reported. Applying the change in gitlabconnection.py makes it pass. For me that\u0027s good.","commit_id":"1b836aaaea9d2beae8bba910b877bd310edd177a"}]}