)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"d8a1498fc29e8d307df95874d9dbd027f3787707","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the traceback also contains the local variables of all frames part of"},{"line_number":12,"context_line":"the traceback. Those also can contain references to Tenant objects"},{"line_number":13,"context_line":"which will be blocked for the gc until the event is (hopefully)"},{"line_number":14,"context_line":"collected as well. Since we\u0027re only interested in the stack traces and"},{"line_number":15,"context_line":"don\u0027t need the local variables clear the frames before attaching the"},{"line_number":16,"context_line":"traceback to the event."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I57854ac4b9d1405d2b7b86f27149f87af968e77a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_511eb8ba","line":15,"range":{"start_line":14,"start_character":19,"end_line":15,"end_character":30},"updated":"2020-09-11 08:30:58.000000000","message":"Is that always the case? Couldn\u0027t it help debugging knowing which tenant is impacted for example?","commit_id":"2dc98bea8dc66ba9dfd0288d5faa3a2cc00916b7"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"4ee9ae25731f9074aff6a291bc43e78f43449cb6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the traceback also contains the local variables of all frames part of"},{"line_number":12,"context_line":"the traceback. Those also can contain references to Tenant objects"},{"line_number":13,"context_line":"which will be blocked for the gc until the event is (hopefully)"},{"line_number":14,"context_line":"collected as well. Since we\u0027re only interested in the stack traces and"},{"line_number":15,"context_line":"don\u0027t need the local variables clear the frames before attaching the"},{"line_number":16,"context_line":"traceback to the event."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I57854ac4b9d1405d2b7b86f27149f87af968e77a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_91c7b012","line":15,"range":{"start_line":14,"start_character":19,"end_line":15,"end_character":30},"in_reply_to":"9f560f44_511eb8ba","updated":"2020-09-11 08:39:22.000000000","message":"If we want to know that we\u0027ll have to add that to the exception (which is actually the usual way). We anyway should improve error reporting on the enqueue/dequeue api.\n\nNevertheless I\u0027ve never seen anywhere a case where somebody iterated over the stack trace frames to see some local variables (and we have nothing like that in our codebase).","commit_id":"2dc98bea8dc66ba9dfd0288d5faa3a2cc00916b7"}]}
