)]}'
{".zuul.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f1ce1f0588bb177d09806beabeecd9dc68e615e8","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    parent: opendev-release-python"},{"line_number":222,"context_line":"    pre-run: playbooks/release/pre.yaml"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"- job:"},{"line_number":225,"context_line":"    name: zuul-client-zuul-functional"},{"line_number":226,"context_line":"    parent: tox"},{"line_number":227,"context_line":"    description: |"},{"line_number":228,"context_line":"      Test that Zuul and zuul-client work together."},{"line_number":229,"context_line":"    required-projects:"},{"line_number":230,"context_line":"      - zuul/zuul"},{"line_number":231,"context_line":"      - zuul/zuul-client"},{"line_number":232,"context_line":"    vars:"},{"line_number":233,"context_line":"      zuul_work_dir: \"{{ zuul.projects[\u0027opendev.org/zuul/zuul\u0027].src_dir }}\""},{"line_number":234,"context_line":"      tox_envlist: zuul_client"},{"line_number":235,"context_line":"    nodeset: ubuntu-bionic"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"- project:"},{"line_number":238,"context_line":"    vars:"},{"line_number":239,"context_line":"      node_version: 14"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9f560f44_d00ea2e2","line":236,"range":{"start_line":224,"start_character":2,"end_line":236,"end_character":0},"updated":"2020-09-21 17:15:25.000000000","message":"Unknown projects: zuul/zuul-client","commit_id":"b794da3c181c76f89616b244ad92ae27b2caa6c0"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f61587321dea8710b651a43ada4d6a818030d588","unresolved":false,"context_lines":[{"line_number":234,"context_line":"              tox_install_bindep: false"},{"line_number":235,"context_line":"        - tox-py36:"},{"line_number":236,"context_line":"            required-projects:"},{"line_number":237,"context_line":"              - zuul/zuul-client"},{"line_number":238,"context_line":"            irrelevant-files:"},{"line_number":239,"context_line":"              - zuul/cmd/migrate.py"},{"line_number":240,"context_line":"              - playbooks/zuul-migrate/.*"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_4c743b05","line":237,"updated":"2020-09-28 19:56:15.000000000","message":"The tox -py3* jobs only run tests in tests/unit/ they do not run any of the new tests/zuul_client tests. This is controlled by the .stestr.conf.\n\nInstead of adding zuul-client to required projects here maybe we should have a new job like https://review.opendev.org/#/c/751264/16 and only run the zuul client tests there?","commit_id":"a1de50e0044eabd18f138a483c4041f6b35aa4f5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"0c448d02751449b8c66f238149e6c41adf0a1737","unresolved":false,"context_lines":[{"line_number":234,"context_line":"              tox_install_bindep: false"},{"line_number":235,"context_line":"        - tox-py36:"},{"line_number":236,"context_line":"            required-projects:"},{"line_number":237,"context_line":"              - zuul/zuul-client"},{"line_number":238,"context_line":"            irrelevant-files:"},{"line_number":239,"context_line":"              - zuul/cmd/migrate.py"},{"line_number":240,"context_line":"              - playbooks/zuul-migrate/.*"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_25fe35af","line":237,"in_reply_to":"9f560f44_4c743b05","updated":"2020-09-29 09:44:15.000000000","message":"right, this is a leftover from previous patchsets, I\u0027ll remove it.","commit_id":"a1de50e0044eabd18f138a483c4041f6b35aa4f5"}],"tests/unit/test_web.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e5d0aa178f9af82b16a8b2925062e5c89612ca6c","unresolved":false,"context_lines":[{"line_number":2103,"context_line":"        self.assertEqual([gerrit_connection, github_connection], data)"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":""},{"line_number":2106,"context_line":"class TestCLIViaWebApi(BaseTestWeb):"},{"line_number":2107,"context_line":"    config_file \u003d \u0027zuul-admin-web.conf\u0027"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"    def test_autohold(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_8bb38b0a","side":"PARENT","line":2106,"updated":"2020-09-17 19:08:39.000000000","message":"This change doesn\u0027t remove the Zuul CLI, so we shouldn\u0027t remove the tests yet.","commit_id":"d676b6d6d9ac3c903b0f8a8ed013b96cf8a65df7"}],"tests/zuul_client/__init__.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f61587321dea8710b651a43ada4d6a818030d588","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_4cb39bed","line":13,"updated":"2020-09-28 19:56:15.000000000","message":"Nit an empty file doesn\u0027t need a license header.","commit_id":"a1de50e0044eabd18f138a483c4041f6b35aa4f5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"0c448d02751449b8c66f238149e6c41adf0a1737","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_0514d1e8","line":13,"in_reply_to":"9f560f44_4cb39bed","updated":"2020-09-29 09:44:15.000000000","message":"Done","commit_id":"a1de50e0044eabd18f138a483c4041f6b35aa4f5"}],"tests/zuul_client/test_zuulclient.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f61587321dea8710b651a43ada4d6a818030d588","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        test_version \u003d subprocess.check_output("},{"line_number":32,"context_line":"            [\u0027zuul-client\u0027, \u0027--version\u0027],"},{"line_number":33,"context_line":"            stderr\u003dsubprocess.STDOUT)"},{"line_number":34,"context_line":"        self.assertTrue(b\u0027Zuul-client version:\u0027 in test_version)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_autohold(self):"},{"line_number":37,"context_line":"        \"\"\"Test that autohold can be set with the Web client\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_0c724313","line":34,"updated":"2020-09-28 19:56:15.000000000","message":"Nit might want to check exit codes here too.","commit_id":"a1de50e0044eabd18f138a483c4041f6b35aa4f5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"0c448d02751449b8c66f238149e6c41adf0a1737","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        test_version \u003d subprocess.check_output("},{"line_number":32,"context_line":"            [\u0027zuul-client\u0027, \u0027--version\u0027],"},{"line_number":33,"context_line":"            stderr\u003dsubprocess.STDOUT)"},{"line_number":34,"context_line":"        self.assertTrue(b\u0027Zuul-client version:\u0027 in test_version)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_autohold(self):"},{"line_number":37,"context_line":"        \"\"\"Test that autohold can be set with the Web client\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_c5de593b","line":34,"in_reply_to":"9f560f44_0c724313","updated":"2020-09-29 09:44:15.000000000","message":"If we get the client version, then the exit code should be 0. According to python\u0027s doc on check_output: \"If the return code was non-zero it raises a CalledProcessError\", so the test will fail anyway.","commit_id":"a1de50e0044eabd18f138a483c4041f6b35aa4f5"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f61587321dea8710b651a43ada4d6a818030d588","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            stdout\u003dsubprocess.PIPE)"},{"line_number":93,"context_line":"        output \u003d p.communicate()"},{"line_number":94,"context_line":"        self.assertEqual(p.returncode, 0, output)"},{"line_number":95,"context_line":"        self.waitUntilSettled()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_enqueue_ref(self):"},{"line_number":98,"context_line":"        \"\"\"Test that the Web client can enqueue a ref\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_acd237ce","line":95,"updated":"2020-09-28 19:56:15.000000000","message":"Might want to check the build history here to ensure org/project\u0027s jobs were run and/or that it merged.","commit_id":"a1de50e0044eabd18f138a483c4041f6b35aa4f5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"0c448d02751449b8c66f238149e6c41adf0a1737","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            stdout\u003dsubprocess.PIPE)"},{"line_number":93,"context_line":"        output \u003d p.communicate()"},{"line_number":94,"context_line":"        self.assertEqual(p.returncode, 0, output)"},{"line_number":95,"context_line":"        self.waitUntilSettled()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_enqueue_ref(self):"},{"line_number":98,"context_line":"        \"\"\"Test that the Web client can enqueue a ref\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_a5a6c5bf","line":95,"in_reply_to":"9f560f44_acd237ce","updated":"2020-09-29 09:44:15.000000000","message":"Done","commit_id":"a1de50e0044eabd18f138a483c4041f6b35aa4f5"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f61587321dea8710b651a43ada4d6a818030d588","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            stdout\u003dsubprocess.PIPE)"},{"line_number":124,"context_line":"        output \u003d p.communicate()"},{"line_number":125,"context_line":"        self.assertEqual(p.returncode, 0, output)"},{"line_number":126,"context_line":"        self.waitUntilSettled()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_dequeue(self):"},{"line_number":129,"context_line":"        \"\"\"Test that the Web client can dequeue a change\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_2cf0e766","line":126,"updated":"2020-09-28 19:56:15.000000000","message":"See above about checking the build history.","commit_id":"a1de50e0044eabd18f138a483c4041f6b35aa4f5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"0c448d02751449b8c66f238149e6c41adf0a1737","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            stdout\u003dsubprocess.PIPE)"},{"line_number":124,"context_line":"        output \u003d p.communicate()"},{"line_number":125,"context_line":"        self.assertEqual(p.returncode, 0, output)"},{"line_number":126,"context_line":"        self.waitUntilSettled()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_dequeue(self):"},{"line_number":129,"context_line":"        \"\"\"Test that the Web client can dequeue a change\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_85abc186","line":126,"in_reply_to":"9f560f44_2cf0e766","updated":"2020-09-29 09:44:15.000000000","message":"Done","commit_id":"a1de50e0044eabd18f138a483c4041f6b35aa4f5"}]}
