)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"cb953873f67206f1c6702367eb96a5e5efb847f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b2ec074c_2af3356e","updated":"2021-10-22 12:34:10.000000000","message":"\u003e * Maybe we can sort by hostname within each section?\n\u003e   That would probably be good to go ahead and do in this change if it\u0027s not too hard.\n\nGood idea, I will have a look at that. I was also thinking if we should sort the \"categories\" (type of component) in some \"logical\" order. Currently we are relying on the order that comes from the backend/API. E.g. we could do something like Scheduler|Executor|Merger|Web|Fingergw? That would be a hardcoded order, but I think we won\u0027t add new component types very often.\n \n\u003e * Use the refreshable widget so we get the refresh link in the top right?\n\nI will try that out. Honestly I find it always hard to correctly place the refresh icon and we are not consistently using it.\n\n\u003e \n\u003e * I wonder if we can come up with different icons for the components?  I mean, I realize that\u0027s not easy.\n\u003e   Something like a merging arrow for merger.  Maybe gear for executor?  Fingergw is an opportunity for some fun, but maybe we should keep that to ourselves and use a console icon.\n\u003e   This is probably a good followup change so we don\u0027t get hung up on it.\n\nThat\u0027s also a good idea. I like icons :) I will come up with something in a follow-up change.\n","commit_id":"2817e7ee46956c144c568a7bfa6b34d3f565383e"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"f062caf6d903c714b53cf471c4d3c5ce6075c40d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b871d33c_a0ba50ff","updated":"2021-10-22 12:55:11.000000000","message":"PS6/7 sorts each component list by hostname and drops the first \"Component\" column to avoid all the duplicated \"executor\", \"merger\", ... strings in the table.","commit_id":"29d4c32d74f8d51706112d860a3ac3cb508b59a4"}],"web/src/containers/component/ComponentTable.jsx":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"3f2c2d2a9e4a0ea54047877287461b0e1c6875cf","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    if (a.hostname \u003c b.hostname) {"},{"line_number":97,"context_line":"      return -1"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"    if (a.hostname \u003c b.hostname) {"},{"line_number":100,"context_line":"      return 1"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":"    return 0"}],"source_content_type":"text/jsx","patch_set":6,"id":"aa74c63c_862e02b2","line":99,"updated":"2021-10-25 21:55:13.000000000","message":"I think this logic reversal is why the sort isn\u0027t working.","commit_id":"9fc0f108b28baee5f88bd67c0d062c43050d8192"}]}
