)]}'
{"zuul/cmd/merger.py":[{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"851aecebc4a2dbcdc7f3702c985ed83c76109534","unresolved":true,"context_lines":[{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import zuul.cmd"},{"line_number":21,"context_line":"import zuul.merger.server"},{"line_number":22,"context_line":"from zuul.merger.server import COMMANDS, MergeServer"},{"line_number":23,"context_line":"from zuul.lib.config import get_default"},{"line_number":24,"context_line":"from zuul.zk import ZooKeeperClient"}],"source_content_type":"text/x-python","patch_set":4,"id":"c15e3999_b80d85e3","line":21,"updated":"2021-02-15 06:24:05.000000000","message":"nit: This import shouldn\u0027t be needed anymore.","commit_id":"ae81b649d9efe3da27bc242f529a6c2bc988008e"}],"zuul/merger/merger.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"772d4f6bd9d40610e032f3b8f15563196d979923","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import git"},{"line_number":28,"context_line":"import gitdb"},{"line_number":29,"context_line":"import paramiko"},{"line_number":30,"context_line":"from zuul.lib.connections import ConnectionRegistry"},{"line_number":31,"context_line":"from zuul.zk import ZooKeeperClient"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"import zuul.model"}],"source_content_type":"text/x-python","patch_set":2,"id":"81e8a112_03d92acd","line":30,"updated":"2021-02-13 16:11:12.000000000","message":"This import is responsible for most of the increased test time.  Because of the multi process worker used in the executor, this is imported anew for each process, and even a null test might do that about 5 times to read the configuration.  The import initializes all of the drivers.\n\n1) Let\u0027s omit this bit of type annotations for now.\n2) Let\u0027s take a look at minimizing the code needed for the spawned processes for the merger (possibly move those into static methods in a dedicated file).","commit_id":"db0bba85c7bf3d7708a54360ed1d027d62a67eb3"}],"zuul/merger/server.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"772d4f6bd9d40610e032f3b8f15563196d979923","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                 zk_client: ZooKeeperClient,"},{"line_number":62,"context_line":"                 connections: Optional[ConnectionRegistry] \u003d None):"},{"line_number":63,"context_line":"        # TODO(jeblair): Is this actually optional?"},{"line_number":64,"context_line":"        self.connections \u003d connections or ConnectionRegistry()"},{"line_number":65,"context_line":"        self.merge_email \u003d get_default(config, \u0027merger\u0027, \u0027git_user_email\u0027,"},{"line_number":66,"context_line":"                                       \u0027zuul.merger.default@example.com\u0027)"},{"line_number":67,"context_line":"        self.merge_name \u003d get_default(config, \u0027merger\u0027, \u0027git_user_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"eb2aa810_60271e5f","line":64,"updated":"2021-02-13 16:11:12.000000000","message":"This change to instantiate an unneeded ConnectionRegistry caused 0.5s of additional runtime for each test.  It initializes all of the drivers.","commit_id":"db0bba85c7bf3d7708a54360ed1d027d62a67eb3"}]}