)]}'
{"zuul/executor/server.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b6868e16959d9c15afd8297200d5d0882e751b04","unresolved":false,"context_lines":[{"line_number":1468,"context_line":"                success \u003d False"},{"line_number":1469,"context_line":"                # If we encountered a pre-failure, that takes"},{"line_number":1470,"context_line":"                # precedence over the post result."},{"line_number":1471,"context_line":"                if not pre_failed:"},{"line_number":1472,"context_line":"                    result \u003d \u0027POST_FAILURE\u0027"},{"line_number":1473,"context_line":"                if (index + 1) \u003d\u003d len(self.jobdir.post_playbooks):"},{"line_number":1474,"context_line":"                    self._logFinalPlaybookError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"45803db7_fad23d47","line":1471,"updated":"2021-04-06 21:13:43.000000000","message":"Sorry if I wasn\u0027t clear.  The issue is if something causes this code to run (for example, if suddenly the host becomes reachable again, and then this runs and expected logs aren\u0027t available so it fails.  Zuul would report POST_FAILURE in that case instead of None.","commit_id":"28035d9af47b8480bec354ef2b8535bdbaeda553"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"91ed37bdb0d5e5e8b22abea3e47bff62ff9c418a","unresolved":false,"context_lines":[{"line_number":1468,"context_line":"                success \u003d False"},{"line_number":1469,"context_line":"                # If we encountered a pre-failure, that takes"},{"line_number":1470,"context_line":"                # precedence over the post result."},{"line_number":1471,"context_line":"                if not pre_failed:"},{"line_number":1472,"context_line":"                    result \u003d \u0027POST_FAILURE\u0027"},{"line_number":1473,"context_line":"                if (index + 1) \u003d\u003d len(self.jobdir.post_playbooks):"},{"line_number":1474,"context_line":"                    self._logFinalPlaybookError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"c98899ab_d7cc8c26","line":1471,"updated":"2021-03-31 00:30:35.000000000","message":"We\u0027ll want to do something like this to avoid turning \"FAILURE\"s into \"POST_FAILURE\"s.","commit_id":"28035d9af47b8480bec354ef2b8535bdbaeda553"},{"author":{"_account_id":31760,"name":"Kenny Ho","email":"y2kenny@gmail.com","username":"y2kenny"},"change_message_id":"a107f139da6637a13a0225ed367b1d3aef35bb70","unresolved":false,"context_lines":[{"line_number":1468,"context_line":"                success \u003d False"},{"line_number":1469,"context_line":"                # If we encountered a pre-failure, that takes"},{"line_number":1470,"context_line":"                # precedence over the post result."},{"line_number":1471,"context_line":"                if not pre_failed:"},{"line_number":1472,"context_line":"                    result \u003d \u0027POST_FAILURE\u0027"},{"line_number":1473,"context_line":"                if (index + 1) \u003d\u003d len(self.jobdir.post_playbooks):"},{"line_number":1474,"context_line":"                    self._logFinalPlaybookError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"8b9f3ef8_b798233d","line":1471,"in_reply_to":"45803db7_fad23d47","updated":"2021-04-06 21:44:38.000000000","message":"Ah ok, I see what you mean now.  Thanks for clarifying.","commit_id":"28035d9af47b8480bec354ef2b8535bdbaeda553"},{"author":{"_account_id":31760,"name":"Kenny Ho","email":"y2kenny@gmail.com","username":"y2kenny"},"change_message_id":"9f125e9b2d19721fedbcc33fde4d1695b86e7b72","unresolved":false,"context_lines":[{"line_number":1468,"context_line":"                success \u003d False"},{"line_number":1469,"context_line":"                # If we encountered a pre-failure, that takes"},{"line_number":1470,"context_line":"                # precedence over the post result."},{"line_number":1471,"context_line":"                if not pre_failed:"},{"line_number":1472,"context_line":"                    result \u003d \u0027POST_FAILURE\u0027"},{"line_number":1473,"context_line":"                if (index + 1) \u003d\u003d len(self.jobdir.post_playbooks):"},{"line_number":1474,"context_line":"                    self._logFinalPlaybookError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"74d9be0f_5c30d6b5","line":1471,"in_reply_to":"c98899ab_d7cc8c26","updated":"2021-03-31 00:49:54.000000000","message":"result is not used for unreachable (it returns None) so that shouldn\u0027t be needed but I have set the pre_failed to True anyway.","commit_id":"28035d9af47b8480bec354ef2b8535bdbaeda553"}]}
