)]}'
{"zuul/driver/sql/alembic/versions/40c49b6fc2e3_build_nodeset.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"087d518c40e3286f9d6504ee7d80c3c7cc2c47ba","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade(table_prefix\u003d\u0027\u0027):"},{"line_number":32,"context_line":"    op.drop_column(table_prefix + \u0027zuul_build\u0027, \u0027node_name\u0027)"},{"line_number":33,"context_line":"    op.add_column("},{"line_number":34,"context_line":"        table_prefix + \u0027zuul_build\u0027, sa.Column(\u0027nodeset\u0027, sa.String(255)))"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1356c7a2_a4485d78","line":32,"updated":"2021-07-08 22:31:15.000000000","message":"Does this mean we are going to lose the node name info that has already been recorded? Do we need a transition period if so?","commit_id":"1076b205263b01b3144fae1fed625854fd727755"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d85b06b1d7bdba791643f0257a4f22483eb5dab2","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade(table_prefix\u003d\u0027\u0027):"},{"line_number":32,"context_line":"    op.drop_column(table_prefix + \u0027zuul_build\u0027, \u0027node_name\u0027)"},{"line_number":33,"context_line":"    op.add_column("},{"line_number":34,"context_line":"        table_prefix + \u0027zuul_build\u0027, sa.Column(\u0027nodeset\u0027, sa.String(255)))"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"6ff932f5_3053f3b0","line":32,"updated":"2021-07-08 22:35:59.000000000","message":"It\u0027s been recording \"null\" values for years.  We can ignore it.","commit_id":"1076b205263b01b3144fae1fed625854fd727755"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"087d518c40e3286f9d6504ee7d80c3c7cc2c47ba","unresolved":true,"context_lines":[{"line_number":31,"context_line":"def upgrade(table_prefix\u003d\u0027\u0027):"},{"line_number":32,"context_line":"    op.drop_column(table_prefix + \u0027zuul_build\u0027, \u0027node_name\u0027)"},{"line_number":33,"context_line":"    op.add_column("},{"line_number":34,"context_line":"        table_prefix + \u0027zuul_build\u0027, sa.Column(\u0027nodeset\u0027, sa.String(255)))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aaa2d41_15d1e606","line":34,"range":{"start_line":34,"start_character":68,"end_line":34,"end_character":71},"updated":"2021-07-08 22:31:15.000000000","message":"Will we truncate names that are longer than this? Probably not an issue for most (all?) users but want to understand what will happen if the field is too large.","commit_id":"1076b205263b01b3144fae1fed625854fd727755"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d85b06b1d7bdba791643f0257a4f22483eb5dab2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade(table_prefix\u003d\u0027\u0027):"},{"line_number":32,"context_line":"    op.drop_column(table_prefix + \u0027zuul_build\u0027, \u0027node_name\u0027)"},{"line_number":33,"context_line":"    op.add_column("},{"line_number":34,"context_line":"        table_prefix + \u0027zuul_build\u0027, sa.Column(\u0027nodeset\u0027, sa.String(255)))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":6,"id":"28e0dbb7_ce53fdee","line":34,"updated":"2021-07-08 22:35:59.000000000","message":"Yep.  There are some other fields like this I think.","commit_id":"1076b205263b01b3144fae1fed625854fd727755"}],"zuul/model.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d85b06b1d7bdba791643f0257a4f22483eb5dab2","unresolved":false,"context_lines":[{"line_number":3340,"context_line":"                \u0027paused\u0027: build.paused if build else None,"},{"line_number":3341,"context_line":"                \u0027retry\u0027: build.retry if build else None,"},{"line_number":3342,"context_line":"                \u0027tries\u0027: self.current_build_set.getTries(job.name),"},{"line_number":3343,"context_line":"                \u0027queued\u0027: job.queued,"},{"line_number":3344,"context_line":"                \u0027worker\u0027: worker,"},{"line_number":3345,"context_line":"                \u0027waiting_status\u0027: waiting_status,"},{"line_number":3346,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":6,"id":"6b896072_47a36513","line":3343,"updated":"2021-07-08 22:35:59.000000000","message":"Possibly, but since this is for the status page, we might want something different.  I think it\u0027s a separate question.","commit_id":"1076b205263b01b3144fae1fed625854fd727755"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"087d518c40e3286f9d6504ee7d80c3c7cc2c47ba","unresolved":true,"context_lines":[{"line_number":3340,"context_line":"                \u0027paused\u0027: build.paused if build else None,"},{"line_number":3341,"context_line":"                \u0027retry\u0027: build.retry if build else None,"},{"line_number":3342,"context_line":"                \u0027tries\u0027: self.current_build_set.getTries(job.name),"},{"line_number":3343,"context_line":"                \u0027queued\u0027: job.queued,"},{"line_number":3344,"context_line":"                \u0027worker\u0027: worker,"},{"line_number":3345,"context_line":"                \u0027waiting_status\u0027: waiting_status,"},{"line_number":3346,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":6,"id":"e25c66bd_cba72640","line":3343,"updated":"2021-07-08 22:31:15.000000000","message":"Should nodeset be reported here?","commit_id":"1076b205263b01b3144fae1fed625854fd727755"}],"zuul/scheduler.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"087d518c40e3286f9d6504ee7d80c3c7cc2c47ba","unresolved":true,"context_lines":[{"line_number":1712,"context_line":"        )"},{"line_number":1713,"context_line":"        event_result \u003d event.result"},{"line_number":1714,"context_line":""},{"line_number":1715,"context_line":"        result \u003d event_result.get(\"result\")"},{"line_number":1716,"context_line":"        build.error_detail \u003d event_result.get(\"error_detail\")"},{"line_number":1717,"context_line":""},{"line_number":1718,"context_line":"        if result is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"d5454a6c_7e7fa6b7","line":1715,"updated":"2021-07-08 22:31:15.000000000","message":"Do we need to set nodeset here?","commit_id":"1076b205263b01b3144fae1fed625854fd727755"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d85b06b1d7bdba791643f0257a4f22483eb5dab2","unresolved":false,"context_lines":[{"line_number":1712,"context_line":"        )"},{"line_number":1713,"context_line":"        event_result \u003d event.result"},{"line_number":1714,"context_line":""},{"line_number":1715,"context_line":"        result \u003d event_result.get(\"result\")"},{"line_number":1716,"context_line":"        build.error_detail \u003d event_result.get(\"error_detail\")"},{"line_number":1717,"context_line":""},{"line_number":1718,"context_line":"        if result is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"c10374ed_de3c63d1","line":1715,"updated":"2021-07-08 22:35:59.000000000","message":"No it\u0027s set at the start of the build.","commit_id":"1076b205263b01b3144fae1fed625854fd727755"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5fad1de5738fabe3cb0642afe61c2e273fee5a5c","unresolved":false,"context_lines":[{"line_number":1712,"context_line":"        )"},{"line_number":1713,"context_line":"        event_result \u003d event.result"},{"line_number":1714,"context_line":""},{"line_number":1715,"context_line":"        result \u003d event_result.get(\"result\")"},{"line_number":1716,"context_line":"        build.error_detail \u003d event_result.get(\"error_detail\")"},{"line_number":1717,"context_line":""},{"line_number":1718,"context_line":"        if result is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"be59d343_b75ff2d8","line":1715,"updated":"2021-07-08 22:47:11.000000000","message":"We\u0027ll get the nodeset name from the job in the next PS.","commit_id":"1076b205263b01b3144fae1fed625854fd727755"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"a592ea5189b3a8260a28235ad0298694a60ffe3d","unresolved":false,"context_lines":[{"line_number":1712,"context_line":"        )"},{"line_number":1713,"context_line":"        event_result \u003d event.result"},{"line_number":1714,"context_line":""},{"line_number":1715,"context_line":"        result \u003d event_result.get(\"result\")"},{"line_number":1716,"context_line":"        build.error_detail \u003d event_result.get(\"error_detail\")"},{"line_number":1717,"context_line":""},{"line_number":1718,"context_line":"        if result is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"31cbb30e_3b15a79c","line":1715,"updated":"2021-07-08 22:42:24.000000000","message":"Well, actually that just changed.  Let\u0027s see what I come up with in the next PS.","commit_id":"1076b205263b01b3144fae1fed625854fd727755"}]}