)]}'
{"zuul/executor/server.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b12cb304a21c9066208f99efd2d982720cfa727a","unresolved":false,"context_lines":[{"line_number":823,"context_line":"    for node in nodes:"},{"line_number":824,"context_line":"        if freeze and (hostvars[node[\u0027name\u0027]][\u0027ansible_connection\u0027] in"},{"line_number":825,"context_line":"                       BLACKLISTED_ANSIBLE_CONNECTION_TYPES):"},{"line_number":826,"context_line":"            continue"},{"line_number":827,"context_line":"        node_hostvars \u003d hostvars[node[\u0027name\u0027]].copy()"},{"line_number":828,"context_line":"        if remove_keys:"},{"line_number":829,"context_line":"            for k in remove_keys:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0d9cf558_d5917e8f","line":826,"updated":"2021-06-30 17:26:42.000000000","message":"Based on chatting in IRC, it sounds like you\u0027re using network_cli only because it doesn\u0027t run the setup playbook.  We don\u0027t actually know whether this is a problem for normal network_cli usage, so I don\u0027t think we should merge this change.\n\nFor your use case, I would recommend adding a new type of \"resource\" like \"namespace\" or \"project\".  Then we won\u0027t add them to the zuul inventory at all.","commit_id":"701611c22c48746211bd857515ee29eefe84ae1a"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"36a4782d4f5c0f51ccda6e12c7c295c064d826e8","unresolved":false,"context_lines":[{"line_number":823,"context_line":"    for node in nodes:"},{"line_number":824,"context_line":"        if freeze and (hostvars[node[\u0027name\u0027]][\u0027ansible_connection\u0027] in"},{"line_number":825,"context_line":"                       BLACKLISTED_ANSIBLE_CONNECTION_TYPES):"},{"line_number":826,"context_line":"            continue"},{"line_number":827,"context_line":"        node_hostvars \u003d hostvars[node[\u0027name\u0027]].copy()"},{"line_number":828,"context_line":"        if remove_keys:"},{"line_number":829,"context_line":"            for k in remove_keys:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf37636d_a5ae42a8","line":826,"updated":"2021-06-30 13:51:09.000000000","message":"Instead of doing this, can we set gather_facts to false in the freeze playbook (since presumably we have gathered them (if possible) already during setup)?\n\nBecause if we don\u0027t run the freeze playbook, then we won\u0027t have any job variables available for a host.","commit_id":"701611c22c48746211bd857515ee29eefe84ae1a"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"eb023b445c60e787e2ce786b954e81b395363b36","unresolved":false,"context_lines":[{"line_number":823,"context_line":"    for node in nodes:"},{"line_number":824,"context_line":"        if freeze and (hostvars[node[\u0027name\u0027]][\u0027ansible_connection\u0027] in"},{"line_number":825,"context_line":"                       BLACKLISTED_ANSIBLE_CONNECTION_TYPES):"},{"line_number":826,"context_line":"            continue"},{"line_number":827,"context_line":"        node_hostvars \u003d hostvars[node[\u0027name\u0027]].copy()"},{"line_number":828,"context_line":"        if remove_keys:"},{"line_number":829,"context_line":"            for k in remove_keys:"}],"source_content_type":"text/x-python","patch_set":1,"id":"62b94623_b8dde3a3","line":826,"in_reply_to":"0d9cf558_d5917e8f","updated":"2021-06-30 18:05:29.000000000","message":"The use case, is we want them in the inventory file but not to run commands from zuul-executor until we have configured the node.  The use case I am thinking of, we need to SSH into a private IP from another node in the nodeset, to properly configure the public interface so that zuul-executor can start to use it.\n\nRight now, we have no way of opting out of this scan when we split it out from the setup playbooks.\n\nSo, I agree a new resource is likely needed, but I\u0027d like to also support the use-case above.\n\nA lot of this is network specific hardware where we cannot easily do provision things via cloud-init or glean.  And usually need to run raw commands to start.","commit_id":"701611c22c48746211bd857515ee29eefe84ae1a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7d305c98a82b5a2e8a77095e438fafe62927f7b0","unresolved":false,"context_lines":[{"line_number":823,"context_line":"    for node in nodes:"},{"line_number":824,"context_line":"        if freeze and (hostvars[node[\u0027name\u0027]][\u0027ansible_connection\u0027] in"},{"line_number":825,"context_line":"                       BLACKLISTED_ANSIBLE_CONNECTION_TYPES):"},{"line_number":826,"context_line":"            continue"},{"line_number":827,"context_line":"        node_hostvars \u003d hostvars[node[\u0027name\u0027]].copy()"},{"line_number":828,"context_line":"        if remove_keys:"},{"line_number":829,"context_line":"            for k in remove_keys:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1f02c3_052e8bea","line":826,"in_reply_to":"62b94623_b8dde3a3","updated":"2021-07-01 17:57:40.000000000","message":"To support your specific use case could the workflow be something like:\n\n* Zuul manages new resource, doesn\u0027t put it in the inventory but does put it in zuul vars.\n* Write a zuul role to provision that new resource so that it is able to talk to ansible\n* Manually add these resources to the inventory in your playbooks as necessary to talk to them.","commit_id":"701611c22c48746211bd857515ee29eefe84ae1a"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b12cb304a21c9066208f99efd2d982720cfa727a","unresolved":false,"context_lines":[{"line_number":1511,"context_line":"        # context."},{"line_number":1512,"context_line":"        self.writeInventory(self.jobdir.freeze_playbook,"},{"line_number":1513,"context_line":"                            self.original_hostvars,"},{"line_number":1514,"context_line":"                            True)"},{"line_number":1515,"context_line":"        freeze_status, freeze_code \u003d self.runAnsibleFreeze("},{"line_number":1516,"context_line":"            self.jobdir.freeze_playbook, self.ansible_version)"},{"line_number":1517,"context_line":"        if freeze_status !\u003d self.RESULT_NORMAL or setup_code !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"565fa9a9_e67ebde0","line":1514,"updated":"2021-06-30 17:26:42.000000000","message":"You should set freeze\u003dTrue here, because as it\u0027s written, you\u0027re passing remove_keys\u003dTrue.  (ed: not applicable any more).","commit_id":"701611c22c48746211bd857515ee29eefe84ae1a"}]}