)]}'
{"zuul/merger/client.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d973cf81256d2b6eb20a0eaef6198688db773267","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        return job"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def cleanupLostMergeRequests(self):"},{"line_number":132,"context_line":"        for merge_request in self.merger_api.lostMergeRequests():"},{"line_number":133,"context_line":"            try:"},{"line_number":134,"context_line":"                self.cleanupLostMergeRequest(merge_request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4c336d56_e843ebb1","side":"PARENT","line":131,"updated":"2021-07-31 19:59:28.000000000","message":"Oh I\u0027m sorry I should have commented on that.\n\nThe easiest way to test this code is to use it in test_zk, which doesn\u0027t start a full zuul so it\u0027s difficult to instantiate a merge client.  But it is easy to instantiate a merger api.  This code also fits very well into the merger api (possibly it\u0027s even better there), so I think it\u0027s okay to move.\n\nAnd yes, I agree we should move the equivalent executor code into the executor api.","commit_id":"6810d73b3bfd6e0ae717c6baeedb248270f22b45"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"2d7fc5e3a0872c1be079f8dfe1a89a5a80b0e743","unresolved":true,"context_lines":[{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        return job"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def cleanupLostMergeRequests(self):"},{"line_number":132,"context_line":"        for merge_request in self.merger_api.lostMergeRequests():"},{"line_number":133,"context_line":"            try:"},{"line_number":134,"context_line":"                self.cleanupLostMergeRequest(merge_request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8ab70990_566ff7f8","side":"PARENT","line":131,"updated":"2021-07-30 06:26:33.000000000","message":"Why are we moving this to the merger api? I don\u0027t mind any of the versions, I just put it in here as the equivalent build request cleanup methods are part of the executor client. If we move it here, we should also move the build request cleanup methods to the executor API.","commit_id":"6810d73b3bfd6e0ae717c6baeedb248270f22b45"}]}