)]}'
{"zuul/nodepool.py":[{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"720ec861692083c0b63fcc1c9c8611d8043faa13","unresolved":true,"context_lines":[{"line_number":467,"context_line":"                # nodeset (which produces a new nodeset with no real"},{"line_number":468,"context_line":"                # node info)."},{"line_number":469,"context_line":"                nodeset \u003d request.nodeset.copy()"},{"line_number":470,"context_line":"                new_req \u003d model.NodeRequest("},{"line_number":471,"context_line":"                    self.hostname,"},{"line_number":472,"context_line":"                    request.build_set_uuid,"},{"line_number":473,"context_line":"                    request.tenant_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d60b869c_392b683e","line":470,"updated":"2021-08-04 07:48:47.000000000","message":"Maybe I\u0027m missing something here, but how will the new node request end up in the current build set?\n\nIt looks like we create a new request but the build set still references the old one. When processing the nodes provisioned event for the new request it will probably skip it due to the check in line #435.","commit_id":"211a0a2a65f0eb8689a1a766419d5d898cdff7d4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5205e9168fb33bdf6038236c42e4f3795e472499","unresolved":true,"context_lines":[{"line_number":469,"context_line":"                nodeset \u003d request.nodeset.copy()"},{"line_number":470,"context_line":"                new_req \u003d model.NodeRequest("},{"line_number":471,"context_line":"                    self.hostname,"},{"line_number":472,"context_line":"                    request.build_set_uuid,"},{"line_number":473,"context_line":"                    request.tenant_name,"},{"line_number":474,"context_line":"                    request.pipeline_name,"},{"line_number":475,"context_line":"                    request.job_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"8f7aad38_8040aa2b","line":472,"updated":"2021-08-04 14:50:25.000000000","message":"I think this field is what ties the new request created to the existing buildset. Then the job_name below associates it with the specific job.","commit_id":"211a0a2a65f0eb8689a1a766419d5d898cdff7d4"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"25f04e9af349da2adbf01dcd7e6d9499eb1623b8","unresolved":false,"context_lines":[{"line_number":469,"context_line":"                nodeset \u003d request.nodeset.copy()"},{"line_number":470,"context_line":"                new_req \u003d model.NodeRequest("},{"line_number":471,"context_line":"                    self.hostname,"},{"line_number":472,"context_line":"                    request.build_set_uuid,"},{"line_number":473,"context_line":"                    request.tenant_name,"},{"line_number":474,"context_line":"                    request.pipeline_name,"},{"line_number":475,"context_line":"                    request.job_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5d951b2_f8593cf6","line":472,"updated":"2021-08-04 16:30:01.000000000","message":"This is the issue: https://opendev.org/zuul/zuul/src/branch/master/zuul/model.py#L2295\n\nThat will be changing as part of the v5 work, but hasn\u0027t yet.  I guess we\u0027re halfway there, with part of the scheduler no longer using cached build requests, but the pipelines / buildsets still do.\n\nI think rather than anticipating that change, we should simplify this one to narrowly fix the issue with the existing framework.","commit_id":"211a0a2a65f0eb8689a1a766419d5d898cdff7d4"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"1024aad03f10ea126f4e1fafdb1fd3ea0f00284c","unresolved":true,"context_lines":[{"line_number":469,"context_line":"                nodeset \u003d request.nodeset.copy()"},{"line_number":470,"context_line":"                new_req \u003d model.NodeRequest("},{"line_number":471,"context_line":"                    self.hostname,"},{"line_number":472,"context_line":"                    request.build_set_uuid,"},{"line_number":473,"context_line":"                    request.tenant_name,"},{"line_number":474,"context_line":"                    request.pipeline_name,"},{"line_number":475,"context_line":"                    request.job_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3759dcd9_6a23a929","line":472,"in_reply_to":"8f7aad38_8040aa2b","updated":"2021-08-04 14:52:31.000000000","message":"Yes, the request references the build set, but the problem is that the build set doesn\u0027t know about the new request.","commit_id":"211a0a2a65f0eb8689a1a766419d5d898cdff7d4"}]}