)]}'
{"web/src/containers/build/Buildset.jsx":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"ebfc701d2b41ab78727bf692dedfc2d88385b9df","unresolved":true,"context_lines":[{"line_number":169,"context_line":"                      .format(\u0027h [hr] m [min] s [sec]\u0027)} \u0026nbsp;"},{"line_number":170,"context_line":"                    \u003cButton"},{"line_number":171,"context_line":"                      key\u003d\u0027GanttChartToggle\u0027"},{"line_number":172,"context_line":"                      variant\u003d\u0027primary\u0027"},{"line_number":173,"context_line":"                      onClick\u003d{() \u003d\u003e { setIsGanttChartModalOpen(true) }}\u003eShow timeline"},{"line_number":174,"context_line":"                    \u003c/Button\u003e"},{"line_number":175,"context_line":"                  \u003c/\u003e"}],"source_content_type":"text/jsx","patch_set":2,"id":"3b0fd4f0_395c7801","line":172,"updated":"2021-09-30 14:40:16.000000000","message":"Shouldn\u0027t this be `secondary` to look less important? That would remove the blue background.","commit_id":"391184e44d64337c91adc23fe083ac4df6fedeb5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"961c7ef4889abd18cc23a00c4eb70b8906ce56f5","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                      .format(\u0027h [hr] m [min] s [sec]\u0027)} \u0026nbsp;"},{"line_number":170,"context_line":"                    \u003cButton"},{"line_number":171,"context_line":"                      key\u003d\u0027GanttChartToggle\u0027"},{"line_number":172,"context_line":"                      variant\u003d\u0027primary\u0027"},{"line_number":173,"context_line":"                      onClick\u003d{() \u003d\u003e { setIsGanttChartModalOpen(true) }}\u003eShow timeline"},{"line_number":174,"context_line":"                    \u003c/Button\u003e"},{"line_number":175,"context_line":"                  \u003c/\u003e"}],"source_content_type":"text/jsx","patch_set":2,"id":"099fea06_f2b8d06b","line":172,"in_reply_to":"3b0fd4f0_395c7801","updated":"2021-10-01 17:26:32.000000000","message":"Done","commit_id":"391184e44d64337c91adc23fe083ac4df6fedeb5"}],"web/src/containers/charts/GanttChart.jsx":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e710d511d0be1b9f1b67e86b4c35390f09541ace","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    const origin \u003d moment.utc(sortedByStartTime[builds.length - 1].start_time).tz(timezone)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    const longestJobName \u003d builds.reduce((a, build) \u003d\u003e (a.length \u003c build.job_name.length ? build.job_name : a), \u0027\u0027)"},{"line_number":42,"context_line":"    console.log(longestJobName)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    const data \u003d sortedByStartTime.map((build) \u003d\u003e {"},{"line_number":45,"context_line":"        return {"}],"source_content_type":"text/jsx","patch_set":1,"id":"bae970fb_5693a8e8","line":42,"updated":"2021-09-29 21:37:19.000000000","message":"Let\u0027s go ahead and remove it.","commit_id":"71bd4fac3081574b2e48f8b54b662c2655b1863e"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"5c3b1d8067cbbf1463c3a171372053440e041b32","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    const origin \u003d moment.utc(sortedByStartTime[builds.length - 1].start_time).tz(timezone)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    const longestJobName \u003d builds.reduce((a, build) \u003d\u003e (a.length \u003c build.job_name.length ? build.job_name : a), \u0027\u0027)"},{"line_number":42,"context_line":"    console.log(longestJobName)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    const data \u003d sortedByStartTime.map((build) \u003d\u003e {"},{"line_number":45,"context_line":"        return {"}],"source_content_type":"text/jsx","patch_set":1,"id":"cac84845_e9e32fc1","line":42,"updated":"2021-09-29 19:32:39.000000000","message":"That looks like debug leftover.","commit_id":"71bd4fac3081574b2e48f8b54b662c2655b1863e"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"c0cd1670b5bf76ee5d2e73ec119deaf253dab822","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    const origin \u003d moment.utc(sortedByStartTime[builds.length - 1].start_time).tz(timezone)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    const longestJobName \u003d builds.reduce((a, build) \u003d\u003e (a.length \u003c build.job_name.length ? build.job_name : a), \u0027\u0027)"},{"line_number":42,"context_line":"    console.log(longestJobName)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    const data \u003d sortedByStartTime.map((build) \u003d\u003e {"},{"line_number":45,"context_line":"        return {"}],"source_content_type":"text/jsx","patch_set":1,"id":"ebfead04_fa972eec","line":42,"in_reply_to":"bae970fb_5693a8e8","updated":"2021-09-30 11:32:48.000000000","message":"Done","commit_id":"71bd4fac3081574b2e48f8b54b662c2655b1863e"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e710d511d0be1b9f1b67e86b4c35390f09541ace","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \u003cChartVoronoiContainer"},{"line_number":78,"context_line":"                        constrainToVisibleArea"},{"line_number":79,"context_line":"                        labels\u003d{({ datum }) \u003d\u003e `Started on ${datum.started}, ended in ${datum.result} on ${datum.ended}`}"},{"line_number":80,"context_line":"                    /\u003e"},{"line_number":81,"context_line":"                }"},{"line_number":82,"context_line":"                padding\u003d{{"},{"line_number":83,"context_line":"                    bottom: 80,"}],"source_content_type":"text/jsx","patch_set":1,"id":"c81f80e1_516bbd7f","line":80,"updated":"2021-09-29 21:37:19.000000000","message":"I\u0027m not sure if you have control over this, but the mousever obscures what it\u0027s pointing at.  I think it\u0027d be better if it could be shifted above or below the pointer.\n\nAlso, this behaves very strangely once you trigger a mousover, then move away from the bars.  It seems like a random label keeps popping up.\n\nIf it\u0027s not possible to control this, it might be worth just omitting the label, since the data are already available elsewhere.","commit_id":"71bd4fac3081574b2e48f8b54b662c2655b1863e"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"8ae3d004d977060acf7bb13859043b6843df521c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \u003cChartVoronoiContainer"},{"line_number":78,"context_line":"                        constrainToVisibleArea"},{"line_number":79,"context_line":"                        labels\u003d{({ datum }) \u003d\u003e `Started on ${datum.started}, ended in ${datum.result} on ${datum.ended}`}"},{"line_number":80,"context_line":"                    /\u003e"},{"line_number":81,"context_line":"                }"},{"line_number":82,"context_line":"                padding\u003d{{"},{"line_number":83,"context_line":"                    bottom: 80,"}],"source_content_type":"text/jsx","patch_set":1,"id":"97b11033_0f4285b4","line":80,"updated":"2021-10-04 14:49:27.000000000","message":"That is much better, thanks!","commit_id":"71bd4fac3081574b2e48f8b54b662c2655b1863e"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"c0cd1670b5bf76ee5d2e73ec119deaf253dab822","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \u003cChartVoronoiContainer"},{"line_number":78,"context_line":"                        constrainToVisibleArea"},{"line_number":79,"context_line":"                        labels\u003d{({ datum }) \u003d\u003e `Started on ${datum.started}, ended in ${datum.result} on ${datum.ended}`}"},{"line_number":80,"context_line":"                    /\u003e"},{"line_number":81,"context_line":"                }"},{"line_number":82,"context_line":"                padding\u003d{{"},{"line_number":83,"context_line":"                    bottom: 80,"}],"source_content_type":"text/jsx","patch_set":1,"id":"838eaa5b_b38682d2","line":80,"in_reply_to":"c81f80e1_516bbd7f","updated":"2021-09-30 11:32:48.000000000","message":"I\u0027ve switched to using the native ChartTooltip component, compacted the label a bit with carriage returns, and added some padding to the right of the chart, giving some space for the label to pop up without overlapping the bar (although not always possible).\n\nI don\u0027t want to increase right padding too much, as it can otherwise make the graph area quite crammed (see for example buildset c0f357960cf147d98f5cc07302481649 in the zuul tenant). If you think it still does not look good enough, I can just remove the label in the next PS as you suggested.","commit_id":"71bd4fac3081574b2e48f8b54b662c2655b1863e"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"ebfc701d2b41ab78727bf692dedfc2d88385b9df","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                \u003cChartAxis /\u003e"},{"line_number":88,"context_line":"                \u003cChartAxis"},{"line_number":89,"context_line":"                    dependentAxis"},{"line_number":90,"context_line":"                    showGrid"},{"line_number":91,"context_line":"                    label\u003d\u0027Duration (seconds)\u0027"},{"line_number":92,"context_line":"                    fixLabelOverlap\u003d{true}"},{"line_number":93,"context_line":"                    style\u003d{{ tickLabels: { angle: -25, padding: 1, verticalAnchor: \u0027middle\u0027, textAnchor: \u0027end\u0027 } }} /\u003e"}],"source_content_type":"text/jsx","patch_set":2,"id":"658b4199_7f2132e1","line":90,"updated":"2021-09-30 14:40:16.000000000","message":"nit: using `tickFormat` it seems like we should be able to display text value like (1sec, 5min, ...)","commit_id":"391184e44d64337c91adc23fe083ac4df6fedeb5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"961c7ef4889abd18cc23a00c4eb70b8906ce56f5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                \u003cChartAxis /\u003e"},{"line_number":88,"context_line":"                \u003cChartAxis"},{"line_number":89,"context_line":"                    dependentAxis"},{"line_number":90,"context_line":"                    showGrid"},{"line_number":91,"context_line":"                    label\u003d\u0027Duration (seconds)\u0027"},{"line_number":92,"context_line":"                    fixLabelOverlap\u003d{true}"},{"line_number":93,"context_line":"                    style\u003d{{ tickLabels: { angle: -25, padding: 1, verticalAnchor: \u0027middle\u0027, textAnchor: \u0027end\u0027 } }} /\u003e"}],"source_content_type":"text/jsx","patch_set":2,"id":"f30b7d62_c69b9022","line":90,"in_reply_to":"658b4199_7f2132e1","updated":"2021-10-01 17:26:32.000000000","message":"Done","commit_id":"391184e44d64337c91adc23fe083ac4df6fedeb5"}],"web/src/containers/charts/Misc.jsx":[{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"c0cd1670b5bf76ee5d2e73ec119deaf253dab822","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"const buildResultLegendData \u003d ["},{"line_number":18,"context_line":"    {"},{"line_number":19,"context_line":"        name: \u0027SUCCESS\u0027,"},{"line_number":20,"context_line":"        // PF green-500"}],"source_content_type":"text/jsx","patch_set":1,"id":"00bef91e_7e723456","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":27},"updated":"2021-09-30 11:32:48.000000000","message":"Should we standardize these colors, ie use them for badges in the build pages and for the color of result links in the builds search page ?","commit_id":"71bd4fac3081574b2e48f8b54b662c2655b1863e"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"8ae3d004d977060acf7bb13859043b6843df521c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"const buildResultLegendData \u003d ["},{"line_number":18,"context_line":"    {"},{"line_number":19,"context_line":"        name: \u0027SUCCESS\u0027,"},{"line_number":20,"context_line":"        // PF green-500"}],"source_content_type":"text/jsx","patch_set":1,"id":"3fc6f447_a1061f17","line":17,"updated":"2021-10-04 14:49:27.000000000","message":"Yes that would be great.","commit_id":"71bd4fac3081574b2e48f8b54b662c2655b1863e"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"8ae3d004d977060acf7bb13859043b6843df521c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    data: {"},{"line_number":80,"context_line":"        fill: ({ datum }) \u003d\u003e buildsBarStyleMap[datum.result]"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"export { buildResultLegendData, buildsBarStyleMap, buildsBarStyle }"}],"source_content_type":"text/jsx","patch_set":1,"id":"71195c76_bd6725cf","line":82,"updated":"2021-10-04 14:49:27.000000000","message":"I\u0027m not too worried about that.","commit_id":"71bd4fac3081574b2e48f8b54b662c2655b1863e"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"c0cd1670b5bf76ee5d2e73ec119deaf253dab822","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    (final, x) \u003d\u003e ({ ...final, [x.name]: x.symbol.fill }), {}"},{"line_number":76,"context_line":")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"const buildsBarStyle \u003d {"},{"line_number":79,"context_line":"    data: {"},{"line_number":80,"context_line":"        fill: ({ datum }) \u003d\u003e buildsBarStyleMap[datum.result]"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"export { buildResultLegendData, buildsBarStyleMap, buildsBarStyle }"}],"source_content_type":"text/jsx","patch_set":1,"id":"8f6756e9_57e8b716","line":82,"range":{"start_line":78,"start_character":0,"end_line":82,"end_character":1},"updated":"2021-09-30 11:32:48.000000000","message":"note that if a result value isn\u0027t defined in buildResultLegendData, it\u0027ll appear as a black bar on the graph. Any values I should add? Shall I change the default color to something else?","commit_id":"71bd4fac3081574b2e48f8b54b662c2655b1863e"}]}