)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"542236ff288c2320f9f0aa728e1a993814e480ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2fc72139_bc750a0f","updated":"2021-10-29 17:17:22.000000000","message":"recheck","commit_id":"4faf5498e41860ccdcfd6531bd0128934c661ad9"}],"zuul/scheduler.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"575c9215239e32c6ddff391fbea7e8c1a3a4b875","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"            static_window \u003d False"},{"line_number":1208,"context_line":"        # if old_pipeline.window and (not static_window):"},{"line_number":1209,"context_line":"        #     new_pipeline.window \u003d max(old_pipeline.window,"},{"line_number":1210,"context_line":"        #                               new_pipeline.window_floor)"},{"line_number":1211,"context_line":"        items_to_remove \u003d []"},{"line_number":1212,"context_line":"        builds_to_cancel \u003d []"},{"line_number":1213,"context_line":"        requests_to_cancel \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"6053ddd2_0ced1f39","line":1210,"updated":"2021-10-22 01:49:27.000000000","message":"Huh.  My guess is that this is ancient code and didn\u0027t get updated during some change to how queues were handled.  Or maybe it never did anything.\n\nI agree it looks like it doesn\u0027t do anything now.\n\nThe intent is that if you set a new floor in the configuration, we should update that.  So the right thing to do would be to adjust all the queue values here.  If you want to punt on that and just remove this and leave a TODO, that wfm.","commit_id":"19adac27d93fcde15e8ac68a4b95719031303365"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"815138326afe6a683ac74eff0f2ea1ce566cc5e8","unresolved":true,"context_lines":[{"line_number":1207,"context_line":"            static_window \u003d False"},{"line_number":1208,"context_line":"        # if old_pipeline.window and (not static_window):"},{"line_number":1209,"context_line":"        #     new_pipeline.window \u003d max(old_pipeline.window,"},{"line_number":1210,"context_line":"        #                               new_pipeline.window_floor)"},{"line_number":1211,"context_line":"        items_to_remove \u003d []"},{"line_number":1212,"context_line":"        builds_to_cancel \u003d []"},{"line_number":1213,"context_line":"        requests_to_cancel \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"8dd30e79_e79ce36e","line":1210,"updated":"2021-10-20 15:20:54.000000000","message":"I think I don\u0027t fully understand this. AFAIKS the pipeline window is only passed to change queues as the initial start value but never adjusted. I don\u0027t see why we need to use the max of the old pipeline window and the new window floor.","commit_id":"19adac27d93fcde15e8ac68a4b95719031303365"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"a5f12df905cb404e1c695b3f62bccb99616ef956","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"            static_window \u003d False"},{"line_number":1208,"context_line":"        # if old_pipeline.window and (not static_window):"},{"line_number":1209,"context_line":"        #     new_pipeline.window \u003d max(old_pipeline.window,"},{"line_number":1210,"context_line":"        #                               new_pipeline.window_floor)"},{"line_number":1211,"context_line":"        items_to_remove \u003d []"},{"line_number":1212,"context_line":"        builds_to_cancel \u003d []"},{"line_number":1213,"context_line":"        requests_to_cancel \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa84d9_9b1055f6","line":1210,"in_reply_to":"6053ddd2_0ced1f39","updated":"2021-10-22 09:37:53.000000000","message":"Done. I just had to move the code for adjusting the queue window after the re-enqueue of the items since the queue might not exist at that point.","commit_id":"19adac27d93fcde15e8ac68a4b95719031303365"}]}