)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"3f46bda65990bce9095fb82e5fd18c4e1b438bf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"829bec66_4c5a03eb","updated":"2021-11-05 18:29:15.000000000","message":"I\u0027ve noticed a funny bug when signing in from the status page: the callback parameters appear in the search bar when coming back from the identity provider. See https://ibb.co/xGMkhhM","commit_id":"2b1124ebb3628521085eae1b7ed22521dab5aea8"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"4b11cfa24e0f2b6f3b4dd2780610826870593c69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8d6c29e5_46ec4899","updated":"2021-11-05 15:14:07.000000000","message":"fixed linting errors","commit_id":"2b1124ebb3628521085eae1b7ed22521dab5aea8"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"e5fc281d1b04f425d1b3697070175324d175dc86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be0322b4_683d8b9b","updated":"2021-11-05 17:13:51.000000000","message":"the signin redirection doesn\u0027t seem to work correctly when the GUI is served as a subdirectory behind a reverse proxy: from \"https://zuuldemo.strangerpings.eu/zuul/t/example-tenant/status\" I was redirected to \"https://zuuldemo.strangerpings.eu/zuul/zuul/t/example-tenant/status#\" - my guess is that the default redirect method uses window.location.pathname instead of href.","commit_id":"2b1124ebb3628521085eae1b7ed22521dab5aea8"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"87619b42cff2600feb13409c0dc154ce888ef713","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"91fdcf93_0dcd1805","updated":"2021-11-10 15:02:00.000000000","message":"This change was squashed into https://review.opendev.org/c/zuul/zuul/+/734082","commit_id":"54b3c856e8aa5194fb4f24ecb5600920dd907f1e"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"b9176e06abbefaa2bec8c65dc8842e51ca2cc3ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"31cb3236_50cdac7a","updated":"2021-11-09 12:15:26.000000000","message":"recheck","commit_id":"54b3c856e8aa5194fb4f24ecb5600920dd907f1e"}],"web/src/ZuulAuthProvider.jsx":[{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"02b81cb12a13b0c87c064bd48815c05633c80f0a","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    };"},{"line_number":64,"context_line":"    return ("},{"line_number":65,"context_line":"      \u003cReact.Fragment\u003e"},{"line_number":66,"context_line":"        \u003cAuthProvider {...oidcConfig} key\u003d{JSON.stringify(auth_params)}\u003e"},{"line_number":67,"context_line":"          {this.props.children}"},{"line_number":68,"context_line":"        \u003c/AuthProvider\u003e"},{"line_number":69,"context_line":"      \u003c/React.Fragment\u003e"}],"source_content_type":"text/jsx","patch_set":2,"id":"7c66e440_c7262787","line":66,"updated":"2021-11-03 09:58:07.000000000","message":"Does it work if oidcConfig is empty? How does this behave if no auth is configured?","commit_id":"5490438de1eb020e4232e5872aa33c7c4a8126fd"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d051c79c7890b8646aaff6ff32542256b4112e77","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    };"},{"line_number":64,"context_line":"    return ("},{"line_number":65,"context_line":"      \u003cReact.Fragment\u003e"},{"line_number":66,"context_line":"        \u003cAuthProvider {...oidcConfig} key\u003d{JSON.stringify(auth_params)}\u003e"},{"line_number":67,"context_line":"          {this.props.children}"},{"line_number":68,"context_line":"        \u003c/AuthProvider\u003e"},{"line_number":69,"context_line":"      \u003c/React.Fragment\u003e"}],"source_content_type":"text/jsx","patch_set":2,"id":"61272f7d_0b455466","line":66,"updated":"2021-11-04 15:38:52.000000000","message":"We define oidcConfig just above, so it won\u0027t be empty, but I assume you mean what if auth_params is empty (which is a component of oidcConfig).\n\nIn reducers/auth.js, we default auth_params to the empty string for authority, clientId, and scope.  If there\u0027s no previously stored value in localStorage, then we\u0027ll use that (also, if we switch tenants, and there\u0027s no auth info for the new tenant, the same is true; that\u0027s in actions/auth.js).\n\nThe AuthProvider accepts these values.  Of course, a login won\u0027t work, but we won\u0027t display the button in this case anyway.","commit_id":"5490438de1eb020e4232e5872aa33c7c4a8126fd"}],"web/src/containers/auth/Auth.jsx":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b75ba7ff9d83d7b6bc06bd8a4cb76456ba8ff24b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            key\u003d\"SignIn\""},{"line_number":186,"context_line":"            variant\u003d{ButtonVariant.plain}"},{"line_number":187,"context_line":"            onClick\u003d{() \u003d\u003e {"},{"line_number":188,"context_line":"              this.props.signIn({ redirect_uri: getHomepageUrl() + window.location.pathname })"},{"line_number":189,"context_line":"            }}\u003e"},{"line_number":190,"context_line":"            Sign in \u0026nbsp;"},{"line_number":191,"context_line":"            \u003cSignInAltIcon title\u003d\u0027Sign In\u0027 /\u003e"}],"source_content_type":"text/jsx","patch_set":4,"id":"0a24fc5a_64bd7f77","line":188,"updated":"2021-11-05 23:39:06.000000000","message":"Fixed.","commit_id":"2b1124ebb3628521085eae1b7ed22521dab5aea8"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"3f46bda65990bce9095fb82e5fd18c4e1b438bf5","unresolved":true,"context_lines":[{"line_number":185,"context_line":"            key\u003d\"SignIn\""},{"line_number":186,"context_line":"            variant\u003d{ButtonVariant.plain}"},{"line_number":187,"context_line":"            onClick\u003d{() \u003d\u003e {"},{"line_number":188,"context_line":"              this.props.signIn({ redirect_uri: getHomepageUrl() + window.location.pathname })"},{"line_number":189,"context_line":"            }}\u003e"},{"line_number":190,"context_line":"            Sign in \u0026nbsp;"},{"line_number":191,"context_line":"            \u003cSignInAltIcon title\u003d\u0027Sign In\u0027 /\u003e"}],"source_content_type":"text/jsx","patch_set":4,"id":"48f673d6_7d2be6f2","line":188,"range":{"start_line":188,"start_character":48,"end_line":188,"end_character":91},"updated":"2021-11-05 18:29:15.000000000","message":"using window.location.href fixes the redirection bug.","commit_id":"2b1124ebb3628521085eae1b7ed22521dab5aea8"}],"web/src/containers/build/Build.jsx":[{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"4ef90cbce56ffb6f534c1affd7e1ddadb5f57ea8","unresolved":true,"context_lines":[{"line_number":42,"context_line":"import renderAutoholdModal from \u0027../autohold/autoholdModal\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"function Build({ build, tenant, timezone, user }) {"},{"line_number":45,"context_line":"  let default_form_reason \u003d user.data ? \u0027Requested from the web UI by \u0027 + user.data.profile.preferred_username : \u0027-\u0027"},{"line_number":46,"context_line":"  const [showAutoholdModal, setShowAutoholdModal] \u003d useState(false)"},{"line_number":47,"context_line":"  const [ahFormChange, setAhFormChange] \u003d useState(build.change ? build.change : \u0027\u0027)"},{"line_number":48,"context_line":"  const [ahFormRef, setAhFormRef] \u003d useState(build.change ? \u0027\u0027 : build.ref)"}],"source_content_type":"text/jsx","patch_set":10,"id":"d88a998f_415ef709","line":45,"range":{"start_line":45,"start_character":40,"end_line":45,"end_character":110},"updated":"2021-11-09 12:18:36.000000000","message":"That should not be required, in the autohold modal we already set a mandatory prefix to the reason, this prefix includes the user\u0027s preferred username.","commit_id":"54b3c856e8aa5194fb4f24ecb5600920dd907f1e"}],"web/src/pages/AuthCallback.jsx":[{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"3d6a6ea7a7c181a3628c294836de022d40cf9df7","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    history.push(redirect)"},{"line_number":31,"context_line":"  }, [history])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  return \u003cFetching /\u003e"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"export default AuthCallbackPage"}],"source_content_type":"text/jsx","patch_set":8,"id":"9db869ac_48ec2b3c","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":21},"updated":"2021-11-08 14:38:36.000000000","message":"NIT: I suggest we should keep the original \"login successful, you will be redirected shortly\" message. The redirection is fast, but for a short moment the user doesn\u0027t really know what is going on.","commit_id":"01140fe25e457dd4c5ab6078bae56daf924a7430"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"db7de6cdbd6a4a91128ee679ac146204cb4b2618","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    history.push(redirect)"},{"line_number":31,"context_line":"  }, [history])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  return \u003cFetching /\u003e"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"export default AuthCallbackPage"}],"source_content_type":"text/jsx","patch_set":8,"id":"1c321ce7_d0f95201","line":33,"updated":"2021-11-09 00:34:16.000000000","message":"Sounds good.","commit_id":"01140fe25e457dd4c5ab6078bae56daf924a7430"}]}