)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34418,"name":"Dominik Jaeger","email":"dominik.jaeger@nokia.com","username":"d-j-j"},"change_message_id":"7db7fc2986dee94d5945635c7c8ed300c59450dd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56d26bea_d5b73501","updated":"2022-01-19 14:59:50.000000000","message":"\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e I think it would be better to keep the tools directory and the tutorial examples separate.  The tools directory is a bit informal and not tested.  The tutorial examples should be as minimal as possible.\n\nSure, I just wanted to avoid duplicating the script. My first version was actually separate and I can restore it in next PS.\n\n\u003e \n\u003e Given that the tools/test-setup-docker.sh script runs zk-ca.sh before docker-compose, how is this necessary?  Are you running docker-compose without using test-setup-docker.sh?  Maybe you can just add the wait into whatever script you are running.\n\nI\u0027m not really sure why it happens but with ZooKeeper 3.7 it just hangs and doesn\u0027t come up if this waiting is not done. It\u0027s not about generating the certs before docker-compose but something related with the order of mount availability and ZooKeeper service start. Probably the author of the related change in the tutorial version knows more.\n","commit_id":"273af63cdf5378e768f3786650a60b4809d9d8fe"},{"author":{"_account_id":34418,"name":"Dominik Jaeger","email":"dominik.jaeger@nokia.com","username":"d-j-j"},"change_message_id":"1c023076162026e5897d8f1c23261d89f7e4038e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c42e6fd_c2fee8f6","updated":"2022-01-03 15:01:16.000000000","message":"Hello Clark, I added you as reviewer for this as you created the wait-scripts in commit 3b7cf3dbaa8b95904cfb8e7eca91cf3325e178e0. I\u0027d appreciate your review 😊","commit_id":"273af63cdf5378e768f3786650a60b4809d9d8fe"},{"author":{"_account_id":34418,"name":"Dominik Jaeger","email":"dominik.jaeger@nokia.com","username":"d-j-j"},"change_message_id":"aa068692dc83c88cd1bb8b2b3babf833b1e3dc07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"57b2d20d_42e8acb5","in_reply_to":"56d26bea_d5b73501","updated":"2022-01-20 10:43:45.000000000","message":"Done","commit_id":"273af63cdf5378e768f3786650a60b4809d9d8fe"},{"author":{"_account_id":34418,"name":"Dominik Jaeger","email":"dominik.jaeger@nokia.com","username":"d-j-j"},"change_message_id":"f466dc368570752d14850c80c8f272f84317a0a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"85efec9a_e36c3cb6","updated":"2022-01-26 14:58:38.000000000","message":"\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e Can you confirm that you are just running \"./test-setup-docker.sh\" from the tools directory?\n\u003e \n\u003e I do that quite often, and it works fine with the ZK 3.7.0 docker images.\n\u003e \n\u003e Docker mounts all of the volumes before starting the process, and the certs are already created, so I don\u0027t see how that can be causing the problem.\n\u003e \n\u003e The reason this is needed in the tutorial is that docker-compose starts all the containers first, and one of the containers is responsible for creating the certificates.  Therefore the ZK container starts without any certs available.  That\u0027s not the case with test-setup-docker.\n\nYes I confirm that I\u0027m running ./test-setup-docker.sh and then tox command from root dir.\nwithout this change I always get:\n\n    Traceback (most recent call last):\n\n      File \".tox/py3/lib/python3.6/site-packages/fixtures/fixture.py\", line 197, in setUp\n    self._setUp()\n\n      File \"tests/base.py\", line 3904, in _setUp\n    _tmp_client.start()\n\n      File \"zuul/.tox/py3/lib/python3.6/site-packages/kazoo/client.py\", line 635, in start\n    raise self.handler.timeout_exception(\"Connection time-out\")\n\n    kazoo.handlers.threading.KazooTimeoutError: Connection time-out\n\nI can also reproduce this with a minimal ZK client script using kazoo.\n\nWith this change the error goes away.\n\nMaybe it could be related to docker version or my environment?\n\nDocker version 18.09.0, build 4d60db4","commit_id":"51cad4e794a26f0f147d426d35d95d62c1141b75"},{"author":{"_account_id":34418,"name":"Dominik Jaeger","email":"dominik.jaeger@nokia.com","username":"d-j-j"},"change_message_id":"aa068692dc83c88cd1bb8b2b3babf833b1e3dc07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1cf99fce_78338c78","updated":"2022-01-20 10:43:45.000000000","message":"\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e I think it would be better to keep the tools directory and the tutorial examples separate.  The tools directory is a bit informal and not tested.  The tutorial examples should be as minimal as possible.\n\u003e \n\u003e Given that the tools/test-setup-docker.sh script runs zk-ca.sh before docker-compose, how is this necessary?  Are you running docker-compose without using test-setup-docker.sh?  Maybe you can just add the wait into whatever script you are running.\n\n","commit_id":"51cad4e794a26f0f147d426d35d95d62c1141b75"},{"author":{"_account_id":34418,"name":"Dominik Jaeger","email":"dominik.jaeger@nokia.com","username":"d-j-j"},"change_message_id":"888d7243771dc92306e74ae52fe214b125de7530","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dca27692_ff0370d5","in_reply_to":"85efec9a_e36c3cb6","updated":"2022-01-26 15:01:11.000000000","message":"Also this SSL warning is visible before above exception:\n2022-01-26 15:54:11,305 kazoo.client                     WARNING  Connection dropped: socket connection error: EOF occurred in violation of protocol (_ssl.c:748","commit_id":"51cad4e794a26f0f147d426d35d95d62c1141b75"},{"author":{"_account_id":34418,"name":"Dominik Jaeger","email":"dominik.jaeger@nokia.com","username":"d-j-j"},"change_message_id":"a619a5ce616e4a7617c71bd310003f824dd3b473","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"915170f8_2733bbff","in_reply_to":"dca27692_ff0370d5","updated":"2022-01-26 15:21:23.000000000","message":"I played around a bit more after your comments and now realized that just adding the start command (without the waiting script) \"zkServer.sh start-foreground\" also fixes the timeout issue for me.\nNot sure yet why that is.","commit_id":"51cad4e794a26f0f147d426d35d95d62c1141b75"}]}