)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2104a03b8b5c440250aa34f7f69273cc7b090331","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed9e4a96_869d68ee","updated":"2022-01-13 22:36:27.000000000","message":"recheck","commit_id":"cb8a214fcc8d8b4723d4c690e0e8d6f5d0ffac10"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"b7ab8bc86062a10367a4282da3953862ce69b5d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d9e86dd_77a833dc","updated":"2022-01-14 16:01:54.000000000","message":"recheck","commit_id":"fa6960a5f3666ce0793588e1981e8756fbdfefb6"}],"zuul/lib/connections.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c0d48617b9ae36ed1733ea9da611bfe227082c6f","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            con_config \u003d dict(config.items(\u0027database\u0027))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"            connection \u003d driver.getConnection(\u0027database\u0027, con_config)"},{"line_number":107,"context_line":"            connections[\u0027database\u0027] \u003d connection"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        for section_name in config.sections():"},{"line_number":110,"context_line":"            con_match \u003d re.match(r\u0027^connection ([\\\u0027\\\"]?)(.*)(\\1)$\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3d7911fe_ec7945d5","line":107,"updated":"2022-01-13 19:05:45.000000000","message":"Should there be an elif require_sql: block here to raise an error? If we require_sql and there is no database in the config we should error I think.","commit_id":"cb8a214fcc8d8b4723d4c690e0e8d6f5d0ffac10"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"76d9cfebd85eec58d6a40c51731ecb6d1e0e1f18","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if require_sql:"},{"line_number":178,"context_line":"            if \u0027database\u0027 not in connections:"},{"line_number":179,"context_line":"                raise Exception(\"Database configuration is required\")"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self.connections \u003d connections"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e4a59f45_832e4931","line":179,"updated":"2022-01-13 19:06:49.000000000","message":"Clark, I think this handles that case.","commit_id":"cb8a214fcc8d8b4723d4c690e0e8d6f5d0ffac10"}]}
