)]}'
{"zuul/model.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b452941f0a8ca4fbdd23c4237dac0d4a464246bb","unresolved":false,"context_lines":[{"line_number":2042,"context_line":"                v \u003d {\u0027storage\u0027: \u0027local\u0027, \u0027data\u0027: v}"},{"line_number":2043,"context_line":"            data[k] \u003d v"},{"line_number":2044,"context_line":""},{"line_number":2045,"context_line":"        data[\u0027affected_projects\u0027] \u003d self.affected_projects"},{"line_number":2046,"context_line":"        data[\u0027config_hash\u0027] \u003d self.config_hash"},{"line_number":2047,"context_line":""},{"line_number":2048,"context_line":"        # Use json_dumps to strip any ZuulMark entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7e3bd46_fb2b55d1","line":2045,"updated":"2022-01-17 16:54:11.000000000","message":"Should this be a JobData?  The list of affected projects could be quite large.","commit_id":"41f9cdb5bf64c8ee83d5fc571ffd7d4784657283"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"2c8b782aa5c508ca753b21987d3d0502e9686b92","unresolved":false,"context_lines":[{"line_number":2042,"context_line":"                v \u003d {\u0027storage\u0027: \u0027local\u0027, \u0027data\u0027: v}"},{"line_number":2043,"context_line":"            data[k] \u003d v"},{"line_number":2044,"context_line":""},{"line_number":2045,"context_line":"        data[\u0027affected_projects\u0027] \u003d self.affected_projects"},{"line_number":2046,"context_line":"        data[\u0027config_hash\u0027] \u003d self.config_hash"},{"line_number":2047,"context_line":""},{"line_number":2048,"context_line":"        # Use json_dumps to strip any ZuulMark entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"c37a69a6_8fcd1113","line":2045,"in_reply_to":"c7e3bd46_fb2b55d1","updated":"2022-01-18 06:20:43.000000000","message":"Thanks for the comment. I haven\u0027t thought about the list being that large. But if you say so, it makes sense to make it a JobData attribute. I will update the change.","commit_id":"41f9cdb5bf64c8ee83d5fc571ffd7d4784657283"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ccdb0aabc0002e99f953fe4492f3fcb2ffd37eed","unresolved":false,"context_lines":[{"line_number":2477,"context_line":"        # this array, and then refer to them by index."},{"line_number":2478,"context_line":"        attributes.discard(\u0027secrets\u0027)"},{"line_number":2479,"context_line":"        attributes.discard(\u0027affected_projects\u0027)"},{"line_number":2480,"context_line":"        attributes.discard(\u0027config_hash\u0027)"},{"line_number":2481,"context_line":"        secrets \u003d []"},{"line_number":2482,"context_line":"        for k in attributes:"},{"line_number":2483,"context_line":"            # If this is a config object, it\u0027s frozen, so it\u0027s"}],"source_content_type":"text/x-python","patch_set":3,"id":"8c4e20cd_748e171c","line":2480,"updated":"2022-01-18 15:17:08.000000000","message":"Note to reviewers, these are added below.","commit_id":"b0962878ecc2b4c6a1449d6ebaa31684b1b36733"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ccdb0aabc0002e99f953fe4492f3fcb2ffd37eed","unresolved":false,"context_lines":[{"line_number":2505,"context_line":"            kw[k] \u003d v"},{"line_number":2506,"context_line":"        kw[\u0027secrets\u0027] \u003d secrets"},{"line_number":2507,"context_line":"        kw[\u0027affected_projects\u0027] \u003d self._getAffectedProjects(tenant)"},{"line_number":2508,"context_line":"        kw[\u0027config_hash\u0027] \u003d self.getConfigHash(tenant)"},{"line_number":2509,"context_line":"        # Don\u0027t add buildset to attributes since it\u0027s not serialized"},{"line_number":2510,"context_line":"        kw[\u0027buildset\u0027] \u003d buildset"},{"line_number":2511,"context_line":"        return FrozenJob.new(context, **kw)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b9df5b0e_15f7c455","line":2508,"updated":"2022-01-18 15:17:08.000000000","message":"^ here.","commit_id":"b0962878ecc2b4c6a1449d6ebaa31684b1b36733"}]}
