)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"17d6e19982ff90fdd238b298e60cfa390b95ac55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80d38f89_2ff27725","updated":"2022-01-18 12:05:13.000000000","message":"recheck","commit_id":"68f34c72e20e722a146b88faa84744dc71e6108c"}],"tests/unit/test_database.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3b0524b5e3629aaba52f3d90fa678380b060aadf","unresolved":true,"context_lines":[{"line_number":40,"context_line":"class TestMysqlDatabase(DBBaseTestCase):"},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super().setUp()"},{"line_number":43,"context_line":"        self.setupZK()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        f \u003d MySQLSchemaFixture()"},{"line_number":46,"context_line":"        self.useFixture(f)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dea5231b_0dfb64eb","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":22},"updated":"2022-01-18 22:34:28.000000000","message":"I think this is unnecessary due to the super call on line 42?","commit_id":"3a1cc6ac7c2c6ce7635742aeef29832cfef0dc04"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3b0524b5e3629aaba52f3d90fa678380b060aadf","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        self.connection.onLoad(self.zk_client)"},{"line_number":52,"context_line":"        self.addCleanup(self._cleanup)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.zk_client \u003d ZooKeeperClient("},{"line_number":55,"context_line":"            self.zk_chroot_fixture.zk_hosts,"},{"line_number":56,"context_line":"            tls_cert\u003dself.zk_chroot_fixture.zookeeper_cert,"},{"line_number":57,"context_line":"            tls_key\u003dself.zk_chroot_fixture.zookeeper_key,"},{"line_number":58,"context_line":"            tls_ca\u003dself.zk_chroot_fixture.zookeeper_ca"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":"        self.addCleanup(self.zk_client.disconnect)"},{"line_number":61,"context_line":"        self.zk_client.connect()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _cleanup(self):"},{"line_number":64,"context_line":"        self.connection.onStop()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce2eac3b_a517b286","line":61,"range":{"start_line":54,"start_character":8,"end_line":61,"end_character":32},"updated":"2022-01-18 22:34:28.000000000","message":"I think this is unnecessary due to the super call on line 42?","commit_id":"3a1cc6ac7c2c6ce7635742aeef29832cfef0dc04"}],"zuul/driver/sql/sqlconnection.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"c94d8e696ae1a168bf4e05901ac0c9df7e524c65","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                with locked("},{"line_number":309,"context_line":"                    SessionAwareLock("},{"line_number":310,"context_line":"                        zk_client.client,"},{"line_number":311,"context_line":"                        f\"{CONNECTION_LOCK_ROOT}/{safe_connection}/migration\")"},{"line_number":312,"context_line":"                ):"},{"line_number":313,"context_line":"                    self._migrate()"},{"line_number":314,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"eed90f99_11f6dc32","line":311,"updated":"2022-01-18 22:39:25.000000000","message":"The database connection is already hard-coded to have a name of \u0027database\u0027.  I don\u0027t think we have to change this here.","commit_id":"3a1cc6ac7c2c6ce7635742aeef29832cfef0dc04"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3b0524b5e3629aaba52f3d90fa678380b060aadf","unresolved":true,"context_lines":[{"line_number":308,"context_line":"                with locked("},{"line_number":309,"context_line":"                    SessionAwareLock("},{"line_number":310,"context_line":"                        zk_client.client,"},{"line_number":311,"context_line":"                        f\"{CONNECTION_LOCK_ROOT}/{safe_connection}/migration\")"},{"line_number":312,"context_line":"                ):"},{"line_number":313,"context_line":"                    self._migrate()"},{"line_number":314,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"89537866_9ebd9b92","line":311,"range":{"start_line":311,"start_character":49,"end_line":311,"end_character":66},"updated":"2022-01-18 22:34:28.000000000","message":"The docs have this listed as \"database\" and is a hard coded value. Can/should we hardcode this here? Or does that have to wait for after the database config clean that will happen in v5?","commit_id":"3a1cc6ac7c2c6ce7635742aeef29832cfef0dc04"}],"zuul/zk/locks.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"478ee67d73de4648c6952cf3d5e6c72c871293aa","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOCK_ROOT \u003d \"/zuul/locks\""},{"line_number":25,"context_line":"TENANT_LOCK_ROOT \u003d f\"{LOCK_ROOT}/tenant\""},{"line_number":26,"context_line":"CONNECTION_LOCK_ROOT \u003d f\"{LOCK_ROOT}/connection\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class SessionAwareMixin:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0d815d0b_ebd021a2","line":26,"updated":"2022-01-18 17:55:11.000000000","message":"We should update the zookeeper map documentation.","commit_id":"68f34c72e20e722a146b88faa84744dc71e6108c"}]}