)]}'
{"zuul/zk/executor.py":[{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"e8ab21c114d8fbca02325f5f4f00594b9cbd3ff0","unresolved":true,"context_lines":[{"line_number":128,"context_line":"                request2 \u003d queue._cached_requests.get(request.path)"},{"line_number":129,"context_line":"                if (request2 and"},{"line_number":130,"context_line":"                    request2.state \u003d\u003d BuildRequest.REQUESTED):"},{"line_number":131,"context_line":"                    found \u003d True"},{"line_number":132,"context_line":"                    yield request2"},{"line_number":133,"context_line":"                if found:"},{"line_number":134,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":2,"id":"fd0047d5_2ca46f7b","line":131,"updated":"2022-03-02 06:42:43.000000000","message":"I\u0027m wondering if we really need to get the request once more or if this could be simplified to:\n\n          for request in self.inState(BuildRequest.REQUESTED):\n              # Make sure the build request wasn\u0027t picked up by another\n              # worker in the meantime.\n              if request.state \u003d\u003d BuildRequest.REQUESTED:\n                  yield request\n\nIIRC the build request is updated in-place, so what we get from the queue should be the same object (request is request2).","commit_id":"7f8342e35bf9c021b1d07efd2a4af3d2101e17e4"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"4073378d35231c51e457b33cd27ba0b83da351f2","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                request2 \u003d queue._cached_requests.get(request.path)"},{"line_number":129,"context_line":"                if (request2 and"},{"line_number":130,"context_line":"                    request2.state \u003d\u003d BuildRequest.REQUESTED):"},{"line_number":131,"context_line":"                    found \u003d True"},{"line_number":132,"context_line":"                    yield request2"},{"line_number":133,"context_line":"                if found:"},{"line_number":134,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":2,"id":"0616821a_6c0461cf","line":131,"updated":"2022-03-02 19:08:09.000000000","message":"This is necessary because they are not updated in place.  I have pointed it out in the other file.","commit_id":"7f8342e35bf9c021b1d07efd2a4af3d2101e17e4"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"4073378d35231c51e457b33cd27ba0b83da351f2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                    request2.state \u003d\u003d BuildRequest.REQUESTED):"},{"line_number":131,"context_line":"                    found \u003d True"},{"line_number":132,"context_line":"                    yield request2"},{"line_number":133,"context_line":"                if found:"},{"line_number":134,"context_line":"                    break"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def submit(self, request, params):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab2c648_74b9a869","line":133,"updated":"2022-03-02 19:08:09.000000000","message":"I think you\u0027re right; this is leftover from an earlier construction.  Even though it\u0027s a nit, I think it\u0027s enough of a readability improvement to warrant a new PS.","commit_id":"7f8342e35bf9c021b1d07efd2a4af3d2101e17e4"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"6d826978ed9d1d17b7dc3e586567bab250f69223","unresolved":true,"context_lines":[{"line_number":130,"context_line":"                    request2.state \u003d\u003d BuildRequest.REQUESTED):"},{"line_number":131,"context_line":"                    found \u003d True"},{"line_number":132,"context_line":"                    yield request2"},{"line_number":133,"context_line":"                if found:"},{"line_number":134,"context_line":"                    break"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def submit(self, request, params):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa56d7f3_842f0286","line":133,"updated":"2022-03-01 17:38:26.000000000","message":"nit: I think this if clause is not necessary. We could just directly break after the yield so we might be able to get rid of the found flag.","commit_id":"7f8342e35bf9c021b1d07efd2a4af3d2101e17e4"}],"zuul/zk/job_request_queue.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"4073378d35231c51e457b33cd27ba0b83da351f2","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            request \u003d self.request_class.fromDict(content)"},{"line_number":144,"context_line":"            request.path \u003d path"},{"line_number":145,"context_line":"            request._zstat \u003d stat"},{"line_number":146,"context_line":"            self._cached_requests[path] \u003d request"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            # NOTE (felix): This is a test-specific condition: For test cases"},{"line_number":149,"context_line":"            # which are using hold_*_jobs_in_queue the state change on the"}],"source_content_type":"text/x-python","patch_set":2,"id":"cdf30334_2a6f676c","line":146,"updated":"2022-03-02 19:08:09.000000000","message":"These 4 lines are why we need the second \u0027get\u0027.","commit_id":"7f8342e35bf9c021b1d07efd2a4af3d2101e17e4"}]}