)]}'
{"tests/unit/test_github_driver.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f388e80c2fd56376128755d6f9a0796a89887797","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        A \u003d self.fake_github.openFakePullRequest("},{"line_number":177,"context_line":"            \u0027org/project\u0027, \u0027master\u0027, \u0027A\u0027, files\u003d{\"moved\": \"test\"})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        with mock.patch(\"tests.fakegithub.FakePull.files\") as files_mock:"},{"line_number":180,"context_line":"            files_mock.return_value \u003d ["},{"line_number":181,"context_line":"                FakeFile(f, previous_filename\u003d\"foobar-requires\")"},{"line_number":182,"context_line":"                for f in A.files]"}],"source_content_type":"text/x-python","patch_set":1,"id":"cb14a352_dcf534ba","line":179,"updated":"2022-03-08 17:37:16.000000000","message":"Instead of using a mock for this, can we adjust the fake pull request to accept FakeFiles as arguments and include a previous file parameter to that?  That way we can more easily include tests like this in the future and we\u0027re keeping the fake functionality together?","commit_id":"c79ac9afd411c8613e00a980352e37e30f4a72dd"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"08344f9fe21f48f69650902b2eb04a914e0b75c5","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        A \u003d self.fake_github.openFakePullRequest("},{"line_number":177,"context_line":"            \u0027org/project\u0027, \u0027master\u0027, \u0027A\u0027, files\u003d{\"moved\": \"test\"})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        with mock.patch(\"tests.fakegithub.FakePull.files\") as files_mock:"},{"line_number":180,"context_line":"            files_mock.return_value \u003d ["},{"line_number":181,"context_line":"                FakeFile(f, previous_filename\u003d\"foobar-requires\")"},{"line_number":182,"context_line":"                for f in A.files]"}],"source_content_type":"text/x-python","patch_set":1,"id":"86fefd3a_47b961c8","line":179,"updated":"2022-03-09 14:35:55.000000000","message":"Yeah -- I think the thing that pushes it over the line for me is thinking about it in terms of wanting our fakes to be good and realistic.  Doing this makes it easy to include this behavior in a future test if we need it.","commit_id":"c79ac9afd411c8613e00a980352e37e30f4a72dd"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"8457b682e7638dafd81de4e4d5aae5b52bbe77ea","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        A \u003d self.fake_github.openFakePullRequest("},{"line_number":177,"context_line":"            \u0027org/project\u0027, \u0027master\u0027, \u0027A\u0027, files\u003d{\"moved\": \"test\"})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        with mock.patch(\"tests.fakegithub.FakePull.files\") as files_mock:"},{"line_number":180,"context_line":"            files_mock.return_value \u003d ["},{"line_number":181,"context_line":"                FakeFile(f, previous_filename\u003d\"foobar-requires\")"},{"line_number":182,"context_line":"                for f in A.files]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1595b585_19e68ff0","line":179,"in_reply_to":"cb14a352_dcf534ba","updated":"2022-03-09 07:18:36.000000000","message":"Done. I thought about this but then convinced myself that this might be overkill for the sake of a single test case :)","commit_id":"c79ac9afd411c8613e00a980352e37e30f4a72dd"}],"zuul/driver/github/githubconnection.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"42ae6547aff92fbdaf2503237611409213df0d6e","unresolved":false,"context_lines":[{"line_number":1725,"context_line":"                for pr_file in probj.files():"},{"line_number":1726,"context_line":"                    files.append(pr_file.filename)"},{"line_number":1727,"context_line":"                    # Also include the old path if a file was renamed."},{"line_number":1728,"context_line":"                    if hasattr(pr_file, \"previous_filename\"):"},{"line_number":1729,"context_line":"                        files.append(pr_file.previous_filename)"},{"line_number":1730,"context_line":"                pr[\u0027files\u0027] \u003d files"},{"line_number":1731,"context_line":"        except github3.exceptions.ServerError as exc:"}],"source_content_type":"text/x-python","patch_set":3,"id":"cf09382e_bfe24c0c","line":1728,"updated":"2022-03-09 14:39:10.000000000","message":"nit: Making the attribute always present and checking for None might help avoid AttributeErrors later.","commit_id":"c3796915332956393c872b89189369b03c7a3dc1"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"6ba9f08e13e1fa19dbf28e2a9925024cf700a7ea","unresolved":false,"context_lines":[{"line_number":1725,"context_line":"                for pr_file in probj.files():"},{"line_number":1726,"context_line":"                    files.append(pr_file.filename)"},{"line_number":1727,"context_line":"                    # Also include the old path if a file was renamed."},{"line_number":1728,"context_line":"                    if hasattr(pr_file, \"previous_filename\"):"},{"line_number":1729,"context_line":"                        files.append(pr_file.previous_filename)"},{"line_number":1730,"context_line":"                pr[\u0027files\u0027] \u003d files"},{"line_number":1731,"context_line":"        except github3.exceptions.ServerError as exc:"}],"source_content_type":"text/x-python","patch_set":3,"id":"669ab58f_0b91b138","line":1728,"in_reply_to":"cf09382e_bfe24c0c","updated":"2022-03-09 15:08:21.000000000","message":"The object returned by github3py only has this attribute if the file was moved.","commit_id":"c3796915332956393c872b89189369b03c7a3dc1"}]}