)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3cea1826373399ddbd9b83791ef5a8ab75bb0e3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb4ca4c8_68ea627e","updated":"2022-05-05 22:24:32.000000000","message":"Overall this seems fine and useful. One small thing inline to clarify things though.","commit_id":"063931583388ed2b0762453a7f70428bbe1b9811"}],"doc/source/developer/specs/global-semaphores.rst":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9b0469da0ed530443e1e97079cd5168100958f1c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"If an in-repo semaphore is defined with the same name as a global"},{"line_number":82,"context_line":"semaphore, that will become a configuration error.  The global"},{"line_number":83,"context_line":"semaphore will take precedence."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Implementation"},{"line_number":86,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8d83b2e7_a93111e8","line":83,"updated":"2022-05-05 22:36:02.000000000","message":"Sorry, I was trying to convey that the in-repo semaphore would cause a configuration error which means that the config object would not be loaded; therefore any jobs that referenced that semaphore name would get the global one.\n\nIn other words, if you start with an in-repo semaphore \"foo\" and use it in jobs, then add a global semaphore \"foo\" then as soon as you do that, you get a config error and also the jobs continue to run but using the global semaphore.","commit_id":"063931583388ed2b0762453a7f70428bbe1b9811"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3cea1826373399ddbd9b83791ef5a8ab75bb0e3f","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"If an in-repo semaphore is defined with the same name as a global"},{"line_number":82,"context_line":"semaphore, that will become a configuration error.  The global"},{"line_number":83,"context_line":"semaphore will take precedence."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Implementation"},{"line_number":86,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c9338404_77a09c6a","line":83,"updated":"2022-05-05 22:24:32.000000000","message":"These two sentences are a bit ambiguous to me. If this is a configuration error then why would one or the other take precedence. It should just fail to exist entirely instead?","commit_id":"063931583388ed2b0762453a7f70428bbe1b9811"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"582111c0f3768c403a7425c02f63d5f524784653","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"If an in-repo semaphore is defined with the same name as a global"},{"line_number":82,"context_line":"semaphore, that will become a configuration error.  The global"},{"line_number":83,"context_line":"semaphore will take precedence."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Implementation"},{"line_number":86,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c7b2f229_62602117","line":83,"in_reply_to":"8d83b2e7_a93111e8","updated":"2022-05-09 20:44:26.000000000","message":"Ya, that makes sense. I guess that means jobs don\u0027t automatically fail but you may have more contention for the semaphore in which case having an error is helpful.","commit_id":"063931583388ed2b0762453a7f70428bbe1b9811"}]}