)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"de04f4e15d51335b72da62b4460b12222d373ed1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e40817b1_1af78b8c","updated":"2022-07-22 16:30:17.000000000","message":"zuul/ansible/2.8/library/command.py and zuul/ansible/5/library/command.py (this second file is a symlink to zuul/ansible/base/library/command.py) both exist as well but this change only modified zuul/ansible/2.9//library/command.py. -1 for this issue.\n\nMaybe we should add loops to the testing and ensure the testing properly cleans up for us?","commit_id":"59e4db60bdd7f4ddde0b2dd83775b19b119dfd24"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"90be360c9c49d3b746aabc07bdb2ff97364c052f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e66c0d5b_92296829","in_reply_to":"e40817b1_1af78b8c","updated":"2022-07-22 21:14:59.000000000","message":"ahh thanks, good catch; yes i missed which ones are symlinked and not\n\nOn testing -- I want to do a full test after https://review.opendev.org/#/q/I823156dc2bcae91bd6d9770bd1520aa55ad875b4 is applied to the opendev zuul executors.\n\ncurrently, the opendev zuul_console leaves behind /tmp/console-* files.  when we have merged and deployed changes to stop that happening, we can simply add a test to the playbook that /tmp is free of console-* files.","commit_id":"59e4db60bdd7f4ddde0b2dd83775b19b119dfd24"}],"zuul/ansible/2.9/library/command.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"de04f4e15d51335b72da62b4460b12222d373ed1","unresolved":true,"context_lines":[{"line_number":174,"context_line":"        # files that will never be read, but also means no other"},{"line_number":175,"context_line":"        # special-casing for any of this path."},{"line_number":176,"context_line":"        if log_uuid \u003d\u003d \u0027in-loop-ignore\u0027:"},{"line_number":177,"context_line":"            self.logfile_name \u003d \u0027/dev/null\u0027"},{"line_number":178,"context_line":"        else:"},{"line_number":179,"context_line":"            self.logfile_name \u003d LOG_STREAM_FILE.format(log_uuid\u003dlog_uuid)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"282e2274_f0714cbc","line":177,"updated":"2022-07-22 16:30:17.000000000","message":"Someone that runs Zuul on windows (and other remotes) will need to chime in, but is this platform independent? I don\u0027t actually know if the console streamer works at all on those platforms. It may be the case that this is already linux/unix specific.","commit_id":"59e4db60bdd7f4ddde0b2dd83775b19b119dfd24"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"21407dcddf6c0ee8c4c45b3ec7a32608d76a5aad","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # files that will never be read, but also means no other"},{"line_number":175,"context_line":"        # special-casing for any of this path."},{"line_number":176,"context_line":"        if log_uuid \u003d\u003d \u0027in-loop-ignore\u0027:"},{"line_number":177,"context_line":"            self.logfile_name \u003d \u0027/dev/null\u0027"},{"line_number":178,"context_line":"        else:"},{"line_number":179,"context_line":"            self.logfile_name \u003d LOG_STREAM_FILE.format(log_uuid\u003dlog_uuid)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"61a46926_16cd7b27","line":177,"in_reply_to":"282e2274_f0714cbc","updated":"2022-07-22 22:30:26.000000000","message":"That disables streaming on a winrm connection, but it doesn\u0027t address streaming to a windows host over an ssh connection.  I don\u0027t know if anyone does that, and I don\u0027t know if it\u0027s possible.  My guess is \"no\" to the first and \"yes if you have a full posix (eg cygwin) environment\" to the second, but I have not researched this.  However, I think the use of os.devnull is good enough for our purposes here.  FWIW, we also assume \"/tmp\" exists and don\u0027t do any special platform handling for that.","commit_id":"59e4db60bdd7f4ddde0b2dd83775b19b119dfd24"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"90be360c9c49d3b746aabc07bdb2ff97364c052f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # files that will never be read, but also means no other"},{"line_number":175,"context_line":"        # special-casing for any of this path."},{"line_number":176,"context_line":"        if log_uuid \u003d\u003d \u0027in-loop-ignore\u0027:"},{"line_number":177,"context_line":"            self.logfile_name \u003d \u0027/dev/null\u0027"},{"line_number":178,"context_line":"        else:"},{"line_number":179,"context_line":"            self.logfile_name \u003d LOG_STREAM_FILE.format(log_uuid\u003dlog_uuid)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4548c83f_78450c56","line":177,"in_reply_to":"282e2274_f0714cbc","updated":"2022-07-22 21:14:59.000000000","message":"zuul_stream.py already exits with no streaming on windows; see\n\nhttps://opendev.org/zuul/zuul/src/branch/master/zuul/ansible/base/callback/zuul_stream.py#L280","commit_id":"59e4db60bdd7f4ddde0b2dd83775b19b119dfd24"}]}