)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1f4795f4527a3772306b3e842806101f40500c68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7ba6b4bd_11a149c0","updated":"2022-09-14 22:19:11.000000000","message":"recheck","commit_id":"c54ccda1283cda500ec2e83be2b8769ce261fd7b"}],"zuul/ansible/base/action/command.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"af572e848c5026149a967ea51381c9f1c2df186b","unresolved":true,"context_lines":[{"line_number":33,"context_line":"            # for situations where they won\u0027t be read and cleaned-up."},{"line_number":34,"context_line":"            skip \u003d boolean("},{"line_number":35,"context_line":"                self._templar.template("},{"line_number":36,"context_line":"                    \"{{zuul_console_disabled|default(false)}}\"))"},{"line_number":37,"context_line":"            if skip:"},{"line_number":38,"context_line":"                self._task.args[\u0027zuul_log_id\u0027] \u003d \u0027skip\u0027"},{"line_number":39,"context_line":"            elif \u0027ansible_loop_var\u0027 in task_vars:"}],"source_content_type":"text/x-python","patch_set":16,"id":"e1e42f69_a8457aa2","line":36,"updated":"2022-09-09 19:00:43.000000000","message":"This seems like overkill when trying to access a variable in an ansible module. But I don\u0027t know of a better way.","commit_id":"8e73c60a2dfaa647657adae24bbf240353dc2dfe"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d471642032a98e0b49ff90cbb62e4a02e3170a15","unresolved":true,"context_lines":[{"line_number":33,"context_line":"            # for situations where they won\u0027t be read and cleaned-up."},{"line_number":34,"context_line":"            skip \u003d boolean("},{"line_number":35,"context_line":"                self._templar.template("},{"line_number":36,"context_line":"                    \"{{zuul_console_disabled|default(false)}}\"))"},{"line_number":37,"context_line":"            if skip:"},{"line_number":38,"context_line":"                self._task.args[\u0027zuul_log_id\u0027] \u003d \u0027skip\u0027"},{"line_number":39,"context_line":"            elif \u0027ansible_loop_var\u0027 in task_vars:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3e575365_1e772d02","line":36,"in_reply_to":"e1e42f69_a8457aa2","updated":"2022-09-13 19:10:16.000000000","message":"Yeah, it was cargo-cult copying from other action plugins I found in the core and collections.  It\u0027s done in a few places.","commit_id":"8e73c60a2dfaa647657adae24bbf240353dc2dfe"}],"zuul/ansible/base/library/command.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"af572e848c5026149a967ea51381c9f1c2df186b","unresolved":true,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    try:"},{"line_number":498,"context_line":"        if self._debug:"},{"line_number":499,"context_line":"            self.log(\u0027Executing %s: \u0027 % (zuul_log_id, self._clean_args(args)))"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        # ZUUL: Replaced the execution loop with the zuul_runner run function"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"19a893b2_e005240d","line":499,"range":{"start_line":499,"start_character":54,"end_line":499,"end_character":76},"updated":"2022-09-09 19:00:43.000000000","message":"This is an extra argument now and there is only one %s in the string. I think this wants to be something like:\n\n  self.log(\u0027Executing %s: %s\u0027 % (zuul_log_id, self._clean_args(args)))\n  \nThough there may be a more efficient way of doing it by having the logging library do the interpolation.","commit_id":"8e73c60a2dfaa647657adae24bbf240353dc2dfe"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d471642032a98e0b49ff90cbb62e4a02e3170a15","unresolved":false,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    try:"},{"line_number":498,"context_line":"        if self._debug:"},{"line_number":499,"context_line":"            self.log(\u0027Executing %s: \u0027 % (zuul_log_id, self._clean_args(args)))"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        # ZUUL: Replaced the execution loop with the zuul_runner run function"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"4747a056_c35eb030","line":499,"range":{"start_line":499,"start_character":54,"end_line":499,"end_character":76},"in_reply_to":"19a893b2_e005240d","updated":"2022-09-13 19:10:16.000000000","message":"Thanks!  I don\u0027t know how to actually get self._debug here set but I just changed that to use arguments.","commit_id":"8e73c60a2dfaa647657adae24bbf240353dc2dfe"}]}