)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10961,"name":"lotorev vitaly","display_name":"Vitaliy Lotorev","email":"lotorev@gmail.com","username":"Vitaliy"},"change_message_id":"069e44b436fa9761b3e22c65f716461ddca775db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2e1fab5c_d164c208","updated":"2022-09-12 23:56:56.000000000","message":"recheck","commit_id":"733bb355b2fc30e80ffa79c332508da95cfacb80"}],"doc/source/drivers/gerrit.rst":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"de7b0ec4e34914f9c703ba22f2a99acc1b28355a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"      the event in question). Approval is a list of dictionaries with"},{"line_number":318,"context_line":"      attributes listed below, all of which are optional and are combined"},{"line_number":319,"context_line":"      together so that there must be an approval matching all"},{"line_number":320,"context_line":"      specified requirements."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"      .. attr:: username"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"07fb96ac_dac83750","line":320,"updated":"2022-09-12 22:05:22.000000000","message":"Technically, it\u0027s a (dict or (list of dicts)).  Many options in Zuul and this driver take this form.  Usually what we do is describe the singleton, and then say \"multiple foos may be listed\".\n\nSo if we keep that pattern here, you could just add \"multiple approvals may be listed\" to the original text.\n\nI\u0027m certainly open to other ways of describing that if it\u0027s not clear, though if we do, I think we should apply it universally (at the very least starting within this document to maintain consistency).\n\nThe main reason I\u0027m adding a -1 here is that while it\u0027s true that the original text did not sufficiently describe the parameters (because it described only one of two possibilities), this change does the same thing but only describes the other possibility.","commit_id":"ae56f17076a4e82cdfe9848fc60da60b7db51a18"},{"author":{"_account_id":10961,"name":"lotorev vitaly","display_name":"Vitaliy Lotorev","email":"lotorev@gmail.com","username":"Vitaliy"},"change_message_id":"9151178ec8bc0542173631c00c523adfd81a4cbf","unresolved":true,"context_lines":[{"line_number":317,"context_line":"      the event in question). Approval is a list of dictionaries with"},{"line_number":318,"context_line":"      attributes listed below, all of which are optional and are combined"},{"line_number":319,"context_line":"      together so that there must be an approval matching all"},{"line_number":320,"context_line":"      specified requirements."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"      .. attr:: username"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"f07ed758_6943547f","line":320,"in_reply_to":"07fb96ac_dac83750","updated":"2022-09-12 22:41:32.000000000","message":"\u003e The main reason I\u0027m adding a -1 here is that while it\u0027s true that the original text did not sufficiently describe the parameters (because it described only one of two possibilities), this change does the same thing but only describes the other possibility.\n\nDocumentation before this change is confusing because it contradicts to all other examples in the same document (search for \u0027approval:\u0027 on rendered HTML https://zuul-ci.org/docs/zuul/latest/drivers/gerrit.html#reference-pipelines-configuration) - all examples use \u0027list of dicts\u0027.\n\nMy second move was to check pipeline configs in zuul tests https://opendev.org/zuul/zuul/src/branch/master/tests/fixtures/config/requirements and I failed to find pipeline yaml fixture with bare dict \u0027approval\u0027.\n\nI\u0027ve modified the text to mention both (dict or list-of-dicts) cases.","commit_id":"ae56f17076a4e82cdfe9848fc60da60b7db51a18"}]}