)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2952b25e18745fcbd0510037facbc57708d13881","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b762c2e8_ea613315","updated":"2023-04-10 17:24:42.000000000","message":"Minor things inline.","commit_id":"430416993f63fc8024ea92b39fe5751738efa008"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"c92d8f2f5cc898ea6d0f13e1fba02a6350f79ca8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8e2815a8_9d098fde","updated":"2023-04-11 08:19:22.000000000","message":"recheck","commit_id":"70077ee6d5ab254c02294a6d0f6c6f518d16d96a"}],"playbooks/zuul-stream/fixtures/test-stream.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2952b25e18745fcbd0510037facbc57708d13881","unresolved":true,"context_lines":[{"line_number":6,"context_line":"  vars:"},{"line_number":7,"context_line":"    zuul_console_disabled: true"},{"line_number":8,"context_line":"  hosts: node"},{"line_number":9,"context_line":"  when: new_console | default(false)"},{"line_number":10,"context_line":"  tasks:"},{"line_number":11,"context_line":"    - name: Run quiet command"},{"line_number":12,"context_line":"      command: echo \u0027This command should not stream\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"64651b2e_da76aae1","line":9,"updated":"2023-04-10 17:24:42.000000000","message":"Is this condition necessary? Seems like we can run it unconditionally to see if we connect. I Guess it might be confusing with the current command echo content if that string shows up in the normal test infrastructure streamer though.","commit_id":"430416993f63fc8024ea92b39fe5751738efa008"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"bfcdf54d81669de795d3250511e0b0f42b41f630","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  vars:"},{"line_number":7,"context_line":"    zuul_console_disabled: true"},{"line_number":8,"context_line":"  hosts: node"},{"line_number":9,"context_line":"  when: new_console | default(false)"},{"line_number":10,"context_line":"  tasks:"},{"line_number":11,"context_line":"    - name: Run quiet command"},{"line_number":12,"context_line":"      command: echo \u0027This command should not stream\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ef68e8fd_e1ca0ad9","line":9,"in_reply_to":"64651b2e_da76aae1","updated":"2023-04-10 17:53:12.000000000","message":"I elected to do this rather than add a comment saying \"This test is useless but harmless on the non-new_console code path\".  If folks prefer that instead, I can switch it.","commit_id":"430416993f63fc8024ea92b39fe5751738efa008"}],"playbooks/zuul-stream/validate.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2952b25e18745fcbd0510037facbc57708d13881","unresolved":true,"context_lines":[{"line_number":31,"context_line":"- name: Validate output - no waiting on logger"},{"line_number":32,"context_line":"  shell: |"},{"line_number":33,"context_line":"    egrep -v \"Waiting on logger\" {{ item.filename }}"},{"line_number":34,"context_line":"    egrep -v \"Log Stream did not terminate\" {{ item.filename }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f53d8ea8_79a71336","line":34,"updated":"2023-04-10 17:24:42.000000000","message":"Should we also check that the unwanted string, \"This command should not stream\", doesn\u0027t show up in the file?","commit_id":"430416993f63fc8024ea92b39fe5751738efa008"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"bfcdf54d81669de795d3250511e0b0f42b41f630","unresolved":false,"context_lines":[{"line_number":31,"context_line":"- name: Validate output - no waiting on logger"},{"line_number":32,"context_line":"  shell: |"},{"line_number":33,"context_line":"    egrep -v \"Waiting on logger\" {{ item.filename }}"},{"line_number":34,"context_line":"    egrep -v \"Log Stream did not terminate\" {{ item.filename }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6f5aa1bc_f5430b70","line":34,"in_reply_to":"f53d8ea8_79a71336","updated":"2023-04-10 17:53:12.000000000","message":"I believe the original functonality (not logging anything) is validated elsewhere.  I only wanted to add checks for the new functionality.","commit_id":"430416993f63fc8024ea92b39fe5751738efa008"}],"zuul/ansible/base/callback/zuul_stream.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2952b25e18745fcbd0510037facbc57708d13881","unresolved":true,"context_lines":[{"line_number":333,"context_line":"                if (ip in (\u0027localhost\u0027, \u0027127.0.0.1\u0027)):"},{"line_number":334,"context_line":"                    # Don\u0027t try to stream from localhost"},{"line_number":335,"context_line":"                    continue"},{"line_number":336,"context_line":"                if play_vars[host].get(\u0027zuul_console_disabled\u0027):"},{"line_number":337,"context_line":"                    # The user has told us not to even try"},{"line_number":338,"context_line":"                    continue"},{"line_number":339,"context_line":"                if play_vars[host].get(\u0027ansible_connection\u0027) in (\u0027winrm\u0027,):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fb53e000_7c0ca9e7","line":336,"updated":"2023-04-10 17:24:42.000000000","message":"Do we need to coerce this value to a boolean type? For example zuul_console_disabled: False would be the string \u0027False\u0027 which evaluates to true.","commit_id":"430416993f63fc8024ea92b39fe5751738efa008"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"bfcdf54d81669de795d3250511e0b0f42b41f630","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                if (ip in (\u0027localhost\u0027, \u0027127.0.0.1\u0027)):"},{"line_number":334,"context_line":"                    # Don\u0027t try to stream from localhost"},{"line_number":335,"context_line":"                    continue"},{"line_number":336,"context_line":"                if play_vars[host].get(\u0027zuul_console_disabled\u0027):"},{"line_number":337,"context_line":"                    # The user has told us not to even try"},{"line_number":338,"context_line":"                    continue"},{"line_number":339,"context_line":"                if play_vars[host].get(\u0027ansible_connection\u0027) in (\u0027winrm\u0027,):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2ca72617_7e51df19","line":336,"in_reply_to":"fb53e000_7c0ca9e7","updated":"2023-04-10 17:53:12.000000000","message":"Can do.","commit_id":"430416993f63fc8024ea92b39fe5751738efa008"}]}