)]}'
{"zuul/model.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2e90cd5ac546c2a5f28f65d8b0477fc407bb4e6f","unresolved":true,"context_lines":[{"line_number":264,"context_line":"        }"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    @classmethod"},{"line_number":267,"context_line":"    def deserialize(cls, data):"},{"line_number":268,"context_line":"        data[\"key\"] \u003d ConfigurationErrorKey.deserialize(data[\"key\"])"},{"line_number":269,"context_line":"        o \u003d cls.__new__(cls)"},{"line_number":270,"context_line":"        o.__dict__.update(data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"387b3c8f_1aa5b0c0","line":267,"updated":"2023-05-25 16:42:28.000000000","message":"This class is not a ZkObject and yet we have a deserialize method. Do we need to do any model versioning to handle this? My suspicion is that this object is not directly serialized and deserialized to Zk but that other Zk objects include them which calls these methods.\n\nBecause we use class.__new__(cls) and __dict__.update(data) I think it is possible that we will initialize new ConfigurationError objects from old data with no severity or name set. We don\u0027t call __init__ which would default those values. We can probably avoid a model version if we simply initialize those values here?","commit_id":"7dbe4ba214f6a065a6e6032d3ca4c58efc7a1e0b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"03706e5a574c5a64342bba0f777edb329540f273","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        }"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    @classmethod"},{"line_number":267,"context_line":"    def deserialize(cls, data):"},{"line_number":268,"context_line":"        data[\"key\"] \u003d ConfigurationErrorKey.deserialize(data[\"key\"])"},{"line_number":269,"context_line":"        o \u003d cls.__new__(cls)"},{"line_number":270,"context_line":"        o.__dict__.update(data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6415892_197b1f82","line":267,"in_reply_to":"387b3c8f_1aa5b0c0","updated":"2023-05-25 22:40:00.000000000","message":"Done","commit_id":"7dbe4ba214f6a065a6e6032d3ca4c58efc7a1e0b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"03706e5a574c5a64342bba0f777edb329540f273","unresolved":true,"context_lines":[{"line_number":272,"context_line":"    @classmethod"},{"line_number":273,"context_line":"    def deserialize(cls, data):"},{"line_number":274,"context_line":"        data[\"key\"] \u003d ConfigurationErrorKey.deserialize(data[\"key\"])"},{"line_number":275,"context_line":"        # These attributes were added in MODEL_API 14"},{"line_number":276,"context_line":"        data[\u0027severity\u0027] \u003d data.get(\u0027severity\u0027, SEVERITY_ERROR)"},{"line_number":277,"context_line":"        data[\u0027name\u0027] \u003d data.get(\u0027name\u0027, \u0027Unknown\u0027)"},{"line_number":278,"context_line":"        o \u003d cls.__new__(cls)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b831184_4c001c53","line":275,"updated":"2023-05-25 22:40:00.000000000","message":"I don\u0027t see an update to the model_api file in this change to bump it to 14. Did you decide that wasn\u0027t necessary? Or maybe forgot a git add?","commit_id":"cef33b29b6d0b686b6c0a8c47f912641490ac290"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"aae1860b0628e7e1679196b3ecdc5503bf2a8ead","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    @classmethod"},{"line_number":273,"context_line":"    def deserialize(cls, data):"},{"line_number":274,"context_line":"        data[\"key\"] \u003d ConfigurationErrorKey.deserialize(data[\"key\"])"},{"line_number":275,"context_line":"        # These attributes were added in MODEL_API 14"},{"line_number":276,"context_line":"        data[\u0027severity\u0027] \u003d data.get(\u0027severity\u0027, SEVERITY_ERROR)"},{"line_number":277,"context_line":"        data[\u0027name\u0027] \u003d data.get(\u0027name\u0027, \u0027Unknown\u0027)"},{"line_number":278,"context_line":"        o \u003d cls.__new__(cls)"}],"source_content_type":"text/x-python","patch_set":3,"id":"141699a1_a36bc3f4","line":275,"in_reply_to":"1b831184_4c001c53","updated":"2023-05-25 22:43:19.000000000","message":"Done","commit_id":"cef33b29b6d0b686b6c0a8c47f912641490ac290"}]}