)]}'
{"zuul/model.py":[{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"39df40a6bb052d2abfbf0dd168bf2640d51443b0","unresolved":true,"context_lines":[{"line_number":5486,"context_line":"        if len([i for i in self.bundle.items if i.live]) \u003e 1:"},{"line_number":5487,"context_line":"            # We are in a queue that has multiple live items, so we"},{"line_number":5488,"context_line":"            # will only check our own bundle."},{"line_number":5489,"context_line":"            return [self.bundle]"},{"line_number":5490,"context_line":""},{"line_number":5491,"context_line":"        ret \u003d []"},{"line_number":5492,"context_line":"        for item in self.queue.pipeline.getAllItems():"}],"source_content_type":"text/x-python","patch_set":1,"id":"d0eac414_e0d4ad96","line":5489,"updated":"2023-09-08 09:36:58.000000000","message":"Shouldn\u0027t we rather return an empty list here? I wouldn\u0027t consider the current bundle to be a duplicate and this method now behaves differently depending on the pipeline type (in dependent pipelines it\u0027s a list with only the current bundle and in independent pipelines it is a list of other bundles **excluding** the current bundle).\n\nThe other option might be to rename this method and always return also the current bundle.","commit_id":"742669ab09399e39c2563bda80317d53724cf7ce"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"4b30f30f7c9e16d96ff887121768694d1aa45b63","unresolved":false,"context_lines":[{"line_number":5486,"context_line":"        if len([i for i in self.bundle.items if i.live]) \u003e 1:"},{"line_number":5487,"context_line":"            # We are in a queue that has multiple live items, so we"},{"line_number":5488,"context_line":"            # will only check our own bundle."},{"line_number":5489,"context_line":"            return [self.bundle]"},{"line_number":5490,"context_line":""},{"line_number":5491,"context_line":"        ret \u003d []"},{"line_number":5492,"context_line":"        for item in self.queue.pipeline.getAllItems():"}],"source_content_type":"text/x-python","patch_set":1,"id":"867d4a50_23d7a267","line":5489,"in_reply_to":"abcd9aac_004a6cf8","updated":"2023-09-12 11:56:49.000000000","message":"Name of the method aside I\u0027m wondering if we could at least keep the behavior the same and return `self.bundle` with the list of other related bundles for non-dependent pipelines. In the changes to the manager\u0027s `_getItemsWithBuild()` we are currently explicitly adding our own builds, so that could even be removed. But maybe there would be problems in `findDuplicateJob()` due to that change.\n\nChanging my vote to a +2 since this is not a hill to die on.","commit_id":"742669ab09399e39c2563bda80317d53724cf7ce"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"109b80125456ec4cacec02a6c21db03b4a99ad77","unresolved":false,"context_lines":[{"line_number":5486,"context_line":"        if len([i for i in self.bundle.items if i.live]) \u003e 1:"},{"line_number":5487,"context_line":"            # We are in a queue that has multiple live items, so we"},{"line_number":5488,"context_line":"            # will only check our own bundle."},{"line_number":5489,"context_line":"            return [self.bundle]"},{"line_number":5490,"context_line":""},{"line_number":5491,"context_line":"        ret \u003d []"},{"line_number":5492,"context_line":"        for item in self.queue.pipeline.getAllItems():"}],"source_content_type":"text/x-python","patch_set":1,"id":"abcd9aac_004a6cf8","line":5489,"in_reply_to":"d0eac414_e0d4ad96","updated":"2023-09-08 14:52:42.000000000","message":"Didn\u0027t mean to resolve.","commit_id":"742669ab09399e39c2563bda80317d53724cf7ce"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"08d6aa8bd38555b7af968d3548c736b5aafdc62a","unresolved":false,"context_lines":[{"line_number":5486,"context_line":"        if len([i for i in self.bundle.items if i.live]) \u003e 1:"},{"line_number":5487,"context_line":"            # We are in a queue that has multiple live items, so we"},{"line_number":5488,"context_line":"            # will only check our own bundle."},{"line_number":5489,"context_line":"            return [self.bundle]"},{"line_number":5490,"context_line":""},{"line_number":5491,"context_line":"        ret \u003d []"},{"line_number":5492,"context_line":"        for item in self.queue.pipeline.getAllItems():"}],"source_content_type":"text/x-python","patch_set":1,"id":"7fea6dd8_1612ffc5","line":5489,"in_reply_to":"d0eac414_e0d4ad96","updated":"2023-09-08 14:52:08.000000000","message":"The intention is to replace lines 5647--5653 which always need this.  Since we\u0027re using this in more places, all the call sites would need those lines as well, so I moved it into the method.\n\nI agree the name is slightly misleading, but I\u0027d rather keep it because it shows up when I search for duplicate.  There\u0027s a nice symmetry to findDuplicate(Job|Bundle).\n\nMaybe findIdenticalBundles and findIdenticalJobs would be better (depending on one\u0027s understanding of the identity property)?\n\nFor me though, it doesn\u0027t seem like much of an improvement.  We do have a comment explaining the weird behavior.","commit_id":"742669ab09399e39c2563bda80317d53724cf7ce"}]}