)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f379e5e5f735edc4bf0c6a5ca46a794cd426f3ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f86e5b4_0cf212b6","updated":"2024-02-02 23:55:30.000000000","message":"In addition to the two minor inline things I think it would also be good to have some minimum padding between the build status graph (the bar with green and blue and orange and red summary status on the card) and the elapsted time timestamp. When elapsed time and remaining time are large enough the graph and timestamp are immediately adjacent to one another.","commit_id":"32eefd8faeab279d0aaf5f939d4fbb3c6d5efb75"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"4afdf24a81a9c9acd65eae0bd7ae469ec54e5ed0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"33958e87_cee87294","updated":"2024-02-07 19:22:08.000000000","message":"The site-preview looks great on both deployment, thanks!","commit_id":"4a7e86f7f66c429f67085cd9e9e16097cf6a2842"}],"web/src/containers/status/ChangeQueue.jsx":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f379e5e5f735edc4bf0c6a5ca46a794cd426f3ed","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      shortName \u003d shortName.substr(0, 32) + \u0027...\u0027"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":"    let changesList \u003d []"},{"line_number":41,"context_line":"    queue.heads.forEach((items, changeIdx) \u003d\u003e {"},{"line_number":42,"context_line":"      items.forEach((item, idx) \u003d\u003e {"},{"line_number":43,"context_line":"        changesList.push("},{"line_number":44,"context_line":"          \u003cItem"}],"source_content_type":"text/jsx","patch_set":3,"id":"22dd9a26_ec35c6ae","line":41,"range":{"start_line":41,"start_character":31,"end_line":41,"end_character":38},"updated":"2024-02-02 23:55:30.000000000","message":"Nit should this be itemIdx now that we are iterating over items not changes?","commit_id":"32eefd8faeab279d0aaf5f939d4fbb3c6d5efb75"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1330aacce9d5b5d16d0eea50a22c6efe21d2182d","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      shortName \u003d shortName.substr(0, 32) + \u0027...\u0027"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":"    let changesList \u003d []"},{"line_number":41,"context_line":"    queue.heads.forEach((items, changeIdx) \u003d\u003e {"},{"line_number":42,"context_line":"      items.forEach((item, idx) \u003d\u003e {"},{"line_number":43,"context_line":"        changesList.push("},{"line_number":44,"context_line":"          \u003cItem"}],"source_content_type":"text/jsx","patch_set":3,"id":"fcc8ee91_718af431","line":41,"in_reply_to":"22dd9a26_ec35c6ae","updated":"2024-02-03 01:04:06.000000000","message":"yep, whoops.","commit_id":"32eefd8faeab279d0aaf5f939d4fbb3c6d5efb75"}],"web/src/containers/status/Item.jsx":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f379e5e5f735edc4bf0c6a5ca46a794cd426f3ed","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        icon\u003d{\u003cBanIcon style\u003d{{"},{"line_number":178,"context_line":"          color: \u0027var(--pf-global--danger-color--100)\u0027,"},{"line_number":179,"context_line":"        }} /\u003e}"},{"line_number":180,"context_line":"        description\u003d\"Stop all jobs for this item\""},{"line_number":181,"context_line":"        onClick\u003d{(event) \u003d\u003e {"},{"line_number":182,"context_line":"          event.preventDefault()"},{"line_number":183,"context_line":"          this.setState(() \u003d\u003e ({ showDequeueModal: true }))"}],"source_content_type":"text/jsx","patch_set":3,"id":"fa150fa1_08323e65","line":180,"updated":"2024-02-02 23:55:30.000000000","message":"Thinking out loud here: \"item\" might be a bit of our internal terminology leaking to what users will see. For admin commands I don\u0027t think that is a big deal though. But I do wonder if keeping this as change or some other term might make sense in user facing contexts.","commit_id":"32eefd8faeab279d0aaf5f939d4fbb3c6d5efb75"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1330aacce9d5b5d16d0eea50a22c6efe21d2182d","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        icon\u003d{\u003cBanIcon style\u003d{{"},{"line_number":178,"context_line":"          color: \u0027var(--pf-global--danger-color--100)\u0027,"},{"line_number":179,"context_line":"        }} /\u003e}"},{"line_number":180,"context_line":"        description\u003d\"Stop all jobs for this item\""},{"line_number":181,"context_line":"        onClick\u003d{(event) \u003d\u003e {"},{"line_number":182,"context_line":"          event.preventDefault()"},{"line_number":183,"context_line":"          this.setState(() \u003d\u003e ({ showDequeueModal: true }))"}],"source_content_type":"text/jsx","patch_set":3,"id":"45086f21_e104a71d","line":180,"in_reply_to":"fa150fa1_08323e65","updated":"2024-02-03 01:04:06.000000000","message":"I\u0027ve kept a lot of user facing terminology as \"change\" and we could probably leave this as change; but i think now that items can be more than one change we might need to start calling them \"items\" or \"queue items\" in the ui.","commit_id":"32eefd8faeab279d0aaf5f939d4fbb3c6d5efb75"}],"web/src/index.css":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"db1f441c0978dc4a90faabfc3ca86754f9d95a00","unresolved":true,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":".zuul-change-total-result {"},{"line_number":211,"context_line":"    height: 10px;"},{"line_number":212,"context_line":"    width: 200px;"},{"line_number":213,"context_line":"    margin: 0;"},{"line_number":214,"context_line":"    display: inline-block;"},{"line_number":215,"context_line":"    vertical-align: middle;"}],"source_content_type":"text/css","patch_set":3,"id":"83f368dc_02e6ff92","line":212,"updated":"2024-02-03 00:00:27.000000000","message":"On closer inspecting I think this width increase is why we lack space between the timestamp and progress bar is both timestamps are wide enough. Maybe decrease to 180 so that we get bigger bars but more room adjacent to the timestamp?","commit_id":"32eefd8faeab279d0aaf5f939d4fbb3c6d5efb75"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7b9adb7d63ca262a06a8d00516f11a25aacd2faa","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":".zuul-change-total-result {"},{"line_number":211,"context_line":"    height: 10px;"},{"line_number":212,"context_line":"    width: 200px;"},{"line_number":213,"context_line":"    margin: 0;"},{"line_number":214,"context_line":"    display: inline-block;"},{"line_number":215,"context_line":"    vertical-align: middle;"}],"source_content_type":"text/css","patch_set":3,"id":"4d5ce60e_3a50e2eb","line":212,"in_reply_to":"73ee47ae_9680301d","updated":"2024-02-07 16:38:35.000000000","message":"This looks much better now with timestamp values like `1 hr 24 min | 1 hr 25 min`","commit_id":"32eefd8faeab279d0aaf5f939d4fbb3c6d5efb75"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1330aacce9d5b5d16d0eea50a22c6efe21d2182d","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":".zuul-change-total-result {"},{"line_number":211,"context_line":"    height: 10px;"},{"line_number":212,"context_line":"    width: 200px;"},{"line_number":213,"context_line":"    margin: 0;"},{"line_number":214,"context_line":"    display: inline-block;"},{"line_number":215,"context_line":"    vertical-align: middle;"}],"source_content_type":"text/css","patch_set":3,"id":"73ee47ae_9680301d","line":212,"in_reply_to":"83f368dc_02e6ff92","updated":"2024-02-03 01:04:06.000000000","message":"Yep; I thought I got some good examples from opendev (like multi-hour jobs, etc) and found the padding sufficient, but if not, shrinking 20px sounds good.  100 is definitely too small though.","commit_id":"32eefd8faeab279d0aaf5f939d4fbb3c6d5efb75"}]}