)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"52497538a3baea3bbb9acccbb3d11f5a40080d9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"f6ad1459_76172553","updated":"2024-09-09 05:25:06.000000000","message":"recheck","commit_id":"bf197f52fc897770d89b9fb48e190ce7b362e861"}],"web/src/pages/PipelineOverview.jsx":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"78f443fba0eaafcc8e090310ef1f7264070e476d","unresolved":true,"context_lines":[{"line_number":150,"context_line":"    pipelines \u003d state.status.status.pipelines.map(ppl \u003d\u003e ("},{"line_number":151,"context_line":"      { ...ppl, _count: countItems(ppl) }"},{"line_number":152,"context_line":"    )).sort((a, b) \u003d\u003e sortPipelines(a, b)).filter(ppl \u003d\u003e ppl._count \u003e 0)"},{"line_number":153,"context_line":"    stats \u003d {"},{"line_number":154,"context_line":"      trigger_event_queue: state.status.status.trigger_event_queue,"},{"line_number":155,"context_line":"      management_event_queue: state.status.status.management_event_queue,"},{"line_number":156,"context_line":"    }"}],"source_content_type":"text/jsx","patch_set":5,"id":"be227a3b_72c040c0","line":153,"updated":"2024-05-02 19:20:09.000000000","message":"Why not declaring the variable here, e.g. `const stats \u003d {` ?","commit_id":"05a181463df11b3f8eaa432d3bc0a5e8897ba1af"},{"author":{"_account_id":27952,"name":"Felix Edel","email":"felix.edel@bmw.de","username":"felix.schmidt"},"change_message_id":"f41abde5e1df7625201cd75ed18928e281b2b8c0","unresolved":true,"context_lines":[{"line_number":150,"context_line":"    pipelines \u003d state.status.status.pipelines.map(ppl \u003d\u003e ("},{"line_number":151,"context_line":"      { ...ppl, _count: countItems(ppl) }"},{"line_number":152,"context_line":"    )).sort((a, b) \u003d\u003e sortPipelines(a, b)).filter(ppl \u003d\u003e ppl._count \u003e 0)"},{"line_number":153,"context_line":"    stats \u003d {"},{"line_number":154,"context_line":"      trigger_event_queue: state.status.status.trigger_event_queue,"},{"line_number":155,"context_line":"      management_event_queue: state.status.status.management_event_queue,"},{"line_number":156,"context_line":"    }"}],"source_content_type":"text/jsx","patch_set":5,"id":"c0090c7c_a1d3b8c0","line":153,"in_reply_to":"be227a3b_72c040c0","updated":"2024-05-07 13:01:30.000000000","message":"Because the return statement (where the stats variable is used) is outside of the if condition. The same with pipelines. If we define those variables within the if condition they would be out-of-scope for the return statement (or undefined in case the if-condition is not fulfilled - depending on how JS deals with that).","commit_id":"05a181463df11b3f8eaa432d3bc0a5e8897ba1af"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"bf9cf4bc38bedee6147e6a48d2db90b7c5a3494b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    pipelines \u003d state.status.status.pipelines.map(ppl \u003d\u003e ("},{"line_number":151,"context_line":"      { ...ppl, _count: countItems(ppl) }"},{"line_number":152,"context_line":"    )).sort((a, b) \u003d\u003e sortPipelines(a, b)).filter(ppl \u003d\u003e ppl._count \u003e 0)"},{"line_number":153,"context_line":"    stats \u003d {"},{"line_number":154,"context_line":"      trigger_event_queue: state.status.status.trigger_event_queue,"},{"line_number":155,"context_line":"      management_event_queue: state.status.status.management_event_queue,"},{"line_number":156,"context_line":"    }"}],"source_content_type":"text/jsx","patch_set":5,"id":"4107c21c_b998fb0c","line":153,"in_reply_to":"c0090c7c_a1d3b8c0","updated":"2024-09-11 19:48:56.000000000","message":"Acknowledged","commit_id":"05a181463df11b3f8eaa432d3bc0a5e8897ba1af"}]}
