)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"b46cffad7b8e8ba90ee2078855a4d08db4885a7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b5efe89d_14e91918","updated":"2024-06-14 07:09:58.000000000","message":"recheck","commit_id":"09525bb0ee312ff25e58175dfc0d864e820c3923"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"36e758aef04aa141e431d4083155aa803b02f873","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5ec7cf5c_0ff67920","updated":"2024-06-27 06:24:17.000000000","message":"recheck","commit_id":"e2513fdfe66a82ebfbcd169f09031b0ffb507546"}],"tests/unit/test_component_registry.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"54c66fd006a53d8c325741f1ee05e92889727bce","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                self.upstream_root, self.poller_events,"},{"line_number":143,"context_line":"                self.git_url_with_auth, self.addCleanup, self.test_root"},{"line_number":144,"context_line":"            )"},{"line_number":145,"context_line":"        )"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.assertComponentState(\"launcher\", BaseComponent.RUNNING)"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fe0aa4e6_e670fdb5","line":145,"updated":"2024-06-13 21:52:43.000000000","message":"You don\u0027t actually need to run the zuul web fixture in order to verify the launcher is running.","commit_id":"a7123df3860e1128e8afe534e4ca7e1751d141f1"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"ba07a2af2321663ee5479c1dec1fba7bd7d9481c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                self.upstream_root, self.poller_events,"},{"line_number":143,"context_line":"                self.git_url_with_auth, self.addCleanup, self.test_root"},{"line_number":144,"context_line":"            )"},{"line_number":145,"context_line":"        )"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.assertComponentState(\"launcher\", BaseComponent.RUNNING)"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"e4562e19_2abbb647","line":145,"in_reply_to":"fe0aa4e6_e670fdb5","updated":"2024-06-14 05:17:22.000000000","message":"Fixed","commit_id":"a7123df3860e1128e8afe534e4ca7e1751d141f1"}],"zuul/launcher/server.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"bc3b450fd09081d74677a4ff5d7d4b8dba49cba7","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class Launcher:"},{"line_number":32,"context_line":"    WATERMARK_SLEEP \u003d 1"},{"line_number":33,"context_line":"    log \u003d logging.getLogger(\"zuul.Launcher\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, config):"}],"source_content_type":"text/x-python","patch_set":10,"id":"997daf43_e24cd0b9","line":32,"updated":"2024-06-27 20:16:09.000000000","message":"I\u0027d like to get rid of the watermark idea.\n\nIn nodepool because the idea was that nodepool would wake up periodically and see if it needed to add or remove nodes from the pool to maintain the same level of ready nodes.\n\nI think mostly what we\u0027re going to want in the zuul launcher is a behavior like most of the zuul components where we wake whenever there\u0027s a new request.\n\nI\u0027m not sure how we should handle min-ready and missing image builds yet, but if we can\u0027t handle them via event triggers, then we can probably just set up some apscheduler crons for them.\n\nSo at this point, we can probably just call wake_event.wait() without a delay, right?","commit_id":"e2513fdfe66a82ebfbcd169f09031b0ffb507546"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"4e38616d134a30327572d9f676d4ca245b25cf08","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class Launcher:"},{"line_number":32,"context_line":"    WATERMARK_SLEEP \u003d 1"},{"line_number":33,"context_line":"    log \u003d logging.getLogger(\"zuul.Launcher\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, config):"}],"source_content_type":"text/x-python","patch_set":10,"id":"37eeb1f4_e37d08df","line":32,"in_reply_to":"997daf43_e24cd0b9","updated":"2024-06-28 06:14:04.000000000","message":"Yep, that makes sense. I don\u0027t see why we would need that.","commit_id":"e2513fdfe66a82ebfbcd169f09031b0ffb507546"}]}