)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a1f9e1fb2cee110f3a1917d939f60bee328a49a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bd36b495_b8405761","updated":"2025-03-25 16:52:29.000000000","message":"Don\u0027t need to rerun tests on this anymore. Mordred dug up the upstream issue which has since been fixed (but not in distro packages): https://jira.mariadb.org/browse/MDEV-35663\n\nMy change to drop flush privileges is correct for us and we don\u0027t need newer mariadb.","commit_id":"101dd1bfc4bd552c03e7426d5d7e0dba1a78febc"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f99ef08a6e8e885550c51815c56b92f7ee54ceb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5858c149_b136698b","updated":"2025-03-25 01:52:32.000000000","message":"recheck gather more data","commit_id":"101dd1bfc4bd552c03e7426d5d7e0dba1a78febc"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e24c6d97d829294d33d2161517a7854ea1b8ba11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8f393633_17f3fddd","updated":"2025-03-25 14:46:51.000000000","message":"recheck gather more data","commit_id":"101dd1bfc4bd552c03e7426d5d7e0dba1a78febc"}],"tests/base.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"207efed700fab2ce9d69fca6c23c9e7ff9bb19e4","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"            with db.cursor() as cur:"},{"line_number":1752,"context_line":"                cur.execute(\"drop database %s\" % self.name)"},{"line_number":1753,"context_line":"                cur.execute(\"drop user \u0027%s\u0027@\u0027\u0027\" % self.name)"},{"line_number":1754,"context_line":"                cur.execute(\"flush privileges\")"},{"line_number":1755,"context_line":"        except:"},{"line_number":1756,"context_line":"            self.log.exception(\"Double check connection details %s:%s:%s\","},{"line_number":1757,"context_line":"                               self.host, self.port, self.name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"0a564597_1fb9c737","line":1754,"updated":"2025-03-24 20:45:43.000000000","message":"there is a flush here you shoudn\u0027t need","commit_id":"95647463c96cff64e32a52205ab0c0fc236be434"}],"tools/test-setup.sh":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"41dd45667cc4af09b7310155e305d84ed3dae9fa","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# a anonymous user exists, then it matches first for connections and"},{"line_number":33,"context_line":"# other connections from that host will not work."},{"line_number":34,"context_line":"sudo -H mysql -u root -p$DB_ROOT_PW -h localhost -e \""},{"line_number":35,"context_line":"    DELETE FROM mysql.user WHERE User\u003d\u0027\u0027;"},{"line_number":36,"context_line":"    FLUSH PRIVILEGES;"},{"line_number":37,"context_line":"    CREATE USER \u0027$DB_USER\u0027@\u0027%\u0027 IDENTIFIED BY \u0027$DB_PW\u0027;"},{"line_number":38,"context_line":"    GRANT ALL PRIVILEGES ON *.* TO \u0027$DB_USER\u0027@\u0027%\u0027 WITH GRANT OPTION;\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"bd04ef5b_21a6c776","line":35,"updated":"2025-03-24 20:33:24.000000000","message":"FWIW - this isn\u0027t even how you do this for mariadb. Their command from mariadb-secure-installation is:\n\n DELETE FROM mysql.global_priv WHERE User\u003d\u0027\u0027;\n \nSo this may not even be doing anything. If it\u0027s not, then you could remove both this and the next line and get rid of the flush privs thing in the first place.","commit_id":"95647463c96cff64e32a52205ab0c0fc236be434"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"41dd45667cc4af09b7310155e305d84ed3dae9fa","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Now create our database."},{"line_number":41,"context_line":"mysql -u $DB_USER -p$DB_PW -h 127.0.0.1 -e \""},{"line_number":42,"context_line":"    SET default_storage_engine\u003dMYISAM;"},{"line_number":43,"context_line":"    DROP DATABASE IF EXISTS openstack_citest;"},{"line_number":44,"context_line":"    CREATE DATABASE openstack_citest CHARACTER SET utf8;\""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"79759fbe_1a0fcfb3","line":42,"updated":"2025-03-24 20:33:24.000000000","message":"Out of curiosity - why are we setting default_storage_engine to MYISAM? Are we doing it to later catch instances where DDL isn\u0027t correctly being explicit about InnoDB? It\u0027s weird - so it seems comment-worthy.","commit_id":"95647463c96cff64e32a52205ab0c0fc236be434"}]}